<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29582">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src: Get rid of duplicated includes<br><br>Change-Id: I252a1cd77bf647477edb7dddadb7e527de872439<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/arch/x86/pirq_routing.c<br>M src/lib/prog_loaders.c<br>M src/mainboard/advansus/a785e-i/romstage.c<br>M src/mainboard/amd/bimini_fam10/romstage.c<br>M src/mainboard/amd/db-ft3b-lc/romstage.c<br>M src/mainboard/amd/lamar/mptable.c<br>M src/mainboard/amd/lamar/romstage.c<br>M src/mainboard/amd/mahogany_fam10/romstage.c<br>M src/mainboard/amd/olivehillplus/romstage.c<br>M src/mainboard/amd/serengeti_cheetah_fam10/mainboard.c<br>M src/mainboard/amd/serengeti_cheetah_fam10/romstage.c<br>M src/mainboard/amd/tilapia_fam10/romstage.c<br>M src/mainboard/apple/macbook21/mainboard.c<br>M src/mainboard/asus/kcma-d8/romstage.c<br>M src/mainboard/asus/kfsn4-dre/get_bus_conf.c<br>M src/mainboard/asus/kfsn4-dre/romstage.c<br>M src/mainboard/asus/kgpe-d16/romstage.c<br>M src/mainboard/asus/m4a78-em/romstage.c<br>M src/mainboard/asus/m4a785-m/romstage.c<br>M src/mainboard/asus/m5a88-v/romstage.c<br>M src/mainboard/avalue/eax-785e/romstage.c<br>M src/mainboard/bap/ode_e21XX/romstage.c<br>M src/mainboard/cavium/cn8100_sff_evb/mainboard.c<br>M src/mainboard/gigabyte/ma785gm/romstage.c<br>M src/mainboard/gigabyte/ma785gmt/romstage.c<br>M src/mainboard/gigabyte/ma78gm/romstage.c<br>M src/mainboard/google/jecht/smihandler.c<br>M src/mainboard/hp/dl165_g6_fam10/romstage.c<br>M src/mainboard/iei/kino-780am2-fam10/romstage.c<br>M src/mainboard/jetway/pa78vm5/romstage.c<br>M src/mainboard/lenovo/x60/dock.c<br>M src/mainboard/msi/ms9652_fam10/romstage.c<br>M src/mainboard/opencellular/elgon/mainboard.c<br>M src/mainboard/packardbell/ms2290/mainboard.c<br>M src/mainboard/pcengines/apu2/romstage.c<br>M src/mainboard/supermicro/h8dmr_fam10/romstage.c<br>M src/mainboard/supermicro/h8qme_fam10/romstage.c<br>M src/mainboard/supermicro/h8scm_fam10/romstage.c<br>M src/mainboard/tyan/s2912_fam10/romstage.c<br>M src/mainboard/via/epia-m850/romstage.c<br>M src/northbridge/amd/amdmct/mct_ddr3/s3utils.c<br>M src/northbridge/amd/pi/00630F01/northbridge.c<br>M src/northbridge/amd/pi/00660F01/northbridge.c<br>M src/northbridge/amd/pi/00730F01/northbridge.c<br>M src/northbridge/intel/fsp_rangeley/acpi.c<br>M src/northbridge/intel/gm45/acpi.c<br>M src/northbridge/intel/gm45/northbridge.c<br>M src/northbridge/intel/i945/acpi.c<br>M src/northbridge/intel/i945/northbridge.c<br>M src/northbridge/intel/i945/raminit.c<br>M src/northbridge/intel/x4x/acpi.c<br>M src/northbridge/via/vx900/early_vx900.h<br>M src/northbridge/via/vx900/raminit_ddr3.c<br>M src/northbridge/via/vx900/traf_ctrl.c<br>M src/security/vboot/secdata_tpm.c<br>M src/soc/cavium/cn81xx/soc.c<br>M src/soc/intel/apollolake/chip.c<br>M src/soc/intel/apollolake/include/soc/pci_devs.h<br>M src/soc/intel/baytrail/acpi.c<br>M src/soc/intel/baytrail/southcluster.c<br>M src/soc/intel/braswell/romstage/romstage.c<br>M src/soc/intel/broadwell/lpc.c<br>M src/soc/intel/broadwell/refcode.c<br>M src/soc/intel/cannonlake/include/soc/pci_devs.h<br>M src/soc/intel/denverton_ns/systemagent.c<br>M src/soc/intel/fsp_baytrail/acpi.c<br>M src/soc/intel/fsp_baytrail/northcluster.c<br>M src/soc/intel/icelake/include/soc/pci_devs.h<br>M src/soc/intel/skylake/chip_fsp20.c<br>M src/soc/intel/skylake/elog.c<br>M src/soc/intel/skylake/include/soc/pci_devs.h<br>M src/soc/nvidia/tegra124/display.c<br>M src/soc/nvidia/tegra210/sor.c<br>M src/southbridge/intel/bd82x6x/lpc.c<br>M src/southbridge/intel/bd82x6x/me.c<br>M src/southbridge/intel/bd82x6x/me_8.x.c<br>M src/southbridge/intel/bd82x6x/smihandler.c<br>M src/southbridge/intel/common/spi.c<br>M src/southbridge/intel/fsp_rangeley/early_init.c<br>M src/southbridge/intel/fsp_rangeley/lpc.c<br>M src/southbridge/intel/fsp_rangeley/soc.h<br>M src/southbridge/intel/fsp_rangeley/spi.c<br>M src/southbridge/intel/ibexpeak/me.c<br>M src/southbridge/intel/ibexpeak/smihandler.c<br>M src/southbridge/intel/lynxpoint/lpc.c<br>M src/southbridge/intel/lynxpoint/pch.h<br>M src/southbridge/nvidia/mcp55/lpc.c<br>87 files changed, 4 insertions(+), 113 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/29582/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/arch/x86/pirq_routing.c b/src/arch/x86/pirq_routing.c</span><br><span>index 7aa50d7..f705944 100644</span><br><span>--- a/src/arch/x86/pirq_routing.c</span><br><span>+++ b/src/arch/x86/pirq_routing.c</span><br><span>@@ -18,7 +18,6 @@</span><br><span> #include <arch/pirq_routing.h></span><br><span> #include <string.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/pirq_routing.h></span><br><span> </span><br><span> void __weak pirq_assign_irqs(const unsigned char pirq[CONFIG_MAX_PIRQ_LINKS])</span><br><span> {</span><br><span>diff --git a/src/lib/prog_loaders.c b/src/lib/prog_loaders.c</span><br><span>index 5004a7f..a9c9add 100644</span><br><span>--- a/src/lib/prog_loaders.c</span><br><span>+++ b/src/lib/prog_loaders.c</span><br><span>@@ -29,7 +29,6 @@</span><br><span> #include <stage_cache.h></span><br><span> #include <symbols.h></span><br><span> #include <timestamp.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cbfs.h></span><br><span> #include <fit_payload.h></span><br><span> </span><br><span> /* Only can represent up to 1 byte less than size_t. */</span><br><span>diff --git a/src/mainboard/advansus/a785e-i/romstage.c b/src/mainboard/advansus/a785e-i/romstage.c</span><br><span>index 281a59a..96c2a1c 100644</span><br><span>--- a/src/mainboard/advansus/a785e-i/romstage.c</span><br><span>+++ b/src/mainboard/advansus/a785e-i/romstage.c</span><br><span>@@ -29,7 +29,6 @@</span><br><span> #include <console/console.h></span><br><span> #include <timestamp.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <commonlib/loglevel.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <superio/winbond/common/winbond.h></span><br><span>diff --git a/src/mainboard/amd/bimini_fam10/romstage.c b/src/mainboard/amd/bimini_fam10/romstage.c</span><br><span>index 51bc5d5..31d7c5c 100644</span><br><span>--- a/src/mainboard/amd/bimini_fam10/romstage.c</span><br><span>+++ b/src/mainboard/amd/bimini_fam10/romstage.c</span><br><span>@@ -30,7 +30,6 @@</span><br><span> #include <timestamp.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <lib.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <commonlib/loglevel.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <cpu/amd/msr.h></span><br><span>diff --git a/src/mainboard/amd/db-ft3b-lc/romstage.c b/src/mainboard/amd/db-ft3b-lc/romstage.c</span><br><span>index 4da9747..4aceeea 100644</span><br><span>--- a/src/mainboard/amd/db-ft3b-lc/romstage.c</span><br><span>+++ b/src/mainboard/amd/db-ft3b-lc/romstage.c</span><br><span>@@ -29,7 +29,6 @@</span><br><span> #include <northbridge/amd/pi/agesawrapper.h></span><br><span> #include <northbridge/amd/pi/agesawrapper_call.h></span><br><span> #include <cpu/x86/bist.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <southbridge/amd/pi/hudson/hudson.h></span><br><span> </span><br><span> void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)</span><br><span>diff --git a/src/mainboard/amd/lamar/mptable.c b/src/mainboard/amd/lamar/mptable.c</span><br><span>index ed16923..27f3a1c 100644</span><br><span>--- a/src/mainboard/amd/lamar/mptable.c</span><br><span>+++ b/src/mainboard/amd/lamar/mptable.c</span><br><span>@@ -23,7 +23,6 @@</span><br><span> #include <cpu/x86/lapic.h></span><br><span> #include <southbridge/amd/common/amd_pci_util.h></span><br><span> #include <drivers/generic/ioapic/chip.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/ioapic.h></span><br><span> #include <southbridge/amd/pi/hudson/amd_pci_int_defs.h></span><br><span> #include <northbridge/amd/pi/00630F01/pci_devs.h></span><br><span> </span><br><span>diff --git a/src/mainboard/amd/lamar/romstage.c b/src/mainboard/amd/lamar/romstage.c</span><br><span>index 136e392..7f811c5 100644</span><br><span>--- a/src/mainboard/amd/lamar/romstage.c</span><br><span>+++ b/src/mainboard/amd/lamar/romstage.c</span><br><span>@@ -29,7 +29,6 @@</span><br><span> #include <northbridge/amd/pi/agesawrapper.h></span><br><span> #include <northbridge/amd/pi/agesawrapper_call.h></span><br><span> #include <cpu/x86/bist.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <southbridge/amd/common/amd_defs.h></span><br><span> #include <southbridge/amd/pi/hudson/hudson.h></span><br><span> #include <superio/fintek/f81216h/f81216h.h></span><br><span>diff --git a/src/mainboard/amd/mahogany_fam10/romstage.c b/src/mainboard/amd/mahogany_fam10/romstage.c</span><br><span>index e9f3111..77885d4 100644</span><br><span>--- a/src/mainboard/amd/mahogany_fam10/romstage.c</span><br><span>+++ b/src/mainboard/amd/mahogany_fam10/romstage.c</span><br><span>@@ -32,7 +32,6 @@</span><br><span> #include <timestamp.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <lib.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <commonlib/loglevel.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <superio/ite/common/ite.h></span><br><span>diff --git a/src/mainboard/amd/olivehillplus/romstage.c b/src/mainboard/amd/olivehillplus/romstage.c</span><br><span>index 4ad0f6d..3cd8b73 100644</span><br><span>--- a/src/mainboard/amd/olivehillplus/romstage.c</span><br><span>+++ b/src/mainboard/amd/olivehillplus/romstage.c</span><br><span>@@ -29,7 +29,6 @@</span><br><span> #include <northbridge/amd/pi/agesawrapper.h></span><br><span> #include <northbridge/amd/pi/agesawrapper_call.h></span><br><span> #include <cpu/x86/bist.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <southbridge/amd/pi/hudson/hudson.h></span><br><span> </span><br><span> void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)</span><br><span>diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/mainboard.c b/src/mainboard/amd/serengeti_cheetah_fam10/mainboard.c</span><br><span>index 374420d..fee0109 100644</span><br><span>--- a/src/mainboard/amd/serengeti_cheetah_fam10/mainboard.c</span><br><span>+++ b/src/mainboard/amd/serengeti_cheetah_fam10/mainboard.c</span><br><span>@@ -13,7 +13,6 @@</span><br><span> </span><br><span> #include <device/device.h></span><br><span> #include <arch/acpi.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span> #include <arch/acpigen.h></span><br><span> #include "mainboard.h"</span><br><span> </span><br><span>diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c b/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c</span><br><span>index 622784b..0433840 100644</span><br><span>--- a/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c</span><br><span>+++ b/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <lib.h></span><br><span> #include <spd.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <commonlib/loglevel.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <cpu/amd/car.h></span><br><span>diff --git a/src/mainboard/amd/tilapia_fam10/romstage.c b/src/mainboard/amd/tilapia_fam10/romstage.c</span><br><span>index fbb9238..c27543c 100644</span><br><span>--- a/src/mainboard/amd/tilapia_fam10/romstage.c</span><br><span>+++ b/src/mainboard/amd/tilapia_fam10/romstage.c</span><br><span>@@ -30,7 +30,6 @@</span><br><span> #include <timestamp.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <lib.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <commonlib/loglevel.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <superio/ite/common/ite.h></span><br><span>diff --git a/src/mainboard/apple/macbook21/mainboard.c b/src/mainboard/apple/macbook21/mainboard.c</span><br><span>index eb963ee..49d3427 100644</span><br><span>--- a/src/mainboard/apple/macbook21/mainboard.c</span><br><span>+++ b/src/mainboard/apple/macbook21/mainboard.c</span><br><span>@@ -21,7 +21,6 @@</span><br><span> #include <device/pci_def.h></span><br><span> #include <device/pci_ops.h></span><br><span> #include <device/pci_ids.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/io.h></span><br><span> #include <arch/interrupt.h></span><br><span> #include <northbridge/intel/i945/i945.h></span><br><span> #include <arch/x86/include/arch/acpigen.h></span><br><span>diff --git a/src/mainboard/asus/kcma-d8/romstage.c b/src/mainboard/asus/kcma-d8/romstage.c</span><br><span>index ec76c45..9e2dd79 100644</span><br><span>--- a/src/mainboard/asus/kcma-d8/romstage.c</span><br><span>+++ b/src/mainboard/asus/kcma-d8/romstage.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> #include <spd.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <delay.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <superio/winbond/common/winbond.h></span><br><span> #include <superio/winbond/w83667hg-a/w83667hg-a.h></span><br><span> #include <cpu/x86/bist.h></span><br><span>diff --git a/src/mainboard/asus/kfsn4-dre/get_bus_conf.c b/src/mainboard/asus/kfsn4-dre/get_bus_conf.c</span><br><span>index 4b23ca5..5c8c75e 100644</span><br><span>--- a/src/mainboard/asus/kfsn4-dre/get_bus_conf.c</span><br><span>+++ b/src/mainboard/asus/kfsn4-dre/get_bus_conf.c</span><br><span>@@ -26,7 +26,6 @@</span><br><span> #include <stdlib.h></span><br><span> #include <cpu/amd/multicore.h></span><br><span> #include <cpu/amd/amdfam10_sysconf.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <stdlib.h></span><br><span> </span><br><span> /*</span><br><span> * Global variables for MB layouts and these will be shared by irqtable,</span><br><span>diff --git a/src/mainboard/asus/kfsn4-dre/romstage.c b/src/mainboard/asus/kfsn4-dre/romstage.c</span><br><span>index 6045274..6d15f51 100644</span><br><span>--- a/src/mainboard/asus/kfsn4-dre/romstage.c</span><br><span>+++ b/src/mainboard/asus/kfsn4-dre/romstage.c</span><br><span>@@ -38,7 +38,6 @@</span><br><span> #include <southbridge/amd/common/reset.h></span><br><span> #include <southbridge/nvidia/ck804/early_smbus.h></span><br><span> #include <delay.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <superio/winbond/common/winbond.h></span><br><span> #include <superio/winbond/w83627thg/w83627thg.h></span><br><span> #include <cpu/x86/bist.h></span><br><span>diff --git a/src/mainboard/asus/kgpe-d16/romstage.c b/src/mainboard/asus/kgpe-d16/romstage.c</span><br><span>index 9b72a79..190beba 100644</span><br><span>--- a/src/mainboard/asus/kgpe-d16/romstage.c</span><br><span>+++ b/src/mainboard/asus/kgpe-d16/romstage.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> #include <spd.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <delay.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <superio/winbond/common/winbond.h></span><br><span> #include <superio/winbond/w83667hg-a/w83667hg-a.h></span><br><span> #include <cpu/x86/bist.h></span><br><span>diff --git a/src/mainboard/asus/m4a78-em/romstage.c b/src/mainboard/asus/m4a78-em/romstage.c</span><br><span>index 4184586..f33b671 100644</span><br><span>--- a/src/mainboard/asus/m4a78-em/romstage.c</span><br><span>+++ b/src/mainboard/asus/m4a78-em/romstage.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> #include <timestamp.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <lib.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <commonlib/loglevel.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <superio/ite/common/ite.h></span><br><span>diff --git a/src/mainboard/asus/m4a785-m/romstage.c b/src/mainboard/asus/m4a785-m/romstage.c</span><br><span>index d7538c8..1cb77d6 100644</span><br><span>--- a/src/mainboard/asus/m4a785-m/romstage.c</span><br><span>+++ b/src/mainboard/asus/m4a785-m/romstage.c</span><br><span>@@ -32,7 +32,6 @@</span><br><span> #include <timestamp.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <lib.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <commonlib/loglevel.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <superio/ite/common/ite.h></span><br><span>diff --git a/src/mainboard/asus/m5a88-v/romstage.c b/src/mainboard/asus/m5a88-v/romstage.c</span><br><span>index 512c08e..54ec940 100644</span><br><span>--- a/src/mainboard/asus/m5a88-v/romstage.c</span><br><span>+++ b/src/mainboard/asus/m5a88-v/romstage.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> #include <console/console.h></span><br><span> #include <timestamp.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <commonlib/loglevel.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <superio/ite/common/ite.h></span><br><span>diff --git a/src/mainboard/avalue/eax-785e/romstage.c b/src/mainboard/avalue/eax-785e/romstage.c</span><br><span>index 49352ca..96a6703 100644</span><br><span>--- a/src/mainboard/avalue/eax-785e/romstage.c</span><br><span>+++ b/src/mainboard/avalue/eax-785e/romstage.c</span><br><span>@@ -29,7 +29,6 @@</span><br><span> #include <console/console.h></span><br><span> #include <timestamp.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <commonlib/loglevel.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <superio/winbond/common/winbond.h></span><br><span>diff --git a/src/mainboard/bap/ode_e21XX/romstage.c b/src/mainboard/bap/ode_e21XX/romstage.c</span><br><span>index 576a3ee..eefda26 100644</span><br><span>--- a/src/mainboard/bap/ode_e21XX/romstage.c</span><br><span>+++ b/src/mainboard/bap/ode_e21XX/romstage.c</span><br><span>@@ -29,7 +29,6 @@</span><br><span> #include <northbridge/amd/pi/agesawrapper.h></span><br><span> #include <northbridge/amd/pi/agesawrapper_call.h></span><br><span> #include <cpu/x86/bist.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <southbridge/amd/pi/hudson/hudson.h></span><br><span> #include <superio/fintek/common/fintek.h></span><br><span> #include <superio/fintek/f81866d/f81866d.h></span><br><span>diff --git a/src/mainboard/cavium/cn8100_sff_evb/mainboard.c b/src/mainboard/cavium/cn8100_sff_evb/mainboard.c</span><br><span>index ce896f2..fd0d928 100644</span><br><span>--- a/src/mainboard/cavium/cn8100_sff_evb/mainboard.c</span><br><span>+++ b/src/mainboard/cavium/cn8100_sff_evb/mainboard.c</span><br><span>@@ -25,7 +25,6 @@</span><br><span> #include <soc/uart.h></span><br><span> #include <console/console.h></span><br><span> #include <soc/clock.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <soc/gpio.h></span><br><span> #include <soc/timer.h></span><br><span> #include <soc/cpu.h></span><br><span> #include <soc/sdram.h></span><br><span>diff --git a/src/mainboard/gigabyte/ma785gm/romstage.c b/src/mainboard/gigabyte/ma785gm/romstage.c</span><br><span>index 87bfaba..c69bf81 100644</span><br><span>--- a/src/mainboard/gigabyte/ma785gm/romstage.c</span><br><span>+++ b/src/mainboard/gigabyte/ma785gm/romstage.c</span><br><span>@@ -28,7 +28,6 @@</span><br><span> #include <timestamp.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <lib.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <commonlib/loglevel.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <superio/ite/common/ite.h></span><br><span>diff --git a/src/mainboard/gigabyte/ma785gmt/romstage.c b/src/mainboard/gigabyte/ma785gmt/romstage.c</span><br><span>index 0b9e07d..91c7623 100644</span><br><span>--- a/src/mainboard/gigabyte/ma785gmt/romstage.c</span><br><span>+++ b/src/mainboard/gigabyte/ma785gmt/romstage.c</span><br><span>@@ -28,7 +28,6 @@</span><br><span> #include <timestamp.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <lib.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <commonlib/loglevel.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <superio/ite/common/ite.h></span><br><span>diff --git a/src/mainboard/gigabyte/ma78gm/romstage.c b/src/mainboard/gigabyte/ma78gm/romstage.c</span><br><span>index 8dbdfb0..e81e4d9 100644</span><br><span>--- a/src/mainboard/gigabyte/ma78gm/romstage.c</span><br><span>+++ b/src/mainboard/gigabyte/ma78gm/romstage.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> #include <timestamp.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <lib.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <commonlib/loglevel.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <superio/ite/common/ite.h></span><br><span>diff --git a/src/mainboard/google/jecht/smihandler.c b/src/mainboard/google/jecht/smihandler.c</span><br><span>index 8243354..b9a84bf 100644</span><br><span>--- a/src/mainboard/google/jecht/smihandler.c</span><br><span>+++ b/src/mainboard/google/jecht/smihandler.c</span><br><span>@@ -25,8 +25,6 @@</span><br><span> #include <soc/gpio.h></span><br><span> #include <soc/iomap.h></span><br><span> #include <soc/nvs.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <soc/pm.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <soc/smm.h></span><br><span> #include "onboard.h"</span><br><span> </span><br><span> int mainboard_io_trap_handler(int smif)</span><br><span>diff --git a/src/mainboard/hp/dl165_g6_fam10/romstage.c b/src/mainboard/hp/dl165_g6_fam10/romstage.c</span><br><span>index 5af01c1..f972872 100644</span><br><span>--- a/src/mainboard/hp/dl165_g6_fam10/romstage.c</span><br><span>+++ b/src/mainboard/hp/dl165_g6_fam10/romstage.c</span><br><span>@@ -38,7 +38,6 @@</span><br><span> #include <lib.h></span><br><span> #include <spd.h></span><br><span> #include <delay.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <superio/serverengines/pilot/pilot.h></span><br><span> #include <superio/nsc/pc87417/pc87417.h></span><br><span> #include <cpu/x86/bist.h></span><br><span>diff --git a/src/mainboard/iei/kino-780am2-fam10/romstage.c b/src/mainboard/iei/kino-780am2-fam10/romstage.c</span><br><span>index 815cf34..6d6f148 100644</span><br><span>--- a/src/mainboard/iei/kino-780am2-fam10/romstage.c</span><br><span>+++ b/src/mainboard/iei/kino-780am2-fam10/romstage.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> #include <timestamp.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <lib.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <commonlib/loglevel.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <superio/fintek/common/fintek.h></span><br><span>diff --git a/src/mainboard/jetway/pa78vm5/romstage.c b/src/mainboard/jetway/pa78vm5/romstage.c</span><br><span>index 440d703..4dfd71e 100644</span><br><span>--- a/src/mainboard/jetway/pa78vm5/romstage.c</span><br><span>+++ b/src/mainboard/jetway/pa78vm5/romstage.c</span><br><span>@@ -32,7 +32,6 @@</span><br><span> #include <timestamp.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <lib.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <commonlib/loglevel.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <superio/fintek/common/fintek.h></span><br><span>diff --git a/src/mainboard/lenovo/x60/dock.c b/src/mainboard/lenovo/x60/dock.c</span><br><span>index f55428e..b94d818 100644</span><br><span>--- a/src/mainboard/lenovo/x60/dock.c</span><br><span>+++ b/src/mainboard/lenovo/x60/dock.c</span><br><span>@@ -18,7 +18,6 @@</span><br><span> #include <device/device.h></span><br><span> #include <arch/io.h></span><br><span> #include <delay.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/io.h></span><br><span> #include "dock.h"</span><br><span> #include <southbridge/intel/i82801gx/i82801gx.h></span><br><span> #include <superio/nsc/pc87392/pc87392.h></span><br><span>diff --git a/src/mainboard/msi/ms9652_fam10/romstage.c b/src/mainboard/msi/ms9652_fam10/romstage.c</span><br><span>index 3d22439..5ff2ac2 100644</span><br><span>--- a/src/mainboard/msi/ms9652_fam10/romstage.c</span><br><span>+++ b/src/mainboard/msi/ms9652_fam10/romstage.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> #include <spd.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <delay.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <cpu/amd/car.h></span><br><span> #include <cpu/amd/msr.h></span><br><span> #include <superio/winbond/common/winbond.h></span><br><span>diff --git a/src/mainboard/opencellular/elgon/mainboard.c b/src/mainboard/opencellular/elgon/mainboard.c</span><br><span>index 45a7155..d140bc1 100644</span><br><span>--- a/src/mainboard/opencellular/elgon/mainboard.c</span><br><span>+++ b/src/mainboard/opencellular/elgon/mainboard.c</span><br><span>@@ -24,14 +24,12 @@</span><br><span> #include <soc/uart.h></span><br><span> #include <console/console.h></span><br><span> #include <soc/clock.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <soc/gpio.h></span><br><span> #include <soc/timer.h></span><br><span> #include <soc/cpu.h></span><br><span> #include <soc/sdram.h></span><br><span> #include <soc/spi.h></span><br><span> #include <spi_flash.h></span><br><span> #include <fmap.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <libbdk-hal/bdk-config.h></span><br><span> </span><br><span> static void mainboard_print_info(void)</span><br><span> {</span><br><span>diff --git a/src/mainboard/packardbell/ms2290/mainboard.c b/src/mainboard/packardbell/ms2290/mainboard.c</span><br><span>index 2691b67..77a626d 100644</span><br><span>--- a/src/mainboard/packardbell/ms2290/mainboard.c</span><br><span>+++ b/src/mainboard/packardbell/ms2290/mainboard.c</span><br><span>@@ -23,7 +23,6 @@</span><br><span> #include <device/pci_def.h></span><br><span> #include <device/pci_ops.h></span><br><span> #include <device/pci_ids.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/io.h></span><br><span> #include <northbridge/intel/nehalem/nehalem.h></span><br><span> #include <southbridge/intel/bd82x6x/pch.h></span><br><span> #include <ec/acpi/ec.h></span><br><span>diff --git a/src/mainboard/pcengines/apu2/romstage.c b/src/mainboard/pcengines/apu2/romstage.c</span><br><span>index 3c5eed6..55a89fb 100644</span><br><span>--- a/src/mainboard/pcengines/apu2/romstage.c</span><br><span>+++ b/src/mainboard/pcengines/apu2/romstage.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> #include <northbridge/amd/pi/agesawrapper.h></span><br><span> #include <northbridge/amd/pi/agesawrapper_call.h></span><br><span> #include <cpu/x86/bist.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <southbridge/amd/pi/hudson/hudson.h></span><br><span> #include <superio/nuvoton/common/nuvoton.h></span><br><span> #include <superio/nuvoton/nct5104d/nct5104d.h></span><br><span>diff --git a/src/mainboard/supermicro/h8dmr_fam10/romstage.c b/src/mainboard/supermicro/h8dmr_fam10/romstage.c</span><br><span>index 3fb3ca0..73f5857 100644</span><br><span>--- a/src/mainboard/supermicro/h8dmr_fam10/romstage.c</span><br><span>+++ b/src/mainboard/supermicro/h8dmr_fam10/romstage.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> #include <spd.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <delay.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <superio/winbond/common/winbond.h></span><br><span> #include <superio/winbond/w83627hf/w83627hf.h></span><br><span> #include <cpu/x86/bist.h></span><br><span>diff --git a/src/mainboard/supermicro/h8qme_fam10/romstage.c b/src/mainboard/supermicro/h8qme_fam10/romstage.c</span><br><span>index 5ea0f64..42ad6ab 100644</span><br><span>--- a/src/mainboard/supermicro/h8qme_fam10/romstage.c</span><br><span>+++ b/src/mainboard/supermicro/h8qme_fam10/romstage.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> #include <spd.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <delay.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <superio/winbond/common/winbond.h></span><br><span> #include <superio/winbond/w83627hf/w83627hf.h></span><br><span> #include <cpu/x86/bist.h></span><br><span>diff --git a/src/mainboard/supermicro/h8scm_fam10/romstage.c b/src/mainboard/supermicro/h8scm_fam10/romstage.c</span><br><span>index 11da86e..6a4a5f8 100644</span><br><span>--- a/src/mainboard/supermicro/h8scm_fam10/romstage.c</span><br><span>+++ b/src/mainboard/supermicro/h8scm_fam10/romstage.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> #include <timestamp.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <lib.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <commonlib/loglevel.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <cpu/amd/msr.h></span><br><span>diff --git a/src/mainboard/tyan/s2912_fam10/romstage.c b/src/mainboard/tyan/s2912_fam10/romstage.c</span><br><span>index 99d58f8..4c2b4c5 100644</span><br><span>--- a/src/mainboard/tyan/s2912_fam10/romstage.c</span><br><span>+++ b/src/mainboard/tyan/s2912_fam10/romstage.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> #include <spd.h></span><br><span> #include <cpu/amd/model_10xxx_rev.h></span><br><span> #include <delay.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span> #include <cpu/amd/car.h></span><br><span> #include <cpu/amd/msr.h></span><br><span> #include <superio/winbond/common/winbond.h></span><br><span>diff --git a/src/mainboard/via/epia-m850/romstage.c b/src/mainboard/via/epia-m850/romstage.c</span><br><span>index e75a679..db03103 100644</span><br><span>--- a/src/mainboard/via/epia-m850/romstage.c</span><br><span>+++ b/src/mainboard/via/epia-m850/romstage.c</span><br><span>@@ -22,7 +22,6 @@</span><br><span> #include <device/pci_ids.h></span><br><span> #include <arch/io.h></span><br><span> #include <device/pnp_def.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/io.h></span><br><span> #include <console/console.h></span><br><span> #include <lib.h></span><br><span> #include <cpu/x86/bist.h></span><br><span>diff --git a/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c b/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c</span><br><span>index 6fd5b36..eb39c81 100644</span><br><span>--- a/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c</span><br><span>+++ b/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c</span><br><span>@@ -30,8 +30,6 @@</span><br><span> #include <spi_flash.h></span><br><span> #include <pc80/mc146818rtc.h></span><br><span> #include <inttypes.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <console/console.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <string.h></span><br><span> #include "mct_d.h"</span><br><span> #include "mct_d_gcc.h"</span><br><span> </span><br><span>diff --git a/src/northbridge/amd/pi/00630F01/northbridge.c b/src/northbridge/amd/pi/00630F01/northbridge.c</span><br><span>index f6cb285..7a24d11 100644</span><br><span>--- a/src/northbridge/amd/pi/00630F01/northbridge.c</span><br><span>+++ b/src/northbridge/amd/pi/00630F01/northbridge.c</span><br><span>@@ -33,7 +33,6 @@</span><br><span> #include <cpu/x86/lapic.h></span><br><span> #include <cpu/amd/msr.h></span><br><span> #include <cpu/amd/mtrr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span> #include <arch/acpigen.h></span><br><span> #include <assert.h></span><br><span> #include <northbridge/amd/agesa/agesa_helper.h></span><br><span>diff --git a/src/northbridge/amd/pi/00660F01/northbridge.c b/src/northbridge/amd/pi/00660F01/northbridge.c</span><br><span>index fb3610d..826ce3e 100644</span><br><span>--- a/src/northbridge/amd/pi/00660F01/northbridge.c</span><br><span>+++ b/src/northbridge/amd/pi/00660F01/northbridge.c</span><br><span>@@ -33,7 +33,6 @@</span><br><span> #include <cpu/x86/lapic.h></span><br><span> #include <cpu/amd/msr.h></span><br><span> #include <cpu/amd/mtrr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span> #include <arch/acpigen.h></span><br><span> #include <northbridge/amd/agesa/agesa_helper.h></span><br><span> #if IS_ENABLED(CONFIG_BINARYPI_LEGACY_WRAPPER)</span><br><span>diff --git a/src/northbridge/amd/pi/00730F01/northbridge.c b/src/northbridge/amd/pi/00730F01/northbridge.c</span><br><span>index 7125e1e..804ce6e 100644</span><br><span>--- a/src/northbridge/amd/pi/00730F01/northbridge.c</span><br><span>+++ b/src/northbridge/amd/pi/00730F01/northbridge.c</span><br><span>@@ -35,7 +35,6 @@</span><br><span> #include <cpu/x86/lapic.h></span><br><span> #include <cpu/amd/msr.h></span><br><span> #include <cpu/amd/mtrr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span> #include <arch/acpigen.h></span><br><span> #include <northbridge/amd/agesa/agesa_helper.h></span><br><span> #if IS_ENABLED(CONFIG_BINARYPI_LEGACY_WRAPPER)</span><br><span>diff --git a/src/northbridge/intel/fsp_rangeley/acpi.c b/src/northbridge/intel/fsp_rangeley/acpi.c</span><br><span>index c8e6d45..23044b7 100644</span><br><span>--- a/src/northbridge/intel/fsp_rangeley/acpi.c</span><br><span>+++ b/src/northbridge/intel/fsp_rangeley/acpi.c</span><br><span>@@ -24,7 +24,6 @@</span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span> #include <device/pci_ids.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span> #include <arch/acpigen.h></span><br><span> #include "northbridge.h"</span><br><span> </span><br><span>diff --git a/src/northbridge/intel/gm45/acpi.c b/src/northbridge/intel/gm45/acpi.c</span><br><span>index d208eed..1fd7a46 100644</span><br><span>--- a/src/northbridge/intel/gm45/acpi.c</span><br><span>+++ b/src/northbridge/intel/gm45/acpi.c</span><br><span>@@ -23,7 +23,6 @@</span><br><span> #include <device/pci.h></span><br><span> #include <device/pci_ids.h></span><br><span> #include <cbmem.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpigen.h></span><br><span> #include <cpu/cpu.h></span><br><span> #include "gm45.h"</span><br><span> </span><br><span>diff --git a/src/northbridge/intel/gm45/northbridge.c b/src/northbridge/intel/gm45/northbridge.c</span><br><span>index 405eb5d..a738905 100644</span><br><span>--- a/src/northbridge/intel/gm45/northbridge.c</span><br><span>+++ b/src/northbridge/intel/gm45/northbridge.c</span><br><span>@@ -25,7 +25,6 @@</span><br><span> #include <cpu/cpu.h></span><br><span> #include <boot/tables.h></span><br><span> #include <arch/acpi.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cbmem.h></span><br><span> #include <cpu/intel/smm/gen1/smi.h></span><br><span> #include "chip.h"</span><br><span> #include "gm45.h"</span><br><span>diff --git a/src/northbridge/intel/i945/acpi.c b/src/northbridge/intel/i945/acpi.c</span><br><span>index 990d3de..c959966 100644</span><br><span>--- a/src/northbridge/intel/i945/acpi.c</span><br><span>+++ b/src/northbridge/intel/i945/acpi.c</span><br><span>@@ -23,7 +23,6 @@</span><br><span> #include <device/pci.h></span><br><span> #include <device/pci_ids.h></span><br><span> #include <cbmem.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpigen.h></span><br><span> #include <cpu/cpu.h></span><br><span> #include "i945.h"</span><br><span> </span><br><span>diff --git a/src/northbridge/intel/i945/northbridge.c b/src/northbridge/intel/i945/northbridge.c</span><br><span>index de55cc3..bec0c58 100644</span><br><span>--- a/src/northbridge/intel/i945/northbridge.c</span><br><span>+++ b/src/northbridge/intel/i945/northbridge.c</span><br><span>@@ -22,7 +22,6 @@</span><br><span> #include <device/pci_ids.h></span><br><span> #include <stdlib.h></span><br><span> #include <string.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cbmem.h></span><br><span> #include <cpu/cpu.h></span><br><span> #include <arch/acpi.h></span><br><span> #include "i945.h"</span><br><span>diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c</span><br><span>index 71d9853..ed93daa 100644</span><br><span>--- a/src/northbridge/intel/i945/raminit.c</span><br><span>+++ b/src/northbridge/intel/i945/raminit.c</span><br><span>@@ -23,7 +23,6 @@</span><br><span> #include <spd.h></span><br><span> #include <string.h></span><br><span> #include <halt.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <lib.h></span><br><span> #include "raminit.h"</span><br><span> #include "i945.h"</span><br><span> #include "chip.h"</span><br><span>diff --git a/src/northbridge/intel/x4x/acpi.c b/src/northbridge/intel/x4x/acpi.c</span><br><span>index 678486c..12bdf65 100644</span><br><span>--- a/src/northbridge/intel/x4x/acpi.c</span><br><span>+++ b/src/northbridge/intel/x4x/acpi.c</span><br><span>@@ -24,7 +24,6 @@</span><br><span> #include <device/pci.h></span><br><span> #include <device/pci_ids.h></span><br><span> #include <cbmem.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpigen.h></span><br><span> #include <cpu/cpu.h></span><br><span> #include "x4x.h"</span><br><span> </span><br><span>diff --git a/src/northbridge/via/vx900/early_vx900.h b/src/northbridge/via/vx900/early_vx900.h</span><br><span>index 11c561a..55b6c69 100644</span><br><span>--- a/src/northbridge/via/vx900/early_vx900.h</span><br><span>+++ b/src/northbridge/via/vx900/early_vx900.h</span><br><span>@@ -23,7 +23,6 @@</span><br><span> #include <arch/io.h></span><br><span> #include <cbmem.h></span><br><span> #include <stdint.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/io.h></span><br><span> </span><br><span> /* North Module devices */</span><br><span> #define HOST_CTR PCI_DEV(0, 0, 0)</span><br><span>diff --git a/src/northbridge/via/vx900/raminit_ddr3.c b/src/northbridge/via/vx900/raminit_ddr3.c</span><br><span>index 17a87bb..1d05fa7 100644</span><br><span>--- a/src/northbridge/via/vx900/raminit_ddr3.c</span><br><span>+++ b/src/northbridge/via/vx900/raminit_ddr3.c</span><br><span>@@ -17,7 +17,6 @@</span><br><span> #include "early_vx900.h"</span><br><span> #include "raminit.h"</span><br><span> #include <arch/io.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/io.h></span><br><span> #include <console/console.h></span><br><span> #include <device/pci_ids.h></span><br><span> #include <delay.h></span><br><span>diff --git a/src/northbridge/via/vx900/traf_ctrl.c b/src/northbridge/via/vx900/traf_ctrl.c</span><br><span>index 8bdf25c..c2b4a48 100644</span><br><span>--- a/src/northbridge/via/vx900/traf_ctrl.c</span><br><span>+++ b/src/northbridge/via/vx900/traf_ctrl.c</span><br><span>@@ -17,8 +17,6 @@</span><br><span> #include <device/pci.h></span><br><span> #include <device/pci_ids.h></span><br><span> #include <console/console.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <drivers/generic/ioapic/chip.h></span><br><span> </span><br><span> #include "vx900.h"</span><br><span>diff --git a/src/security/vboot/secdata_tpm.c b/src/security/vboot/secdata_tpm.c</span><br><span>index c62f18b..f639e35 100644</span><br><span>--- a/src/security/vboot/secdata_tpm.c</span><br><span>+++ b/src/security/vboot/secdata_tpm.c</span><br><span>@@ -47,7 +47,6 @@</span><br><span> #include <stdio.h></span><br><span> #define VBDEBUG(format, args...) printf(format, ## args)</span><br><span> #else</span><br><span style="color: hsl(0, 100%, 40%);">-#include <console/console.h></span><br><span> #define VBDEBUG(format, args...) \</span><br><span> printk(BIOS_INFO, "%s():%d: " format, __func__, __LINE__, ## args)</span><br><span> #endif</span><br><span>diff --git a/src/soc/cavium/cn81xx/soc.c b/src/soc/cavium/cn81xx/soc.c</span><br><span>index 0bf76f7..53a9913 100644</span><br><span>--- a/src/soc/cavium/cn81xx/soc.c</span><br><span>+++ b/src/soc/cavium/cn81xx/soc.c</span><br><span>@@ -33,7 +33,6 @@</span><br><span> #include <soc/ecam0.h></span><br><span> #include <console/uart.h></span><br><span> #include <libbdk-hal/bdk-pcie.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <soc/ecam0.h></span><br><span> #include <device/pci.h></span><br><span> #include <libbdk-hal/bdk-qlm.h></span><br><span> #include <libbdk-hal/bdk-config.h></span><br><span>diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c</span><br><span>index e70bfa3..7df2324 100644</span><br><span>--- a/src/soc/intel/apollolake/chip.c</span><br><span>+++ b/src/soc/intel/apollolake/chip.c</span><br><span>@@ -34,7 +34,6 @@</span><br><span> #include <intelblocks/xdci.h></span><br><span> #include <fsp/api.h></span><br><span> #include <fsp/util.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <intelblocks/acpi.h></span><br><span> #include <intelblocks/cpulib.h></span><br><span> #include <intelblocks/itss.h></span><br><span> #include <intelblocks/pmclib.h></span><br><span>diff --git a/src/soc/intel/apollolake/include/soc/pci_devs.h b/src/soc/intel/apollolake/include/soc/pci_devs.h</span><br><span>index 37d0fab..ad726f8 100644</span><br><span>--- a/src/soc/intel/apollolake/include/soc/pci_devs.h</span><br><span>+++ b/src/soc/intel/apollolake/include/soc/pci_devs.h</span><br><span>@@ -23,7 +23,6 @@</span><br><span> </span><br><span> #if !defined(__SIMPLE_DEVICE__)</span><br><span> #include <device/device.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_def.h></span><br><span> #define _SA_DEV(slot) dev_find_slot(0, _SA_DEVFN(slot))</span><br><span> #define _PCH_DEV(slot, func) dev_find_slot(0, _PCH_DEVFN(slot, func))</span><br><span> #else</span><br><span>diff --git a/src/soc/intel/baytrail/acpi.c b/src/soc/intel/baytrail/acpi.c</span><br><span>index cdf3abf..4e85b32 100644</span><br><span>--- a/src/soc/intel/baytrail/acpi.c</span><br><span>+++ b/src/soc/intel/baytrail/acpi.c</span><br><span>@@ -21,7 +21,6 @@</span><br><span> #include <cbmem.h></span><br><span> #include <console/console.h></span><br><span> #include <cpu/x86/smm.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <console/console.h></span><br><span> #include <types.h></span><br><span> #include <string.h></span><br><span> #include <arch/cpu.h></span><br><span>diff --git a/src/soc/intel/baytrail/southcluster.c b/src/soc/intel/baytrail/southcluster.c</span><br><span>index 0ef70d0..05bf192 100644</span><br><span>--- a/src/soc/intel/baytrail/southcluster.c</span><br><span>+++ b/src/soc/intel/baytrail/southcluster.c</span><br><span>@@ -36,7 +36,6 @@</span><br><span> #include <soc/ramstage.h></span><br><span> #include <soc/spi.h></span><br><span> #include "chip.h"</span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span> #include <arch/acpigen.h></span><br><span> #include <cpu/cpu.h></span><br><span> </span><br><span>diff --git a/src/soc/intel/braswell/romstage/romstage.c b/src/soc/intel/braswell/romstage/romstage.c</span><br><span>index 03f9ac0..31c7142 100644</span><br><span>--- a/src/soc/intel/braswell/romstage/romstage.c</span><br><span>+++ b/src/soc/intel/braswell/romstage/romstage.c</span><br><span>@@ -22,7 +22,6 @@</span><br><span> #include <arch/io.h></span><br><span> #include <arch/cbfs.h></span><br><span> #include <arch/stages.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cbmem.h></span><br><span> #include <chip.h></span><br><span> #include <cpu/x86/mtrr.h></span><br><span> #include <console/console.h></span><br><span>diff --git a/src/soc/intel/broadwell/lpc.c b/src/soc/intel/broadwell/lpc.c</span><br><span>index ff7ff81..71560c2 100644</span><br><span>--- a/src/soc/intel/broadwell/lpc.c</span><br><span>+++ b/src/soc/intel/broadwell/lpc.c</span><br><span>@@ -41,9 +41,7 @@</span><br><span> #include <soc/ramstage.h></span><br><span> #include <soc/rcba.h></span><br><span> #include <soc/intel/broadwell/chip.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span> #include <arch/acpigen.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/cpu.h></span><br><span> </span><br><span> static void pch_enable_ioapic(struct device *dev)</span><br><span> {</span><br><span>diff --git a/src/soc/intel/broadwell/refcode.c b/src/soc/intel/broadwell/refcode.c</span><br><span>index 7eb548e..6d192cc 100644</span><br><span>--- a/src/soc/intel/broadwell/refcode.c</span><br><span>+++ b/src/soc/intel/broadwell/refcode.c</span><br><span>@@ -22,7 +22,6 @@</span><br><span> #include <program_loading.h></span><br><span> #include <rmodule.h></span><br><span> #include <stage_cache.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <string.h></span><br><span> #include <soc/pei_data.h></span><br><span> #include <soc/pei_wrapper.h></span><br><span> #include <soc/pm.h></span><br><span>diff --git a/src/soc/intel/cannonlake/include/soc/pci_devs.h b/src/soc/intel/cannonlake/include/soc/pci_devs.h</span><br><span>index 63a59db..77ae746 100644</span><br><span>--- a/src/soc/intel/cannonlake/include/soc/pci_devs.h</span><br><span>+++ b/src/soc/intel/cannonlake/include/soc/pci_devs.h</span><br><span>@@ -25,7 +25,6 @@</span><br><span> </span><br><span> #if !defined(__SIMPLE_DEVICE__)</span><br><span> #include <device/device.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_def.h></span><br><span> #define _SA_DEV(slot) dev_find_slot(0, _SA_DEVFN(slot))</span><br><span> #define _PCH_DEV(slot, func) dev_find_slot(0, _PCH_DEVFN(slot, func))</span><br><span> #else</span><br><span>diff --git a/src/soc/intel/denverton_ns/systemagent.c b/src/soc/intel/denverton_ns/systemagent.c</span><br><span>index 6b72a0c..f41714f 100644</span><br><span>--- a/src/soc/intel/denverton_ns/systemagent.c</span><br><span>+++ b/src/soc/intel/denverton_ns/systemagent.c</span><br><span>@@ -27,7 +27,6 @@</span><br><span> #include <string.h></span><br><span> #include <cbmem.h></span><br><span> #include <romstage_handoff.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <delay.h></span><br><span> #include <timer.h></span><br><span> </span><br><span> #include <soc/iomap.h></span><br><span>diff --git a/src/soc/intel/fsp_baytrail/acpi.c b/src/soc/intel/fsp_baytrail/acpi.c</span><br><span>index 97c8d5b..4d21fe3 100644</span><br><span>--- a/src/soc/intel/fsp_baytrail/acpi.c</span><br><span>+++ b/src/soc/intel/fsp_baytrail/acpi.c</span><br><span>@@ -35,14 +35,12 @@</span><br><span> #include <string.h></span><br><span> #include <soc/iomap.h></span><br><span> #include <soc/lpc.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <soc/pci_devs.h></span><br><span> #include <soc/pmc.h></span><br><span> #include <soc/irq.h></span><br><span> #include <soc/iosf.h></span><br><span> #include <arch/io.h></span><br><span> #include <soc/msr.h></span><br><span> #include <soc/pattrs.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <soc/pmc.h></span><br><span> #include <cpu/cpu.h></span><br><span> #include <cbmem.h></span><br><span> </span><br><span>diff --git a/src/soc/intel/fsp_baytrail/northcluster.c b/src/soc/intel/fsp_baytrail/northcluster.c</span><br><span>index f909121..93cd2f2 100644</span><br><span>--- a/src/soc/intel/fsp_baytrail/northcluster.c</span><br><span>+++ b/src/soc/intel/fsp_baytrail/northcluster.c</span><br><span>@@ -24,7 +24,6 @@</span><br><span> #include <soc/iosf.h></span><br><span> #include <soc/pci_devs.h></span><br><span> #include <soc/ramstage.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci.h></span><br><span> #include <cbmem.h></span><br><span> #include <soc/baytrail.h></span><br><span> #include <drivers/intel/fsp1_0/fsp_util.h></span><br><span>diff --git a/src/soc/intel/icelake/include/soc/pci_devs.h b/src/soc/intel/icelake/include/soc/pci_devs.h</span><br><span>index 9b9e434..94f1d0d 100644</span><br><span>--- a/src/soc/intel/icelake/include/soc/pci_devs.h</span><br><span>+++ b/src/soc/intel/icelake/include/soc/pci_devs.h</span><br><span>@@ -24,7 +24,6 @@</span><br><span> </span><br><span> #if !defined(__SIMPLE_DEVICE__)</span><br><span> #include <device/device.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_def.h></span><br><span> #define _SA_DEV(slot) dev_find_slot(0, _SA_DEVFN(slot))</span><br><span> #define _PCH_DEV(slot, func) dev_find_slot(0, _PCH_DEVFN(slot, func))</span><br><span> #else</span><br><span>diff --git a/src/soc/intel/skylake/chip_fsp20.c b/src/soc/intel/skylake/chip_fsp20.c</span><br><span>index 7cc6de5..8a78348 100644</span><br><span>--- a/src/soc/intel/skylake/chip_fsp20.c</span><br><span>+++ b/src/soc/intel/skylake/chip_fsp20.c</span><br><span>@@ -20,13 +20,9 @@</span><br><span> #include <fsp/api.h></span><br><span> #include <arch/acpi.h></span><br><span> #include <arch/io.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <chip.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <bootstate.h></span><br><span> #include <console/console.h></span><br><span> #include <device/device.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci.h></span><br><span> #include <device/pci_ids.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <fsp/api.h></span><br><span> #include <fsp/util.h></span><br><span> #include <intelblocks/chip.h></span><br><span> #include <intelblocks/itss.h></span><br><span>diff --git a/src/soc/intel/skylake/elog.c b/src/soc/intel/skylake/elog.c</span><br><span>index 25a9610..a2fa52a 100644</span><br><span>--- a/src/soc/intel/skylake/elog.c</span><br><span>+++ b/src/soc/intel/skylake/elog.c</span><br><span>@@ -24,7 +24,6 @@</span><br><span> #include <soc/pci_devs.h></span><br><span> #include <soc/pm.h></span><br><span> #include <soc/smbus.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <stdint.h></span><br><span> </span><br><span> static void pch_log_gpio_gpe(u32 gpe0_sts, u32 gpe0_en, int start)</span><br><span> {</span><br><span>diff --git a/src/soc/intel/skylake/include/soc/pci_devs.h b/src/soc/intel/skylake/include/soc/pci_devs.h</span><br><span>index bc6c9cb..1fc3621 100644</span><br><span>--- a/src/soc/intel/skylake/include/soc/pci_devs.h</span><br><span>+++ b/src/soc/intel/skylake/include/soc/pci_devs.h</span><br><span>@@ -25,7 +25,6 @@</span><br><span> </span><br><span> #if !defined(__SIMPLE_DEVICE__)</span><br><span> #include <device/device.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_def.h></span><br><span> #define _SA_DEV(slot) dev_find_slot(0, _SA_DEVFN(slot))</span><br><span> #define _PCH_DEV(slot, func) dev_find_slot(0, _PCH_DEVFN(slot, func))</span><br><span> #else</span><br><span>diff --git a/src/soc/nvidia/tegra124/display.c b/src/soc/nvidia/tegra124/display.c</span><br><span>index c90e392..e61c40d 100644</span><br><span>--- a/src/soc/nvidia/tegra124/display.c</span><br><span>+++ b/src/soc/nvidia/tegra124/display.c</span><br><span>@@ -30,7 +30,6 @@</span><br><span> #include <soc/nvidia/tegra/pwm.h></span><br><span> #include <stdint.h></span><br><span> #include <stdlib.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <stdlib.h></span><br><span> #include <string.h></span><br><span> </span><br><span> #include "chip.h"</span><br><span>diff --git a/src/soc/nvidia/tegra210/sor.c b/src/soc/nvidia/tegra210/sor.c</span><br><span>index a00bdad..6b6216c 100644</span><br><span>--- a/src/soc/nvidia/tegra210/sor.c</span><br><span>+++ b/src/soc/nvidia/tegra210/sor.c</span><br><span>@@ -24,7 +24,6 @@</span><br><span> #include <delay.h></span><br><span> #include <soc/addressmap.h></span><br><span> #include <device/device.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <stdlib.h></span><br><span> #include <string.h></span><br><span> #include <cpu/cpu.h></span><br><span> #include <boot/tables.h></span><br><span>diff --git a/src/southbridge/intel/bd82x6x/lpc.c b/src/southbridge/intel/bd82x6x/lpc.c</span><br><span>index 67f1de6..07a4d8a 100644</span><br><span>--- a/src/southbridge/intel/bd82x6x/lpc.c</span><br><span>+++ b/src/southbridge/intel/bd82x6x/lpc.c</span><br><span>@@ -32,7 +32,6 @@</span><br><span> #include <cpu/x86/smm.h></span><br><span> #include <cbmem.h></span><br><span> #include <string.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/smm.h></span><br><span> #include "pch.h"</span><br><span> #include "nvs.h"</span><br><span> #include <southbridge/intel/common/pciehp.h></span><br><span>diff --git a/src/southbridge/intel/bd82x6x/me.c b/src/southbridge/intel/bd82x6x/me.c</span><br><span>index da1c7e4..73d11de 100644</span><br><span>--- a/src/southbridge/intel/bd82x6x/me.c</span><br><span>+++ b/src/southbridge/intel/bd82x6x/me.c</span><br><span>@@ -31,13 +31,8 @@</span><br><span> #include <delay.h></span><br><span> #include <elog.h></span><br><span> #include <halt.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#ifdef __SMM__</span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/io.h></span><br><span style="color: hsl(0, 100%, 40%);">-#else</span><br><span> # include <device/device.h></span><br><span> # include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span> </span><br><span> #include "me.h"</span><br><span> #include "pch.h"</span><br><span>diff --git a/src/southbridge/intel/bd82x6x/me_8.x.c b/src/southbridge/intel/bd82x6x/me_8.x.c</span><br><span>index 1a59dc4..419c0ab 100644</span><br><span>--- a/src/southbridge/intel/bd82x6x/me_8.x.c</span><br><span>+++ b/src/southbridge/intel/bd82x6x/me_8.x.c</span><br><span>@@ -31,13 +31,8 @@</span><br><span> #include <delay.h></span><br><span> #include <elog.h></span><br><span> #include <halt.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#ifdef __SMM__</span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/io.h></span><br><span style="color: hsl(0, 100%, 40%);">-#else</span><br><span style="color: hsl(0, 100%, 40%);">-# include <device/device.h></span><br><span style="color: hsl(0, 100%, 40%);">-# include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#include <device/device.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <device/pci.h></span><br><span> </span><br><span> #include "me.h"</span><br><span> #include "pch.h"</span><br><span>diff --git a/src/southbridge/intel/bd82x6x/smihandler.c b/src/southbridge/intel/bd82x6x/smihandler.c</span><br><span>index a108840..03d2687 100644</span><br><span>--- a/src/southbridge/intel/bd82x6x/smihandler.c</span><br><span>+++ b/src/southbridge/intel/bd82x6x/smihandler.c</span><br><span>@@ -28,7 +28,6 @@</span><br><span> #include "nvs.h"</span><br><span> </span><br><span> #include <northbridge/intel/sandybridge/sandybridge.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/io.h></span><br><span> #include <southbridge/intel/bd82x6x/me.h></span><br><span> #include <southbridge/intel/common/gpio.h></span><br><span> #include <cpu/intel/model_206ax/model_206ax.h></span><br><span>diff --git a/src/southbridge/intel/common/spi.c b/src/southbridge/intel/common/spi.c</span><br><span>index 31cdb33..71655bc 100644</span><br><span>--- a/src/southbridge/intel/common/spi.c</span><br><span>+++ b/src/southbridge/intel/common/spi.c</span><br><span>@@ -37,7 +37,6 @@</span><br><span> </span><br><span> </span><br><span> #ifdef __SMM__</span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/io.h></span><br><span> #define pci_read_config_byte(dev, reg, targ)\</span><br><span> *(targ) = pci_read_config8(dev, reg)</span><br><span> #define pci_read_config_word(dev, reg, targ)\</span><br><span>@@ -52,7 +51,6 @@</span><br><span> pci_write_config32(dev, reg, val)</span><br><span> #else /* !__SMM__ */</span><br><span> #include <device/device.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci.h></span><br><span> #define pci_read_config_byte(dev, reg, targ)\</span><br><span> *(targ) = pci_read_config8(dev, reg)</span><br><span> #define pci_read_config_word(dev, reg, targ)\</span><br><span>diff --git a/src/southbridge/intel/fsp_rangeley/early_init.c b/src/southbridge/intel/fsp_rangeley/early_init.c</span><br><span>index ba4ebe0..1ef8cb2 100644</span><br><span>--- a/src/southbridge/intel/fsp_rangeley/early_init.c</span><br><span>+++ b/src/southbridge/intel/fsp_rangeley/early_init.c</span><br><span>@@ -22,7 +22,6 @@</span><br><span> #include <device/pci_def.h></span><br><span> #include <pc80/mc146818rtc.h></span><br><span> #include <version.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_def.h></span><br><span> #include "pci_devs.h"</span><br><span> #include "soc.h"</span><br><span> </span><br><span>diff --git a/src/southbridge/intel/fsp_rangeley/lpc.c b/src/southbridge/intel/fsp_rangeley/lpc.c</span><br><span>index 88cc73f..f490b58 100644</span><br><span>--- a/src/southbridge/intel/fsp_rangeley/lpc.c</span><br><span>+++ b/src/southbridge/intel/fsp_rangeley/lpc.c</span><br><span>@@ -29,7 +29,6 @@</span><br><span> #include <elog.h></span><br><span> #include <string.h></span><br><span> #include <cbmem.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span> #include <arch/acpigen.h></span><br><span> #include "soc.h"</span><br><span> #include "irq.h"</span><br><span>diff --git a/src/southbridge/intel/fsp_rangeley/soc.h b/src/southbridge/intel/fsp_rangeley/soc.h</span><br><span>index 0917201..ffadee4 100644</span><br><span>--- a/src/southbridge/intel/fsp_rangeley/soc.h</span><br><span>+++ b/src/southbridge/intel/fsp_rangeley/soc.h</span><br><span>@@ -62,7 +62,6 @@</span><br><span> int soc_silicon_supported(int type, int rev);</span><br><span> void soc_enable(struct device *dev);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span> void acpi_fill_in_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt);</span><br><span> </span><br><span> #if IS_ENABLED(CONFIG_ELOG)</span><br><span>diff --git a/src/southbridge/intel/fsp_rangeley/spi.c b/src/southbridge/intel/fsp_rangeley/spi.c</span><br><span>index 98ae708..9754806 100644</span><br><span>--- a/src/southbridge/intel/fsp_rangeley/spi.c</span><br><span>+++ b/src/southbridge/intel/fsp_rangeley/spi.c</span><br><span>@@ -29,7 +29,6 @@</span><br><span> static int ich_status_poll(u16 bitmask, int wait_til_set);</span><br><span> </span><br><span> #ifdef __SMM__</span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/io.h></span><br><span> #define pci_read_config_byte(dev, reg, targ)\</span><br><span> *(targ) = pci_read_config8(dev, reg)</span><br><span> #define pci_read_config_word(dev, reg, targ)\</span><br><span>diff --git a/src/southbridge/intel/ibexpeak/me.c b/src/southbridge/intel/ibexpeak/me.c</span><br><span>index 0d75350..e082b73 100644</span><br><span>--- a/src/southbridge/intel/ibexpeak/me.c</span><br><span>+++ b/src/southbridge/intel/ibexpeak/me.c</span><br><span>@@ -30,13 +30,8 @@</span><br><span> #include <string.h></span><br><span> #include <delay.h></span><br><span> #include <elog.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#ifdef __SMM__</span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/io.h></span><br><span style="color: hsl(0, 100%, 40%);">-#else</span><br><span style="color: hsl(0, 100%, 40%);">-# include <device/device.h></span><br><span style="color: hsl(0, 100%, 40%);">-# include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#include <device/device.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <device/pci.h></span><br><span> </span><br><span> #include "me.h"</span><br><span> #include "pch.h"</span><br><span>diff --git a/src/southbridge/intel/ibexpeak/smihandler.c b/src/southbridge/intel/ibexpeak/smihandler.c</span><br><span>index 4da76cf..b70273c 100644</span><br><span>--- a/src/southbridge/intel/ibexpeak/smihandler.c</span><br><span>+++ b/src/southbridge/intel/ibexpeak/smihandler.c</span><br><span>@@ -34,7 +34,6 @@</span><br><span> */</span><br><span> #include <northbridge/intel/nehalem/nehalem.h></span><br><span> #include <southbridge/intel/common/gpio.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/io.h></span><br><span> </span><br><span> /* While we read PMBASE dynamically in case it changed, let's</span><br><span> * initialize it with a sane value</span><br><span>diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c</span><br><span>index 9e0ce8a..d22913c 100644</span><br><span>--- a/src/southbridge/intel/lynxpoint/lpc.c</span><br><span>+++ b/src/southbridge/intel/lynxpoint/lpc.c</span><br><span>@@ -33,7 +33,6 @@</span><br><span> #include "nvs.h"</span><br><span> #include "pch.h"</span><br><span> #include <arch/acpigen.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cbmem.h></span><br><span> #include <drivers/intel/gma/i915.h></span><br><span> #include <southbridge/intel/common/acpi_pirq_gen.h></span><br><span> #include <southbridge/intel/common/rtc.h></span><br><span>diff --git a/src/southbridge/intel/lynxpoint/pch.h b/src/southbridge/intel/lynxpoint/pch.h</span><br><span>index 5850ab5..a02be81 100644</span><br><span>--- a/src/southbridge/intel/lynxpoint/pch.h</span><br><span>+++ b/src/southbridge/intel/lynxpoint/pch.h</span><br><span>@@ -174,7 +174,6 @@</span><br><span> </span><br><span> #if !defined(__PRE_RAM__) && !defined(__SMM__)</span><br><span> #include <device/device.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span> #include "chip.h"</span><br><span> void pch_enable(struct device *dev);</span><br><span> void pch_disable_devfn(struct device *dev);</span><br><span>diff --git a/src/southbridge/nvidia/mcp55/lpc.c b/src/southbridge/nvidia/mcp55/lpc.c</span><br><span>index b6bb1f8..3ac6464 100644</span><br><span>--- a/src/southbridge/nvidia/mcp55/lpc.c</span><br><span>+++ b/src/southbridge/nvidia/mcp55/lpc.c</span><br><span>@@ -33,7 +33,6 @@</span><br><span> #include <arch/acpi.h></span><br><span> #include <stdlib.h></span><br><span> #if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)</span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span> #include <arch/acpigen.h></span><br><span> #endif</span><br><span> #include <cpu/amd/powernow.h></span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29582">change 29582</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29582"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I252a1cd77bf647477edb7dddadb7e527de872439 </div>
<div style="display:none"> Gerrit-Change-Number: 29582 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>