<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29570">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/braswell: add vmx support via CPU_INTEL_COMMON<br><br>Braswell allready supported vmx, but offered no mechanism to unset it, nor<br>to set the lock bit required for Windows to recognize virtualization.<br>Enable this functionality by adding CPU_INTEL_COMMON config.<br><br>Test: build/boot Windows 10 on Braswell ChromeOS device, verify Windows shows<br>virtualization as enabled.<br><br>Change-Id: I0d39abaeb9eebcceb37dc791df6b06e521fe1992<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/soc/intel/braswell/Kconfig<br>M src/soc/intel/braswell/Makefile.inc<br>M src/soc/intel/braswell/cpu.c<br>3 files changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/29570/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/braswell/Kconfig b/src/soc/intel/braswell/Kconfig</span><br><span>index 2ba7992..50c2802 100644</span><br><span>--- a/src/soc/intel/braswell/Kconfig</span><br><span>+++ b/src/soc/intel/braswell/Kconfig</span><br><span>@@ -47,6 +47,7 @@</span><br><span> select GENERIC_GPIO_LIB</span><br><span> select INTEL_GMA_ACPI</span><br><span> select INTEL_GMA_SWSMISCI</span><br><span style="color: hsl(120, 100%, 40%);">+ select CPU_INTEL_COMMON</span><br><span> </span><br><span> config VBOOT</span><br><span> select VBOOT_STARTS_IN_ROMSTAGE</span><br><span>diff --git a/src/soc/intel/braswell/Makefile.inc b/src/soc/intel/braswell/Makefile.inc</span><br><span>index 38dcf5a..ac1bacd 100644</span><br><span>--- a/src/soc/intel/braswell/Makefile.inc</span><br><span>+++ b/src/soc/intel/braswell/Makefile.inc</span><br><span>@@ -7,6 +7,7 @@</span><br><span> subdirs-y += ../../../cpu/x86/tsc</span><br><span> subdirs-y += ../../../cpu/intel/microcode</span><br><span> subdirs-y += ../../../cpu/intel/turbo</span><br><span style="color: hsl(120, 100%, 40%);">+subdirs-y += ../../../cpu/intel/common</span><br><span> </span><br><span> romstage-y += gpio_support.c</span><br><span> romstage-y += iosf.c</span><br><span>diff --git a/src/soc/intel/braswell/cpu.c b/src/soc/intel/braswell/cpu.c</span><br><span>index 195dba4..9063c2a 100644</span><br><span>--- a/src/soc/intel/braswell/cpu.c</span><br><span>+++ b/src/soc/intel/braswell/cpu.c</span><br><span>@@ -16,6 +16,7 @@</span><br><span> </span><br><span> #include <console/console.h></span><br><span> #include <cpu/cpu.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <cpu/intel/common/common.h></span><br><span> #include <cpu/intel/microcode.h></span><br><span> #include <cpu/intel/turbo.h></span><br><span> #include <cpu/x86/cache.h></span><br><span>@@ -60,6 +61,9 @@</span><br><span> if (lapicid())</span><br><span> enable_turbo();</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Set virtualization based on Kconfig option */</span><br><span style="color: hsl(120, 100%, 40%);">+ set_vmx();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Set core MSRs */</span><br><span> reg_script_run(core_msr_script);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29570">change 29570</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29570"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I0d39abaeb9eebcceb37dc791df6b06e521fe1992 </div>
<div style="display:none"> Gerrit-Change-Number: 29570 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>