<p>Philipp Deppenwiese has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29563">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">security/tpm: Fix TCPA log feature<br><br>* Refactor TCPA log code<br>* Add TCPA log dump fucntion<br>* Make TCPA log available in bootblock<br>* Fix TCPA log formatting<br><br>Change-Id: Ic93133531b84318f48940d34bded48cbae739c44<br>Signed-off-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com><br>---<br>M src/arch/x86/car.ld<br>M src/commonlib/include/commonlib/tcpa_log_serialized.h<br>M src/include/memlayout.h<br>M src/security/tpm/tspi.h<br>M src/security/tpm/tspi/log.c<br>M src/security/vboot/Kconfig<br>M src/security/vboot/symbols.h<br>M src/security/vboot/vboot_crtm.c<br>M src/soc/cavium/cn81xx/include/soc/memlayout.ld<br>M util/cbmem/cbmem.c<br>10 files changed, 111 insertions(+), 42 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/29563/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/arch/x86/car.ld b/src/arch/x86/car.ld</span><br><span>index 33fb5c9..ea1c5f1 100644</span><br><span>--- a/src/arch/x86/car.ld</span><br><span>+++ b/src/arch/x86/car.ld</span><br><span>@@ -31,6 +31,12 @@</span><br><span> #if IS_ENABLED(CONFIG_VBOOT_SEPARATE_VERSTAGE)</span><br><span> VBOOT2_WORK(., 16K)</span><br><span> #endif</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Vboot measured boot TCPA log measurements</span><br><span style="color: hsl(120, 100%, 40%);">+ * Needs to be transfered until CBMEM is available</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+#if IS_ENABLED(CONFIG_VBOOT_TCPA_LOG_RECOVERY)</span><br><span style="color: hsl(120, 100%, 40%);">+ VBOOT2_TPM_LOG(., 2K)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> /* Stack for CAR stages. Since it persists across all stages that</span><br><span> * use CAR it can be reused. The chipset/SoC is expected to provide</span><br><span> * the stack size. */</span><br><span>diff --git a/src/commonlib/include/commonlib/tcpa_log_serialized.h b/src/commonlib/include/commonlib/tcpa_log_serialized.h</span><br><span>index 1e9ffaa..f5ebfb1 100644</span><br><span>--- a/src/commonlib/include/commonlib/tcpa_log_serialized.h</span><br><span>+++ b/src/commonlib/include/commonlib/tcpa_log_serialized.h</span><br><span>@@ -18,11 +18,12 @@</span><br><span> </span><br><span> #include <stdint.h></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#define MAX_PREMEM_TCPA_LOG_ENTRIES 14</span><br><span> #define MAX_TCPA_LOG_ENTRIES 50</span><br><span style="color: hsl(0, 100%, 40%);">-#define TCPA_LOG_STRING_LENGTH 512</span><br><span style="color: hsl(120, 100%, 40%);">+#define TCPA_LOG_STRING_LENGTH 256</span><br><span> #define TCPA_FORMAT_HASH_LENGTH 128</span><br><span> #define TCPA_DIGEST_MAX_LENGTH 64</span><br><span style="color: hsl(0, 100%, 40%);">-#define TCPA_PCR_HASH_NAME 256</span><br><span style="color: hsl(120, 100%, 40%);">+#define TCPA_PCR_HASH_NAME 64</span><br><span> </span><br><span> struct tcpa_entry {</span><br><span> uint32_t pcr;</span><br><span>diff --git a/src/include/memlayout.h b/src/include/memlayout.h</span><br><span>index 5de2370..ba6644f 100644</span><br><span>--- a/src/include/memlayout.h</span><br><span>+++ b/src/include/memlayout.h</span><br><span>@@ -165,6 +165,10 @@</span><br><span> REGION(vboot2_work, addr, size, 16) \</span><br><span> _ = ASSERT(size >= 12K, "vboot2 work buffer must be at least 12K!");</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#define VBOOT2_TPM_LOG(addr, size) \</span><br><span style="color: hsl(120, 100%, 40%);">+ REGION(vboot2_tpm_log, addr, size, 2) \</span><br><span style="color: hsl(120, 100%, 40%);">+ _ = ASSERT(size >= 2K, "vboot2 tpm log buffer must be at least 2K!");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #if ENV_VERSTAGE</span><br><span> #define VERSTAGE(addr, sz) \</span><br><span> SYMBOL(verstage, addr) \</span><br><span>diff --git a/src/security/tpm/tspi.h b/src/security/tpm/tspi.h</span><br><span>index d69b976..99a7e1d 100644</span><br><span>--- a/src/security/tpm/tspi.h</span><br><span>+++ b/src/security/tpm/tspi.h</span><br><span>@@ -33,6 +33,11 @@</span><br><span> const size_t digest_length);</span><br><span> </span><br><span> /**</span><br><span style="color: hsl(120, 100%, 40%);">+ * Dump TCPA log entries on console</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+void tcpa_log_dump(void);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/**</span><br><span> * Ask vboot for a digest and extend a TPM PCR with it.</span><br><span> * @param pcr sets the pcr index</span><br><span> * @param digest sets the hash to extend into the tpm</span><br><span>diff --git a/src/security/tpm/tspi/log.c b/src/security/tpm/tspi/log.c</span><br><span>index 17f6f1f..33486a5 100644</span><br><span>--- a/src/security/tpm/tspi/log.c</span><br><span>+++ b/src/security/tpm/tspi/log.c</span><br><span>@@ -14,67 +14,92 @@</span><br><span> */</span><br><span> </span><br><span> #include <string.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cbmem.h></span><br><span> #include <console/console.h></span><br><span> #include <security/tpm/tspi.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <arch/early_variables.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <fmap.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <region_file.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <string.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <cbmem.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <security/vboot/symbols.h></span><br><span> </span><br><span> static struct tcpa_table *tcpa_log_init(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- MAYBE_STATIC struct tcpa_table *tclt = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct tcpa_table *tclt;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (!cbmem_possibly_online())</span><br><span style="color: hsl(0, 100%, 40%);">- return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!cbmem_possibly_online()) {</span><br><span style="color: hsl(120, 100%, 40%);">+ tclt = (struct tcpa_table*)_vboot2_tpm_log;</span><br><span style="color: hsl(120, 100%, 40%);">+ tclt->max_entries = MAX_PREMEM_TCPA_LOG_ENTRIES;</span><br><span style="color: hsl(120, 100%, 40%);">+ tclt->num_entries = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ tclt = cbmem_find(CBMEM_ID_TCPA_LOG);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!tclt) {</span><br><span style="color: hsl(120, 100%, 40%);">+ tclt = cbmem_add(CBMEM_ID_TCPA_LOG,</span><br><span style="color: hsl(120, 100%, 40%);">+ sizeof(struct tcpa_table) +</span><br><span style="color: hsl(120, 100%, 40%);">+ MAX_TCPA_LOG_ENTRIES *</span><br><span style="color: hsl(120, 100%, 40%);">+ sizeof(struct tcpa_entry));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (tclt != NULL)</span><br><span style="color: hsl(0, 100%, 40%);">- return tclt;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- tclt = (struct tcpa_table *) cbmem_entry_find(CBMEM_ID_TCPA_LOG);</span><br><span style="color: hsl(0, 100%, 40%);">- if (tclt)</span><br><span style="color: hsl(0, 100%, 40%);">- return tclt;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- tclt = cbmem_add(CBMEM_ID_TCPA_LOG,</span><br><span style="color: hsl(0, 100%, 40%);">- sizeof(struct tcpa_table) +</span><br><span style="color: hsl(0, 100%, 40%);">- MAX_TCPA_LOG_ENTRIES *</span><br><span style="color: hsl(0, 100%, 40%);">- sizeof(struct tcpa_entry));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (!tclt) {</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_ERR, "ERROR: Could not create TCPA log table\n");</span><br><span style="color: hsl(0, 100%, 40%);">- return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ tclt->max_entries = MAX_TCPA_LOG_ENTRIES;</span><br><span style="color: hsl(120, 100%, 40%);">+ tclt->num_entries = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- tclt->max_entries = MAX_TCPA_LOG_ENTRIES;</span><br><span style="color: hsl(0, 100%, 40%);">- tclt->num_entries = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_DEBUG, "TCPA log created at %p\n", tclt);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_DEBUG, "TPM: TCPA log created at %p\n", tclt);</span><br><span> return tclt;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+void tcpa_log_dump(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ int i, j;</span><br><span style="color: hsl(120, 100%, 40%);">+ char log_string[TCPA_LOG_STRING_LENGTH];</span><br><span style="color: hsl(120, 100%, 40%);">+ char hash[TCPA_FORMAT_HASH_LENGTH];</span><br><span style="color: hsl(120, 100%, 40%);">+ struct tcpa_table *tclt;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ tclt = tcpa_log_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!tclt)</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_INFO, "coreboot TCPA log:\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < tclt->num_entries; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct tcpa_entry *tce = &tclt->entries[i];</span><br><span style="color: hsl(120, 100%, 40%);">+ if (tce) {</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(log_string, 0, TCPA_LOG_STRING_LENGTH);</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(hash, 0, TCPA_LOG_STRING_LENGTH);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (j = 0; j < tce->digest_length; j++)</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf((char *)&(hash[j * 2]), tce->digest_length, "%02x", tce->digest[j]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(log_string, TCPA_LOG_STRING_LENGTH, " %u %s 00 [%s]\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ tce->pcr, hash, tce->name);</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_INFO, "%s", log_string);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> void tcpa_log_add_table_entry(const char *name, const uint32_t pcr,</span><br><span> const uint8_t *digest, const size_t digest_length)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- struct tcpa_table *tclt;</span><br><span style="color: hsl(0, 100%, 40%);">- struct tcpa_entry *tce;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- tclt = tcpa_log_init();</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+ struct tcpa_table *tclt = tcpa_log_init();</span><br><span> if (!tclt)</span><br><span> return;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (tclt->num_entries == tclt->max_entries) {</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_WARNING, "ERROR: TCPA log table is full\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ if (tclt->num_entries >= tclt->max_entries) {</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_WARNING, "TPM: TCPA log table is full\n");</span><br><span> return;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- tce = &tclt->entries[tclt->num_entries++];</span><br><span style="color: hsl(120, 100%, 40%);">+ struct tcpa_entry *tce = &tclt->entries[tclt->num_entries++];</span><br><span style="color: hsl(120, 100%, 40%);">+ if (tce) {</span><br><span style="color: hsl(120, 100%, 40%);">+ strncpy(tce->name, name, TCPA_PCR_HASH_NAME - 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ tce->pcr = pcr;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- strncpy(tce->name, name, TCPA_PCR_HASH_NAME - 1);</span><br><span style="color: hsl(0, 100%, 40%);">- tce->pcr = pcr;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (digest_length > TCPA_DIGEST_MAX_LENGTH) {</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_WARNING, "TPM: PCR digest too long for TCPA log entry\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (digest_length > TCPA_DIGEST_MAX_LENGTH) {</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_WARNING, "ERROR: PCR digest too long for TCPA log entry\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ memcpy(tce->digest, digest, digest_length);</span><br><span style="color: hsl(120, 100%, 40%);">+ tce->digest_length = digest_length;</span><br><span> return;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- memcpy(tce->digest, digest, digest_length);</span><br><span style="color: hsl(0, 100%, 40%);">- tce->digest_length = digest_length;</span><br><span> }</span><br><span>diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig</span><br><span>index e7cb43a..fd69114 100644</span><br><span>--- a/src/security/vboot/Kconfig</span><br><span>+++ b/src/security/vboot/Kconfig</span><br><span>@@ -241,6 +241,13 @@</span><br><span> Add a space delimited list of filenames that should only be in the</span><br><span> RO section.</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+config VBOOT_TCPA_LOG_RECOVERY</span><br><span style="color: hsl(120, 100%, 40%);">+ bool</span><br><span style="color: hsl(120, 100%, 40%);">+ default y</span><br><span style="color: hsl(120, 100%, 40%);">+ help</span><br><span style="color: hsl(120, 100%, 40%);">+ Enables TCPA log measurements recovery from bootblock to</span><br><span style="color: hsl(120, 100%, 40%);">+ romstage.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> menu "GBB configuration"</span><br><span> </span><br><span> config GBB_HWID</span><br><span>diff --git a/src/security/vboot/symbols.h b/src/security/vboot/symbols.h</span><br><span>index ddf9d95..92cbeea 100644</span><br><span>--- a/src/security/vboot/symbols.h</span><br><span>+++ b/src/security/vboot/symbols.h</span><br><span>@@ -20,4 +20,6 @@</span><br><span> extern u8 _evboot2_work[];</span><br><span> #define _vboot2_work_size (_evboot2_work - _vboot2_work)</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+extern u8 _vboot2_tpm_log[];</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #endif /* __VBOOT_SYMBOLS_H__ */</span><br><span>diff --git a/src/security/vboot/vboot_crtm.c b/src/security/vboot/vboot_crtm.c</span><br><span>index 5b76aa8..b71fce8 100644</span><br><span>--- a/src/security/vboot/vboot_crtm.c</span><br><span>+++ b/src/security/vboot/vboot_crtm.c</span><br><span>@@ -18,7 +18,9 @@</span><br><span> #include <fmap.h></span><br><span> #include <security/tpm/tspi.h></span><br><span> #include <security/vboot/vboot_crtm.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <security/vboot/symbols.h></span><br><span> #include <program_loading.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <cbmem.h></span><br><span> </span><br><span> uint32_t vboot_init_crtm(void)</span><br><span> {</span><br><span>@@ -132,6 +134,8 @@</span><br><span> case PROG_PAYLOAD:</span><br><span> tpm_measure_region(prog_rdev(prog), TPM_PAYLOAD_PCR,</span><br><span> prog->name);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Last measurement, afterwards dump completed log */</span><br><span style="color: hsl(120, 100%, 40%);">+ tcpa_log_dump();</span><br><span> break;</span><br><span> case PROG_REFCODE:</span><br><span> tpm_measure_region(prog_rdev(prog), TPM_INTEL_FSP_PCR,</span><br><span>@@ -152,3 +156,15 @@</span><br><span> break;</span><br><span> }</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void recover_tcpa_log(int is_recovery)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct tcpa_table *tclt = (struct tcpa_table*)_vboot2_tpm_log;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (tclt) {</span><br><span style="color: hsl(120, 100%, 40%);">+ int i;</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < tclt->num_entries; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ tcpa_log_add_table_entry(tclt->entries[i].name, tclt->entries[i].pcr, tclt->entries[i].digest, tclt->entries[i].digest_length);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+ROMSTAGE_CBMEM_INIT_HOOK(recover_tcpa_log);</span><br><span>diff --git a/src/soc/cavium/cn81xx/include/soc/memlayout.ld b/src/soc/cavium/cn81xx/include/soc/memlayout.ld</span><br><span>index e3bf61f..0562ed6 100644</span><br><span>--- a/src/soc/cavium/cn81xx/include/soc/memlayout.ld</span><br><span>+++ b/src/soc/cavium/cn81xx/include/soc/memlayout.ld</span><br><span>@@ -35,7 +35,10 @@</span><br><span> PRERAM_CBMEM_CONSOLE(BOOTROM_OFFSET + 0x8000, 8K)</span><br><span> BOOTBLOCK(BOOTROM_OFFSET + 0x20000, 64K)</span><br><span> VBOOT2_WORK(BOOTROM_OFFSET + 0x30000, 12K)</span><br><span style="color: hsl(0, 100%, 40%);">- VERSTAGE(BOOTROM_OFFSET + 0x33000, 52K)</span><br><span style="color: hsl(120, 100%, 40%);">+#if IS_ENABLED(CONFIG_VBOOT_TCPA_LOG_RECOVERY)</span><br><span style="color: hsl(120, 100%, 40%);">+ VBOOT2_TPM_LOG(BOOTROM_OFFSET + 0x33000, 2K)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+ VERSTAGE(BOOTROM_OFFSET + 0x34000, 50K)</span><br><span> ROMSTAGE(BOOTROM_OFFSET + 0x40000, 256K)</span><br><span> </span><br><span> SRAM_END(BOOTROM_OFFSET + 0x80000)</span><br><span>diff --git a/util/cbmem/cbmem.c b/util/cbmem/cbmem.c</span><br><span>index 8ab80b0..79852da 100644</span><br><span>--- a/util/cbmem/cbmem.c</span><br><span>+++ b/util/cbmem/cbmem.c</span><br><span>@@ -720,7 +720,7 @@</span><br><span> for (j = 0; j < tce->digest_length; j++)</span><br><span> sprintf((char *)&(hash[j * 2]), "%02x", tce->digest[j]);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(log_string, TCPA_LOG_STRING_LENGTH, "%u %s 00 [%s]\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(log_string, TCPA_LOG_STRING_LENGTH, " %u %s 00 [%s]\n",</span><br><span> tce->pcr, hash, tce->name);</span><br><span> printf("%s", log_string);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29563">change 29563</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29563"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic93133531b84318f48940d34bded48cbae739c44 </div>
<div style="display:none"> Gerrit-Change-Number: 29563 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>