<p><a href="https://review.coreboot.org/29429">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29429/2/src/mainboard/google/poppy/variants/nocturne/gpio.c">File src/mainboard/google/poppy/variants/nocturne/gpio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29429/2/src/mainboard/google/poppy/variants/nocturne/gpio.c@138">Patch Set #2, Line 138:</a> <code style="font-family:monospace,monospace">PLTRST</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I had read in another CL yesterday (that I'm having trouble finding again to include here, sorry) th […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I was wondering the same thing when I added sarien/arcada.  It does make sense that you would want the status to get reset on PLRST assertion for regular interrupt pins.</p><p style="white-space: pre-wrap; word-wrap: break-word;">But probably not if the pin is expected to be able to wake? (like Furquan's comment above)   Not sure how to reconcile the behavior in that case to ensure it doesn't have issues.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29429">change 29429</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29429"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I008532fce963c51a435378001440ac72b5ebfffc </div>
<div style="display:none"> Gerrit-Change-Number: 29429 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Caveh Jalali <caveh@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 06 Nov 2018 21:51:27 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>