<p><a href="https://review.coreboot.org/29508">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29508/3/src/soc/intel/icelake/acpi/pci_irqs.asl">File src/soc/intel/icelake/acpi/pci_irqs.asl:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29508/3/src/soc/intel/icelake/acpi/pci_irqs.asl@137">Patch Set #3, Line 137:</a> <code style="font-family:monospace,monospace">Return (^PICN)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">these are supposed to be PIC interrupts, which are relative to the PRT A-H settings (at least on older hardware). Is this not configurable anymore or what is the reason behind this change, which hardcodes them?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29508">change 29508</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29508"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Idec00c3b8a97cb5aa7b4000840aba914aea478c9 </div>
<div style="display:none"> Gerrit-Change-Number: 29508 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 06 Nov 2018 13:59:08 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>