<p>Richard Spiegel <strong>uploaded patch set #2</strong> to this change.</p><p><a href="https://review.coreboot.org/29520">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd: Convert from AMD units to coreboot units<br><br>There are several files under soc/amd that use units defined by file<br>porting.h. These units use upper case, and are not recognized by checkpatch,<br>thus causing problems when defining a pointer (request to use space before<br>and after the star symbol). These are the definitions from porting.h showing<br>the units that this patch will change and their coreboot definitions (not all<br>are actually used):<br>  typedef uintptr_t      UINTN;<br>  typedef int64_t        INT64;<br>  typedef uint64_t       UINT64;<br>  typedef int32_t        INT32;<br>  typedef uint32_t       UINT32;<br>  typedef int16_t        INT16;<br>  typedef uint16_t       UINT16;<br>  typedef int8_t         INT8;<br>  typedef uint8_t        UINT8;<br>  typedef char           CHAR8;<br>  typedef unsigned short CHAR16;<br>  typedef unsigned char  BOOLEAN;<br>  typedef void VOID;<br><br>BUG=b:118775313<br>TEST=Build and boot grunt.<br><br>Change-Id: Ic1bd64d6224a030a65d23decabf0e602cee02871<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h<br>M src/soc/amd/common/block/include/amdblocks/agesawrapper.h<br>M src/soc/amd/common/block/pi/agesawrapper.c<br>M src/soc/amd/common/block/pi/def_callouts.c<br>M src/soc/amd/common/block/pi/heapmanager.c<br>M src/soc/amd/stoneyridge/BiosCallOuts.c<br>M src/soc/amd/stoneyridge/northbridge.c<br>7 files changed, 119 insertions(+), 102 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/29520/2</pre><p>To view, visit <a href="https://review.coreboot.org/29520">change 29520</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29520"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>
<div style="display:none"> Gerrit-Change-Id: Ic1bd64d6224a030a65d23decabf0e602cee02871 </div>
<div style="display:none"> Gerrit-Change-Number: 29520 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>