<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/29430">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Duncan Laurie: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/sarien: Enable WWAN detection<br><br>WWAN start-up control requires RESET# assert after FULL_CARD_POWER_OFF#<br>set to high more than 10 ms, so force RESET#(GPP_D21) to low at<br>bootblock stage to match the sequence.<br><br>BUG=N/A<br>TEST=Boot up Sarien/Arcada board, check WWAN get detected as USB<br>devices through lsusb.<br><br>Change-Id: I36eb841a2e8f2b36771d20577314a7451fbee133<br>Signed-off-by: Lijian Zhao <lijian.zhao@intel.com><br>Reviewed-on: https://review.coreboot.org/29430<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Duncan Laurie <dlaurie@chromium.org><br>---<br>M src/mainboard/google/sarien/variants/arcada/gpio.c<br>M src/mainboard/google/sarien/variants/sarien/gpio.c<br>2 files changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/sarien/variants/arcada/gpio.c b/src/mainboard/google/sarien/variants/arcada/gpio.c</span><br><span>index 86da3ec..eb4ee76 100644</span><br><span>--- a/src/mainboard/google/sarien/variants/arcada/gpio.c</span><br><span>+++ b/src/mainboard/google/sarien/variants/arcada/gpio.c</span><br><span>@@ -234,6 +234,8 @@</span><br><span> /* I2C4_SCL */              PAD_CFG_NF(GPP_H9, NONE, DEEP, NF1), /* I2C_SCL_H1 */</span><br><span> /* DMIC_DATA1 */       PAD_CFG_GPI_APIC(GPP_D18, NONE, DEEP,</span><br><span>                                 EDGE_SINGLE, INVERT), /* H1_PCH_INT_ODL */</span><br><span style="color: hsl(120, 100%, 40%);">+/* RESET# need to stay low before FULL_CARD_POWER_OFF assert */</span><br><span style="color: hsl(120, 100%, 40%);">+/* SPI1_IO2 */            PAD_CFG_GPO(GPP_D21, 0, DEEP), /* WWAN_BB_RST# */</span><br><span> /* CPU_GP0 */              PAD_CFG_GPI(GPP_E3, NONE, DEEP), /* MEM_INTERLEAVED */</span><br><span> /* SATALED# */                PAD_CFG_GPI(GPP_E8, NONE, DEEP), /* RECOVERY# */</span><br><span> /* DDPD_HPD2 */             PAD_CFG_GPI(GPP_E15, NONE, DEEP), /* PCH_WP */</span><br><span>diff --git a/src/mainboard/google/sarien/variants/sarien/gpio.c b/src/mainboard/google/sarien/variants/sarien/gpio.c</span><br><span>index 3656afb..690af1f 100644</span><br><span>--- a/src/mainboard/google/sarien/variants/sarien/gpio.c</span><br><span>+++ b/src/mainboard/google/sarien/variants/sarien/gpio.c</span><br><span>@@ -234,6 +234,8 @@</span><br><span> /* I2C4_SCL */             PAD_CFG_NF(GPP_H9, NONE, DEEP, NF1), /* I2C_SCL_H1 */</span><br><span> /* DMIC_DATA1 */       PAD_CFG_GPI_APIC(GPP_D18, NONE, DEEP,</span><br><span>                                 EDGE_SINGLE, INVERT), /* H1_PCH_INT_ODL */</span><br><span style="color: hsl(120, 100%, 40%);">+/* RESET# need to stay low before FULL_CARD_POWER_OFF assert */</span><br><span style="color: hsl(120, 100%, 40%);">+/* SPI1_IO2 */            PAD_CFG_GPO(GPP_D21, 0, DEEP), /* WWAN_BB_RST# */</span><br><span> /* CPU_GP0 */              PAD_CFG_GPI(GPP_E3, NONE, DEEP), /* MEM_INTERLEAVED */</span><br><span> /* SATALED# */                PAD_CFG_GPI(GPP_E8, NONE, DEEP), /* RECOVERY */</span><br><span> /* DDPD_HPD2 */              PAD_CFG_GPI(GPP_E15, NONE, DEEP), /* H1_FLASH_WP */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29430">change 29430</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29430"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I36eb841a2e8f2b36771d20577314a7451fbee133 </div>
<div style="display:none"> Gerrit-Change-Number: 29430 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>