<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/29274">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Bora Guvendik: Looks good to me, approved
  Pratikkumar V Prajapati: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/cannonlake: Enable ISH from device<br><br>PCH ISH enabled/disabled in FSP memory init UPD, it will be match the<br>setting in ISH device on/off in devicetree.cb.<br><br>BUG=N/A<br>TEST=Build and pass on whiskey lake rvp platform.<br><br>Change-Id: I6889634bf65e7ce5cc3e3393c57c86d622f1ac68<br>Signed-off-by: Lijian Zhao <lijian.zhao@intel.com><br>Reviewed-on: https://review.coreboot.org/29274<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com><br>Reviewed-by: Bora Guvendik <bora.guvendik@intel.com><br>---<br>M src/soc/intel/cannonlake/romstage/fsp_params.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/cannonlake/romstage/fsp_params.c b/src/soc/intel/cannonlake/romstage/fsp_params.c</span><br><span>index 3cfa281..8506214 100644</span><br><span>--- a/src/soc/intel/cannonlake/romstage/fsp_params.c</span><br><span>+++ b/src/soc/intel/cannonlake/romstage/fsp_params.c</span><br><span>@@ -25,6 +25,7 @@</span><br><span> {</span><br><span>       unsigned int i;</span><br><span>      uint32_t mask = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+    const struct device *dev = dev_find_slot(0, PCH_DEVFN_ISH);</span><br><span> </span><br><span>      /* Set IGD stolen size to 64MB. */</span><br><span>   m_cfg->IgdDvmt50PreAlloc = 2;</span><br><span>@@ -55,6 +56,11 @@</span><br><span> #if IS_ENABLED(CONFIG_SOC_INTEL_COFFEELAKE)</span><br><span>         m_cfg->SkipMpInit = !chip_get_fsp_mp_init();</span><br><span> #endif</span><br><span style="color: hsl(120, 100%, 40%);">+     /* If ISH is enabled, enable ISH elements */</span><br><span style="color: hsl(120, 100%, 40%);">+  if (!dev)</span><br><span style="color: hsl(120, 100%, 40%);">+             m_cfg->PchIshEnable = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+   else</span><br><span style="color: hsl(120, 100%, 40%);">+          m_cfg->PchIshEnable = dev->enabled;</span><br><span> }</span><br><span> </span><br><span> void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29274">change 29274</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29274"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I6889634bf65e7ce5cc3e3393c57c86d622f1ac68 </div>
<div style="display:none"> Gerrit-Change-Number: 29274 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Hannah Williams <hannah.williams@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Li1 Feng <li1.feng@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Shine Liu <shine.liu@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>