<p>Philipp Deppenwiese <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/29445">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Philipp Deppenwiese: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Linuxboot: check go version<br><br>Check if the installed Golang version is >= 1.9.<br><br>Change-Id: I9fd74fa8dc5e906e8b54ff5afaf69609fe957960<br>Signed-off-by: Marcello Sylvester Bauer <info@marcellobauer.com><br>Reviewed-on: https://review.coreboot.org/29445<br>Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com><br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>---<br>M payloads/external/LinuxBoot/targets/u-root.mk<br>1 file changed, 12 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/payloads/external/LinuxBoot/targets/u-root.mk b/payloads/external/LinuxBoot/targets/u-root.mk</span><br><span>index 001f7c4..27f184e 100644</span><br><span>--- a/payloads/external/LinuxBoot/targets/u-root.mk</span><br><span>+++ b/payloads/external/LinuxBoot/targets/u-root.mk</span><br><span>@@ -14,7 +14,10 @@</span><br><span> </span><br><span> uroot_git_repo=https://github.com/u-root/u-root.git</span><br><span> uroot_dir=$(project_dir)/go/src/github.com/u-root/u-root</span><br><span style="color: hsl(0, 100%, 40%);">-go_check=$(shell command -v go 1>/dev/null 2>&1 && echo go)</span><br><span style="color: hsl(120, 100%, 40%);">+go_version=$(shell go version | sed -nr 's/.*go([0-9]+\.[0-9]+.?[0-9]?).*/\1/p' )</span><br><span style="color: hsl(120, 100%, 40%);">+go_version_major=$(shell echo $(go_version) |  sed -nr 's/^([0-9]+)\.([0-9]+)\.?([0-9]*)$$/\1/p')</span><br><span style="color: hsl(120, 100%, 40%);">+go_version_minor=$(shell echo $(go_version) |  sed -nr 's/^([0-9]+)\.([0-9]+)\.?([0-9]*)$$/\2/p')</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> project_dir=$(shell pwd)/linuxboot</span><br><span> project_name=u-root</span><br><span> go_path_dir=$(shell pwd)/linuxboot/go</span><br><span>@@ -22,10 +25,17 @@</span><br><span> all: build</span><br><span> </span><br><span> check:</span><br><span style="color: hsl(0, 100%, 40%);">-ifneq ($(go_check),go)</span><br><span style="color: hsl(120, 100%, 40%);">+ifeq ("$(go_version)","")</span><br><span>       printf "\n<<Please install Golang >= 1.9 for u-root mode>>\n\n"</span><br><span>     exit 1</span><br><span> endif</span><br><span style="color: hsl(120, 100%, 40%);">+ifeq ($(shell if [ $(go_version_major) -eq 1 ]; then echo y; fi),y)</span><br><span style="color: hsl(120, 100%, 40%);">+ifeq ($(shell if [ $(go_version_minor) -lt 9 ]; then echo y; fi),y)</span><br><span style="color: hsl(120, 100%, 40%);">+     printf "\n  Golang version $(go_version) currently installed.\n\</span><br><span style="color: hsl(120, 100%, 40%);">+ <<Please install Golang >= 1.9 for u-root mode>>\n\n"</span><br><span style="color: hsl(120, 100%, 40%);">+     exit 1</span><br><span style="color: hsl(120, 100%, 40%);">+endif</span><br><span style="color: hsl(120, 100%, 40%);">+endif</span><br><span>         mkdir -p $(project_dir)/go/src/github.com/u-root</span><br><span> </span><br><span> $(uroot_dir)/.git:</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29445">change 29445</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29445"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I9fd74fa8dc5e906e8b54ff5afaf69609fe957960 </div>
<div style="display:none"> Gerrit-Change-Number: 29445 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Marcello Sylvester Bauer <info@marcellobauer.com> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>