<p>Nico Huber <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/29446">View Change</a></p><div style="white-space:pre-wrap">Approvals:
build bot (Jenkins): Verified
Nico Huber: Looks good to me, approved
Arthur Heymans: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/mb/asus/p5qc: Fix some mistakes<br><br>There are some small mistakes in these recently-added mainboards:<br><br> - board_info.txt: Lists board socket incorrectly.<br> - cmos.default: Loglevel was decreased some time ago.<br> - devicetree.cb: Spelling mistake.<br> - Kconfig: Mainboard name does not have a hyphen.<br><br>Change-Id: I08d9b06e79683acd3994b84647bce401ed6741e2<br>Signed-off-by: Angel Pons <th3fanbus@gmail.com><br>Reviewed-on: https://review.coreboot.org/29446<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Arthur Heymans <arthur@aheymans.xyz><br>Reviewed-by: Nico Huber <nico.h@gmx.de><br>---<br>M src/mainboard/asus/p5qc/Kconfig<br>M src/mainboard/asus/p5qc/board_info.txt<br>M src/mainboard/asus/p5qc/cmos.default<br>M src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb<br>M src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb<br>5 files changed, 13 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/asus/p5qc/Kconfig b/src/mainboard/asus/p5qc/Kconfig</span><br><span>index 2bcee16..e8d596f 100644</span><br><span>--- a/src/mainboard/asus/p5qc/Kconfig</span><br><span>+++ b/src/mainboard/asus/p5qc/Kconfig</span><br><span>@@ -42,7 +42,7 @@</span><br><span> config MAINBOARD_PART_NUMBER</span><br><span> string</span><br><span> default "P5QC" if BOARD_ASUS_P5QC</span><br><span style="color: hsl(0, 100%, 40%);">- default "P5Q-PRO" if BOARD_ASUS_P5Q_PRO</span><br><span style="color: hsl(120, 100%, 40%);">+ default "P5Q PRO" if BOARD_ASUS_P5Q_PRO</span><br><span> </span><br><span> config DEVICETREE</span><br><span> string</span><br><span>diff --git a/src/mainboard/asus/p5qc/board_info.txt b/src/mainboard/asus/p5qc/board_info.txt</span><br><span>index 111f2e4..42d4812 100644</span><br><span>--- a/src/mainboard/asus/p5qc/board_info.txt</span><br><span>+++ b/src/mainboard/asus/p5qc/board_info.txt</span><br><span>@@ -1,6 +1,6 @@</span><br><span> Category: desktop</span><br><span> Board URL: https://www.asus.com/Motherboards/P5QC/</span><br><span style="color: hsl(0, 100%, 40%);">-ROM package: SOP-8</span><br><span style="color: hsl(120, 100%, 40%);">+ROM package: DIP-8</span><br><span> ROM protocol: SPI</span><br><span> ROM socketed: y</span><br><span> Flashrom support: y</span><br><span>diff --git a/src/mainboard/asus/p5qc/cmos.default b/src/mainboard/asus/p5qc/cmos.default</span><br><span>index ccdb7c8..ad822d5 100644</span><br><span>--- a/src/mainboard/asus/p5qc/cmos.default</span><br><span>+++ b/src/mainboard/asus/p5qc/cmos.default</span><br><span>@@ -1,5 +1,5 @@</span><br><span> boot_option=Fallback</span><br><span style="color: hsl(0, 100%, 40%);">-debug_level=Spew</span><br><span style="color: hsl(120, 100%, 40%);">+debug_level=Debug</span><br><span> power_on_after_fail=Disable</span><br><span> nmi=Enable</span><br><span> sata_mode=AHCI</span><br><span>diff --git a/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb b/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb</span><br><span>index f7088fc..8753d4c 100644</span><br><span>--- a/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb</span><br><span>+++ b/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb</span><br><span>@@ -85,15 +85,15 @@</span><br><span> irq 0x72 = 12</span><br><span> end</span><br><span> device pnp 2e.106 off end # SPI1</span><br><span style="color: hsl(0, 100%, 40%);">- device pnp 2e.107 off end # GIPO6</span><br><span style="color: hsl(0, 100%, 40%);">- device pnp 2e.207 off end # GIPO7</span><br><span style="color: hsl(0, 100%, 40%);">- device pnp 2e.307 on # GIPO8</span><br><span style="color: hsl(120, 100%, 40%);">+ device pnp 2e.107 off end # GPIO6</span><br><span style="color: hsl(120, 100%, 40%);">+ device pnp 2e.207 off end # GPIO7</span><br><span style="color: hsl(120, 100%, 40%);">+ device pnp 2e.307 on # GPIO8</span><br><span> irq 0xe4 = 0xfb</span><br><span> irq 0xe5 = 0x82</span><br><span> end</span><br><span style="color: hsl(0, 100%, 40%);">- device pnp 2e.407 off end # GIPO9</span><br><span style="color: hsl(120, 100%, 40%);">+ device pnp 2e.407 off end # GPIO9</span><br><span> device pnp 2e.8 off end # WDT</span><br><span style="color: hsl(0, 100%, 40%);">- device pnp 2e.108 off end # GPIO 1</span><br><span style="color: hsl(120, 100%, 40%);">+ device pnp 2e.108 off end # GPIO1</span><br><span> device pnp 2e.9 off end # GPIO2</span><br><span> device pnp 2e.109 on end # GPIO3</span><br><span> device pnp 2e.209 on # GPIO4</span><br><span>diff --git a/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb b/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb</span><br><span>index 52bbb40..6fac063 100644</span><br><span>--- a/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb</span><br><span>+++ b/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb</span><br><span>@@ -82,15 +82,15 @@</span><br><span> irq 0x72 = 12</span><br><span> end</span><br><span> device pnp 2e.106 off end # SPI1</span><br><span style="color: hsl(0, 100%, 40%);">- device pnp 2e.107 off end # GIPO6</span><br><span style="color: hsl(0, 100%, 40%);">- device pnp 2e.207 off end # GIPO7</span><br><span style="color: hsl(0, 100%, 40%);">- device pnp 2e.307 on # GIPO8</span><br><span style="color: hsl(120, 100%, 40%);">+ device pnp 2e.107 off end # GPIO6</span><br><span style="color: hsl(120, 100%, 40%);">+ device pnp 2e.207 off end # GPIO7</span><br><span style="color: hsl(120, 100%, 40%);">+ device pnp 2e.307 on # GPIO8</span><br><span> irq 0xe4 = 0xfb</span><br><span> irq 0xe5 = 0x02</span><br><span> end</span><br><span style="color: hsl(0, 100%, 40%);">- device pnp 2e.407 off end # GIPO9</span><br><span style="color: hsl(120, 100%, 40%);">+ device pnp 2e.407 off end # GPIO9</span><br><span> device pnp 2e.8 off end # WDT</span><br><span style="color: hsl(0, 100%, 40%);">- device pnp 2e.108 off end # GPIO 1</span><br><span style="color: hsl(120, 100%, 40%);">+ device pnp 2e.108 off end # GPIO1</span><br><span> device pnp 2e.9 off end # GPIO2</span><br><span> device pnp 2e.109 on end # GPIO3</span><br><span> device pnp 2e.209 on # GPIO4</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29446">change 29446</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29446"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I08d9b06e79683acd3994b84647bce401ed6741e2 </div>
<div style="display:none"> Gerrit-Change-Number: 29446 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>