<p>Aamir Bohra would like Subrata Banik to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/29435">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/common: Include Icelake Device Ids<br><br>Add Icelake specific CPU, System Agent, PCH, IGD device IDs.<br><br>Change-Id: I2c398957ffbc9bb0e5b363740d99433075ca66a3<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>Signed-off-by: Aamir Bohra <aamir.bohra@intel.com><br>---<br>M src/include/device/pci_ids.h<br>M src/soc/intel/common/block/cpu/mp_init.c<br>M src/soc/intel/common/block/cse/cse.c<br>M src/soc/intel/common/block/dsp/dsp.c<br>M src/soc/intel/common/block/graphics/graphics.c<br>M src/soc/intel/common/block/hda/hda.c<br>M src/soc/intel/common/block/i2c/i2c.c<br>M src/soc/intel/common/block/include/intelblocks/mp_init.h<br>M src/soc/intel/common/block/lpc/lpc.c<br>M src/soc/intel/common/block/p2sb/p2sb.c<br>M src/soc/intel/common/block/pcie/pcie.c<br>M src/soc/intel/common/block/pmc/pmc.c<br>M src/soc/intel/common/block/sata/sata.c<br>M src/soc/intel/common/block/scs/sd.c<br>M src/soc/intel/common/block/smbus/smbus.c<br>M src/soc/intel/common/block/spi/spi.c<br>M src/soc/intel/common/block/sram/sram.c<br>M src/soc/intel/common/block/systemagent/systemagent.c<br>M src/soc/intel/common/block/uart/uart.c<br>M src/soc/intel/common/block/xdci/xdci.c<br>M src/soc/intel/common/block/xhci/xhci.c<br>M src/soc/intel/icelake/bootblock/report_platform.c<br>22 files changed, 165 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/29435/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h</span><br><span>index f6bcd7c..7908413 100644</span><br><span>--- a/src/include/device/pci_ids.h</span><br><span>+++ b/src/include/device/pci_ids.h</span><br><span>@@ -2692,6 +2692,13 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_CNL_Y_PREMIUM_LPC    0x9d83</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_LPC_Q370    0xa306</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_LPC_QM370   0xa30c</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_U_SUPER_U_LPC   0x3480</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_U_SUPER_U_LPC_REV0      0x3481</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_U_PREMIUM_LPC   0x3482</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_BASE_Y_LPC              0x3483</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_BASE_U_LPC              0x3484</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_Y_PREMIUM_LPC   0x3487</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_SUPER_Y_LPC     0x3486</span><br><span> </span><br><span> /* Intel PCIE device ids  */</span><br><span> #define PCI_DEVICE_ID_INTEL_SPT_LP_PCIE_RP1               0x9d10</span><br><span>@@ -2769,6 +2776,22 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_CNL_LP_PCIE_RP14         0x9db5</span><br><span> #define PCI_DEVICE_ID_INTEL_CNL_LP_PCIE_RP15          0x9db6</span><br><span> #define PCI_DEVICE_ID_INTEL_CNL_LP_PCIE_RP16          0x9db7</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP1             0x34b8</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP2             0x34b9</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP3             0x34bA</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP4             0x34bB</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP5             0x34bC</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP6             0x34bD</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP7             0x34bE</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP8             0x34bF</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP9             0x34b0</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP10            0x34b1</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP11            0x34b2</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP12            0x34b3</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP13            0x34b4</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP14            0x34b5</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP15            0x34b6</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP16            0x34b7</span><br><span> </span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_PCIE_RP1                0xa338</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_PCIE_RP2            0xa339</span><br><span>@@ -2806,6 +2829,7 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_CNL_COMPAT_SATA   0x282a</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_SATA                0xa352</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_LP_SATA               0x9dd3</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_U_SATA          0x34d3</span><br><span> </span><br><span> /* Intel PMC device Ids */</span><br><span> #define PCI_DEVICE_ID_INTEL_SPT_LP_PMC              0x9d21</span><br><span>@@ -2815,6 +2839,7 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_GLK_PMC           0x3194</span><br><span> #define PCI_DEVICE_ID_INTEL_CNL_PMC           0x9da1</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_PMC         0xa321</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_PMC             0x34a1</span><br><span> </span><br><span> /* Intel I2C device Ids */</span><br><span> #define PCI_DEVICE_ID_INTEL_SPT_I2C0                0x9d60</span><br><span>@@ -2853,6 +2878,12 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_I2C1               0xa369</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_I2C2                0xa36a</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_I2C3                0xa36b</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_I2C0            0x34e8</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_I2C1            0x34e9</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_I2C2            0x34ea</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_I2C3            0x34eb</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_I2C4            0x34c5</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_I2C5            0x34c6</span><br><span> </span><br><span> /* Intel UART device Ids */</span><br><span> #define PCI_DEVICE_ID_INTEL_SPT_UART0              0x9d27</span><br><span>@@ -2878,6 +2909,9 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_UART0               0xa328</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_UART1               0xa329</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_UART2               0xa347</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_UART0           0x34a8</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_UART1           0x34a9</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_UART2           0x34c7</span><br><span> </span><br><span> /* Intel SPI device Ids */</span><br><span> #define PCI_DEVICE_ID_INTEL_SPT_SPI1                0x9d24</span><br><span>@@ -2894,6 +2928,10 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_CNL_SPI1         0x9dab</span><br><span> #define PCI_DEVICE_ID_INTEL_CNL_SPI2          0x9dfb</span><br><span> #define PCI_DEVICE_ID_INTEL_CNL_HWSEQ_SPI     0x9da4</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_SPI0            0x34aa</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_SPI1            0x34ab</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_SPI2            0x9dfb</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_HWSEQ_SPI       0x34a4</span><br><span> </span><br><span> /* Intel IGD device Ids */</span><br><span> #define PCI_DEVICE_ID_INTEL_SKL_GT1_SULTM           0x1906</span><br><span>@@ -2925,6 +2963,22 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_CFL_GT2_ULT                      0x3EA5</span><br><span> #define PCI_DEVICE_ID_INTEL_CFL_H_GT2                 0x3e9b</span><br><span> #define PCI_DEVICE_ID_INTEL_CFL_S_GT2                 0x3e92</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_GT0_ULT         0x8A70</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_GT0_5_ULT               0x8A71</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_GT1_ULT         0x8A40</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_0               0x8A50</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_1               0x8A5D</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_GT2_ULT_1               0x8A5B</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_2               0x8A5C</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_GT2_ULT_2               0x8A5A</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_3               0x8A51</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_GT2_ULT_3               0x8A52</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_4               0x8A53</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_GT2_ULT_4               0x8A54</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_5               0x8A55</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_GT2_ULT_5               0x8A56</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_6               0x8A57</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_GT3_ULT         0x8A62</span><br><span> </span><br><span> /* Intel Northbridge Ids */</span><br><span> #define PCI_DEVICE_ID_INTEL_APL_NB 0x5af0</span><br><span>@@ -2947,6 +3001,10 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_CFL_ID_U 0x3ED0</span><br><span> #define PCI_DEVICE_ID_INTEL_CFL_ID_H  0x3ec4</span><br><span> #define PCI_DEVICE_ID_INTEL_CFL_ID_S  0x3ec2</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_ID_U    0x8A12</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_ID_U_2_2        0x8A02</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_ID_Y    0x8A10</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_ID_Y_2  0x8A00</span><br><span> </span><br><span> /* Intel SMBUS device Ids */</span><br><span> #define PCI_DEVICE_ID_INTEL_SPT_LP_SMBUS          0x9d23</span><br><span>@@ -2954,6 +3012,7 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_KBP_H_SMBUS                       0xa1a3</span><br><span> #define PCI_DEVICE_ID_INTEL_CNL_SMBUS                 0x9da3</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_SMBUS                       0xa323</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_SMBUS                0x34a3</span><br><span> </span><br><span> /* Intel XHCI device Ids */</span><br><span> #define PCI_DEVICE_ID_INTEL_APL_XHCI               0x5aa8</span><br><span>@@ -2963,18 +3022,21 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_KBP_H_XHCI              0xa2af</span><br><span> #define PCI_DEVICE_ID_INTEL_CNL_LP_XHCI               0x9ded</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_XHCI                0xa36d</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_XHCI         0x34ed</span><br><span> </span><br><span> /* Intel P2SB device Ids */</span><br><span> #define PCI_DEVICE_ID_INTEL_APL_P2SB               0x5a92</span><br><span> #define PCI_DEVICE_ID_INTEL_GLK_P2SB          0x3192</span><br><span> #define PCI_DEVICE_ID_INTEL_CNL_P2SB          0x9da0</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_P2SB                0xa320</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_P2SB            0x34a0</span><br><span> </span><br><span> /* Intel SRAM device Ids */</span><br><span> #define PCI_DEVICE_ID_INTEL_APL_SRAM               0x5aec</span><br><span> #define PCI_DEVICE_ID_INTEL_GLK_SRAM          0x31ec</span><br><span> #define PCI_DEVICE_ID_INTEL_CNL_SRAM          0x9def</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_SRAM                0xa36f</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_SRAM            0x34ef</span><br><span> </span><br><span> /* Intel AUDIO device Ids */</span><br><span> #define PCI_DEVICE_ID_INTEL_APL_AUDIO             0x5a98</span><br><span>@@ -2983,6 +3045,7 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_SKL_AUDIO         0x9d70</span><br><span> #define PCI_DEVICE_ID_INTEL_KBL_AUDIO         0x9d71</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_AUDIO               0xa348</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_AUDIO           0x34c8</span><br><span> </span><br><span> /* Intel HECI/ME device Ids */</span><br><span> #define PCI_DEVICE_ID_INTEL_APL_CSE0            0x5a9a</span><br><span>@@ -2990,6 +3053,7 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_CNL_CSE0          0x9de0</span><br><span> #define PCI_DEVICE_ID_INTEL_SKL_CSE0          0x9d3a</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_CSE0                0xa360</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_CSE0            0x34e0</span><br><span> </span><br><span> /* Intel XDCI device Ids */</span><br><span> #define PCI_DEVICE_ID_INTEL_APL_XDCI               0x5aaa</span><br><span>@@ -2997,6 +3061,7 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_SPT_LP_XDCI               0x9d30</span><br><span> #define PCI_DEVICE_ID_INTEL_CNL_LP_XDCI               0x9dee</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_XDCI                0xa36e</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICP_LP_XDCI         0x34ee</span><br><span> </span><br><span> /* Intel SD device Ids */</span><br><span> #define PCI_DEVICE_ID_INTEL_APL_SD           0x5aca</span><br><span>@@ -3004,6 +3069,7 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_SKL_SD            0x9d2d</span><br><span> #define PCI_DEVICE_ID_INTEL_CNL_SD            0x9df5</span><br><span> #define PCI_DEVICE_ID_INTEL_CNP_H_SD          0xa375</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_ICL_SD              0x34f8</span><br><span> </span><br><span> /* Intel EMMC device Ids */</span><br><span> #define PCI_DEVICE_ID_INTEL_SKL_EMMC               0x9d2b</span><br><span>diff --git a/src/soc/intel/common/block/cpu/mp_init.c b/src/soc/intel/common/block/cpu/mp_init.c</span><br><span>index af49c0a..5f5c8cf 100644</span><br><span>--- a/src/soc/intel/common/block/cpu/mp_init.c</span><br><span>+++ b/src/soc/intel/common/block/cpu/mp_init.c</span><br><span>@@ -73,6 +73,8 @@</span><br><span>      { X86_VENDOR_INTEL, CPUID_WHISKEYLAKE_W0 },</span><br><span>  { X86_VENDOR_INTEL, CPUID_COFFEELAKE_U0 },</span><br><span>   { X86_VENDOR_INTEL, CPUID_COFFEELAKE_D0 },</span><br><span style="color: hsl(120, 100%, 40%);">+    { X86_VENDOR_INTEL, CPUID_ICELAKE_A0 },</span><br><span style="color: hsl(120, 100%, 40%);">+       { X86_VENDOR_INTEL, CPUID_ICELAKE_B0 },</span><br><span>      { 0, 0 },</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c</span><br><span>index 9b8a73f..9c35342 100644</span><br><span>--- a/src/soc/intel/common/block/cse/cse.c</span><br><span>+++ b/src/soc/intel/common/block/cse/cse.c</span><br><span>@@ -519,6 +519,7 @@</span><br><span>       PCI_DEVICE_ID_INTEL_CNL_CSE0,</span><br><span>        PCI_DEVICE_ID_INTEL_SKL_CSE0,</span><br><span>        PCI_DEVICE_ID_INTEL_CNP_H_CSE0,</span><br><span style="color: hsl(120, 100%, 40%);">+       PCI_DEVICE_ID_INTEL_ICL_CSE0,</span><br><span>        0,</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/dsp/dsp.c b/src/soc/intel/common/block/dsp/dsp.c</span><br><span>index 4bfe96e..65c86cc 100644</span><br><span>--- a/src/soc/intel/common/block/dsp/dsp.c</span><br><span>+++ b/src/soc/intel/common/block/dsp/dsp.c</span><br><span>@@ -32,6 +32,7 @@</span><br><span>        PCI_DEVICE_ID_INTEL_GLK_AUDIO,</span><br><span>       PCI_DEVICE_ID_INTEL_SKL_AUDIO,</span><br><span>       PCI_DEVICE_ID_INTEL_CNP_H_AUDIO,</span><br><span style="color: hsl(120, 100%, 40%);">+      PCI_DEVICE_ID_INTEL_ICL_AUDIO,</span><br><span>       0,</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/graphics/graphics.c b/src/soc/intel/common/block/graphics/graphics.c</span><br><span>index 4382319..19a78e7 100644</span><br><span>--- a/src/soc/intel/common/block/graphics/graphics.c</span><br><span>+++ b/src/soc/intel/common/block/graphics/graphics.c</span><br><span>@@ -134,6 +134,22 @@</span><br><span>     PCI_DEVICE_ID_INTEL_SKL_GT4_SHALM,</span><br><span>   PCI_DEVICE_ID_INTEL_CFL_H_GT2,</span><br><span>       PCI_DEVICE_ID_INTEL_CFL_S_GT2,</span><br><span style="color: hsl(120, 100%, 40%);">+        PCI_DEVICE_ID_INTEL_ICL_GT0_ULT,</span><br><span style="color: hsl(120, 100%, 40%);">+      PCI_DEVICE_ID_INTEL_ICL_GT0_5_ULT,</span><br><span style="color: hsl(120, 100%, 40%);">+    PCI_DEVICE_ID_INTEL_ICL_GT1_ULT,</span><br><span style="color: hsl(120, 100%, 40%);">+      PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_0,</span><br><span style="color: hsl(120, 100%, 40%);">+    PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_1,</span><br><span style="color: hsl(120, 100%, 40%);">+    PCI_DEVICE_ID_INTEL_ICL_GT2_ULT_1,</span><br><span style="color: hsl(120, 100%, 40%);">+    PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_2,</span><br><span style="color: hsl(120, 100%, 40%);">+    PCI_DEVICE_ID_INTEL_ICL_GT2_ULT_2,</span><br><span style="color: hsl(120, 100%, 40%);">+    PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_3,</span><br><span style="color: hsl(120, 100%, 40%);">+    PCI_DEVICE_ID_INTEL_ICL_GT2_ULT_3,</span><br><span style="color: hsl(120, 100%, 40%);">+    PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_4,</span><br><span style="color: hsl(120, 100%, 40%);">+    PCI_DEVICE_ID_INTEL_ICL_GT2_ULT_4,</span><br><span style="color: hsl(120, 100%, 40%);">+    PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_5,</span><br><span style="color: hsl(120, 100%, 40%);">+    PCI_DEVICE_ID_INTEL_ICL_GT2_ULT_5,</span><br><span style="color: hsl(120, 100%, 40%);">+    PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_6,</span><br><span style="color: hsl(120, 100%, 40%);">+    PCI_DEVICE_ID_INTEL_ICL_GT3_ULT,</span><br><span>     0,</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/hda/hda.c b/src/soc/intel/common/block/hda/hda.c</span><br><span>index 50f847e..f1b5e05 100644</span><br><span>--- a/src/soc/intel/common/block/hda/hda.c</span><br><span>+++ b/src/soc/intel/common/block/hda/hda.c</span><br><span>@@ -76,6 +76,7 @@</span><br><span>        PCI_DEVICE_ID_INTEL_KBL_AUDIO,</span><br><span>       PCI_DEVICE_ID_INTEL_CNL_AUDIO,</span><br><span>       PCI_DEVICE_ID_INTEL_CNP_H_AUDIO,</span><br><span style="color: hsl(120, 100%, 40%);">+      PCI_DEVICE_ID_INTEL_ICL_AUDIO,</span><br><span>       0</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/i2c/i2c.c b/src/soc/intel/common/block/i2c/i2c.c</span><br><span>index 4b67280..01a9bc3 100644</span><br><span>--- a/src/soc/intel/common/block/i2c/i2c.c</span><br><span>+++ b/src/soc/intel/common/block/i2c/i2c.c</span><br><span>@@ -217,6 +217,12 @@</span><br><span>      PCI_DEVICE_ID_INTEL_CNP_H_I2C1,</span><br><span>      PCI_DEVICE_ID_INTEL_CNP_H_I2C2,</span><br><span>      PCI_DEVICE_ID_INTEL_CNP_H_I2C3,</span><br><span style="color: hsl(120, 100%, 40%);">+       PCI_DEVICE_ID_INTEL_ICP_I2C0,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICP_I2C1,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICP_I2C2,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICP_I2C3,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICP_I2C4,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICP_I2C5,</span><br><span>        0,</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/include/intelblocks/mp_init.h b/src/soc/intel/common/block/include/intelblocks/mp_init.h</span><br><span>index c5677e4..b0fd857 100644</span><br><span>--- a/src/soc/intel/common/block/include/intelblocks/mp_init.h</span><br><span>+++ b/src/soc/intel/common/block/include/intelblocks/mp_init.h</span><br><span>@@ -41,6 +41,8 @@</span><br><span> #define CPUID_COFFEELAKE_D0    0x806ea</span><br><span> #define CPUID_COFFEELAKE_U0  0x906ea</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#define CPUID_ICELAKE_A0   0x706e0</span><br><span style="color: hsl(120, 100%, 40%);">+#define CPUID_ICELAKE_B0       0x706e1</span><br><span> /*</span><br><span>  * MP Init callback function to Find CPU Topology. This function is common</span><br><span>  * among all SOCs and thus its in Common CPU block.</span><br><span>diff --git a/src/soc/intel/common/block/lpc/lpc.c b/src/soc/intel/common/block/lpc/lpc.c</span><br><span>index bb3b4f2..fa56696 100644</span><br><span>--- a/src/soc/intel/common/block/lpc/lpc.c</span><br><span>+++ b/src/soc/intel/common/block/lpc/lpc.c</span><br><span>@@ -146,6 +146,13 @@</span><br><span>       PCI_DEVICE_ID_INTEL_CNL_Y_PREMIUM_LPC,</span><br><span>       PCI_DEVICE_ID_INTEL_CNP_H_LPC_Q370,</span><br><span>  PCI_DEVICE_ID_INTEL_CNP_H_LPC_QM370,</span><br><span style="color: hsl(120, 100%, 40%);">+  PCI_DEVICE_ID_INTEL_ICL_BASE_U_LPC,</span><br><span style="color: hsl(120, 100%, 40%);">+   PCI_DEVICE_ID_INTEL_ICL_BASE_Y_LPC,</span><br><span style="color: hsl(120, 100%, 40%);">+   PCI_DEVICE_ID_INTEL_ICL_U_PREMIUM_LPC,</span><br><span style="color: hsl(120, 100%, 40%);">+        PCI_DEVICE_ID_INTEL_ICL_U_SUPER_U_LPC,</span><br><span style="color: hsl(120, 100%, 40%);">+        PCI_DEVICE_ID_INTEL_ICL_U_SUPER_U_LPC_REV0,</span><br><span style="color: hsl(120, 100%, 40%);">+   PCI_DEVICE_ID_INTEL_ICL_SUPER_Y_LPC,</span><br><span style="color: hsl(120, 100%, 40%);">+  PCI_DEVICE_ID_INTEL_ICL_Y_PREMIUM_LPC,</span><br><span>       0</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/p2sb/p2sb.c b/src/soc/intel/common/block/p2sb/p2sb.c</span><br><span>index 69e1f97..e93223f 100644</span><br><span>--- a/src/soc/intel/common/block/p2sb/p2sb.c</span><br><span>+++ b/src/soc/intel/common/block/p2sb/p2sb.c</span><br><span>@@ -167,6 +167,7 @@</span><br><span>       PCI_DEVICE_ID_INTEL_GLK_P2SB,</span><br><span>        PCI_DEVICE_ID_INTEL_CNL_P2SB,</span><br><span>        PCI_DEVICE_ID_INTEL_CNP_H_P2SB,</span><br><span style="color: hsl(120, 100%, 40%);">+       PCI_DEVICE_ID_INTEL_ICL_P2SB,</span><br><span>        0,</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/pcie/pcie.c b/src/soc/intel/common/block/pcie/pcie.c</span><br><span>index 2ec37e2..3ebb4f6 100644</span><br><span>--- a/src/soc/intel/common/block/pcie/pcie.c</span><br><span>+++ b/src/soc/intel/common/block/pcie/pcie.c</span><br><span>@@ -190,6 +190,22 @@</span><br><span>     PCI_DEVICE_ID_INTEL_CNP_H_PCIE_RP22,</span><br><span>         PCI_DEVICE_ID_INTEL_CNP_H_PCIE_RP23,</span><br><span>         PCI_DEVICE_ID_INTEL_CNP_H_PCIE_RP24,</span><br><span style="color: hsl(120, 100%, 40%);">+  PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP1,</span><br><span style="color: hsl(120, 100%, 40%);">+  PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP2,</span><br><span style="color: hsl(120, 100%, 40%);">+  PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP3,</span><br><span style="color: hsl(120, 100%, 40%);">+  PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP4,</span><br><span style="color: hsl(120, 100%, 40%);">+  PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP5,</span><br><span style="color: hsl(120, 100%, 40%);">+  PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP6,</span><br><span style="color: hsl(120, 100%, 40%);">+  PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP7,</span><br><span style="color: hsl(120, 100%, 40%);">+  PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP8,</span><br><span style="color: hsl(120, 100%, 40%);">+  PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP9,</span><br><span style="color: hsl(120, 100%, 40%);">+  PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP10,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP11,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP12,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP13,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP14,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP15,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICP_LP_PCIE_RP16,</span><br><span>        0</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/pmc/pmc.c b/src/soc/intel/common/block/pmc/pmc.c</span><br><span>index 8dca629..e418db0 100644</span><br><span>--- a/src/soc/intel/common/block/pmc/pmc.c</span><br><span>+++ b/src/soc/intel/common/block/pmc/pmc.c</span><br><span>@@ -127,6 +127,7 @@</span><br><span>       PCI_DEVICE_ID_INTEL_APL_PMC,</span><br><span>         PCI_DEVICE_ID_INTEL_GLK_PMC,</span><br><span>         PCI_DEVICE_ID_INTEL_CNP_H_PMC,</span><br><span style="color: hsl(120, 100%, 40%);">+        PCI_DEVICE_ID_INTEL_ICP_PMC,</span><br><span>         0</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/sata/sata.c b/src/soc/intel/common/block/sata/sata.c</span><br><span>index d7c8c00..a600cb9 100644</span><br><span>--- a/src/soc/intel/common/block/sata/sata.c</span><br><span>+++ b/src/soc/intel/common/block/sata/sata.c</span><br><span>@@ -78,6 +78,7 @@</span><br><span>         PCI_DEVICE_ID_INTEL_CNL_COMPAT_SATA,</span><br><span>         PCI_DEVICE_ID_INTEL_CNP_H_SATA,</span><br><span>      PCI_DEVICE_ID_INTEL_CNP_LP_SATA,</span><br><span style="color: hsl(120, 100%, 40%);">+      PCI_DEVICE_ID_INTEL_ICP_U_SATA,</span><br><span>      0</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/scs/sd.c b/src/soc/intel/common/block/scs/sd.c</span><br><span>index 81fff29..812146f 100644</span><br><span>--- a/src/soc/intel/common/block/scs/sd.c</span><br><span>+++ b/src/soc/intel/common/block/scs/sd.c</span><br><span>@@ -71,6 +71,7 @@</span><br><span>     PCI_DEVICE_ID_INTEL_GLK_SD,</span><br><span>  PCI_DEVICE_ID_INTEL_SKL_SD,</span><br><span>  PCI_DEVICE_ID_INTEL_CNP_H_SD,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICL_SD,</span><br><span>  0</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/smbus/smbus.c b/src/soc/intel/common/block/smbus/smbus.c</span><br><span>index 9bb9436..83dfedf 100644</span><br><span>--- a/src/soc/intel/common/block/smbus/smbus.c</span><br><span>+++ b/src/soc/intel/common/block/smbus/smbus.c</span><br><span>@@ -92,6 +92,7 @@</span><br><span>         PCI_DEVICE_ID_INTEL_SPT_LP_SMBUS,</span><br><span>    PCI_DEVICE_ID_INTEL_SPT_H_SMBUS,</span><br><span>     PCI_DEVICE_ID_INTEL_KBP_H_SMBUS,</span><br><span style="color: hsl(120, 100%, 40%);">+      PCI_DEVICE_ID_INTEL_ICP_LP_SMBUS,</span><br><span>    0</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/spi/spi.c b/src/soc/intel/common/block/spi/spi.c</span><br><span>index 3a51466..6038f46 100644</span><br><span>--- a/src/soc/intel/common/block/spi/spi.c</span><br><span>+++ b/src/soc/intel/common/block/spi/spi.c</span><br><span>@@ -67,6 +67,10 @@</span><br><span>        PCI_DEVICE_ID_INTEL_CNL_SPI1,</span><br><span>        PCI_DEVICE_ID_INTEL_CNL_SPI2,</span><br><span>        PCI_DEVICE_ID_INTEL_CNL_HWSEQ_SPI,</span><br><span style="color: hsl(120, 100%, 40%);">+    PCI_DEVICE_ID_INTEL_ICP_SPI0,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICP_SPI1,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICP_SPI2,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICP_HWSEQ_SPI,</span><br><span>   0</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/sram/sram.c b/src/soc/intel/common/block/sram/sram.c</span><br><span>index e38d478..507ff58 100644</span><br><span>--- a/src/soc/intel/common/block/sram/sram.c</span><br><span>+++ b/src/soc/intel/common/block/sram/sram.c</span><br><span>@@ -49,6 +49,7 @@</span><br><span> static const unsigned short pci_device_ids[] = {</span><br><span>     PCI_DEVICE_ID_INTEL_APL_SRAM,</span><br><span>        PCI_DEVICE_ID_INTEL_GLK_SRAM,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICL_SRAM,</span><br><span>        0,</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/systemagent/systemagent.c b/src/soc/intel/common/block/systemagent/systemagent.c</span><br><span>index 62ea122..9608359 100644</span><br><span>--- a/src/soc/intel/common/block/systemagent/systemagent.c</span><br><span>+++ b/src/soc/intel/common/block/systemagent/systemagent.c</span><br><span>@@ -306,6 +306,10 @@</span><br><span>     PCI_DEVICE_ID_INTEL_CFL_ID_U,</span><br><span>        PCI_DEVICE_ID_INTEL_CFL_ID_H,</span><br><span>        PCI_DEVICE_ID_INTEL_CFL_ID_S,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICL_ID_U,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICL_ID_U_2_2,</span><br><span style="color: hsl(120, 100%, 40%);">+     PCI_DEVICE_ID_INTEL_ICL_ID_Y,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_ICL_ID_Y_2,</span><br><span>      0</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c</span><br><span>index 5fb7da6..f7235cf 100644</span><br><span>--- a/src/soc/intel/common/block/uart/uart.c</span><br><span>+++ b/src/soc/intel/common/block/uart/uart.c</span><br><span>@@ -265,6 +265,9 @@</span><br><span>       PCI_DEVICE_ID_INTEL_CNP_H_UART0,</span><br><span>     PCI_DEVICE_ID_INTEL_CNP_H_UART1,</span><br><span>     PCI_DEVICE_ID_INTEL_CNP_H_UART2,</span><br><span style="color: hsl(120, 100%, 40%);">+      PCI_DEVICE_ID_INTEL_ICP_UART0,</span><br><span style="color: hsl(120, 100%, 40%);">+        PCI_DEVICE_ID_INTEL_ICP_UART1,</span><br><span style="color: hsl(120, 100%, 40%);">+        PCI_DEVICE_ID_INTEL_ICP_UART2,</span><br><span>       0,</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/xdci/xdci.c b/src/soc/intel/common/block/xdci/xdci.c</span><br><span>index 47a116e..d2e8769 100644</span><br><span>--- a/src/soc/intel/common/block/xdci/xdci.c</span><br><span>+++ b/src/soc/intel/common/block/xdci/xdci.c</span><br><span>@@ -42,6 +42,7 @@</span><br><span>        PCI_DEVICE_ID_INTEL_GLK_XDCI,</span><br><span>        PCI_DEVICE_ID_INTEL_SPT_LP_XDCI,</span><br><span>     PCI_DEVICE_ID_INTEL_CNP_H_XDCI,</span><br><span style="color: hsl(120, 100%, 40%);">+       PCI_DEVICE_ID_INTEL_ICP_LP_XDCI,</span><br><span>     0</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/xhci/xhci.c b/src/soc/intel/common/block/xhci/xhci.c</span><br><span>index be97aa7..9641177 100644</span><br><span>--- a/src/soc/intel/common/block/xhci/xhci.c</span><br><span>+++ b/src/soc/intel/common/block/xhci/xhci.c</span><br><span>@@ -43,6 +43,7 @@</span><br><span>         PCI_DEVICE_ID_INTEL_SPT_H_XHCI,</span><br><span>      PCI_DEVICE_ID_INTEL_KBP_H_XHCI,</span><br><span>      PCI_DEVICE_ID_INTEL_CNP_H_XHCI,</span><br><span style="color: hsl(120, 100%, 40%);">+       PCI_DEVICE_ID_INTEL_ICP_LP_XHCI,</span><br><span>     0</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/soc/intel/icelake/bootblock/report_platform.c b/src/soc/intel/icelake/bootblock/report_platform.c</span><br><span>index 9df6a1e..0696525 100644</span><br><span>--- a/src/soc/intel/icelake/bootblock/report_platform.c</span><br><span>+++ b/src/soc/intel/icelake/bootblock/report_platform.c</span><br><span>@@ -38,6 +38,8 @@</span><br><span>     { CPUID_COFFEELAKE_D0, "Coffeelake D0" },</span><br><span>  { CPUID_WHISKEYLAKE_W0, "Whiskeylake W0"},</span><br><span>         { CPUID_COFFEELAKE_U0, "Coffeelake U0 (6+2)" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { CPUID_ICELAKE_A0, "Icelake A0" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { CPUID_ICELAKE_B0, "Icelake B0" },</span><br><span> };</span><br><span> </span><br><span> static struct {</span><br><span>@@ -51,6 +53,10 @@</span><br><span>      { PCI_DEVICE_ID_INTEL_WHL_ID_Wx2, "Whiskeylake W (2+2)"},</span><br><span>  { PCI_DEVICE_ID_INTEL_CFL_ID_H, "Coffeelake-H" },</span><br><span>  { PCI_DEVICE_ID_INTEL_CFL_ID_S, "Coffeelake-S" },</span><br><span style="color: hsl(120, 100%, 40%);">+   { PCI_DEVICE_ID_INTEL_ICL_ID_U, "Icelake-U" },</span><br><span style="color: hsl(120, 100%, 40%);">+      { PCI_DEVICE_ID_INTEL_ICL_ID_U_2_2, "Icelake-U-2-2" },</span><br><span style="color: hsl(120, 100%, 40%);">+      { PCI_DEVICE_ID_INTEL_ICL_ID_Y, "Icelake-Y" },</span><br><span style="color: hsl(120, 100%, 40%);">+      { PCI_DEVICE_ID_INTEL_ICL_ID_Y_2, "Icelake-Y" },</span><br><span> };</span><br><span> </span><br><span> static struct {</span><br><span>@@ -62,6 +68,13 @@</span><br><span>         { PCI_DEVICE_ID_INTEL_CNL_Y_PREMIUM_LPC, "Cannonlake-Y Premium" },</span><br><span>         { PCI_DEVICE_ID_INTEL_CNP_H_LPC_Q370, "Cannonlake-H Q370" },</span><br><span>       { PCI_DEVICE_ID_INTEL_CNP_H_LPC_QM370, "Cannonlake-H QM370" },</span><br><span style="color: hsl(120, 100%, 40%);">+      { PCI_DEVICE_ID_INTEL_ICL_BASE_U_LPC, "Icelake-U Base" },</span><br><span style="color: hsl(120, 100%, 40%);">+   { PCI_DEVICE_ID_INTEL_ICL_BASE_Y_LPC, "Icelake-Y Base" },</span><br><span style="color: hsl(120, 100%, 40%);">+   { PCI_DEVICE_ID_INTEL_ICL_U_PREMIUM_LPC, "Icelake-U Premium" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { PCI_DEVICE_ID_INTEL_ICL_U_SUPER_U_LPC, "Icelake-U Super" },</span><br><span style="color: hsl(120, 100%, 40%);">+       { PCI_DEVICE_ID_INTEL_ICL_U_SUPER_U_LPC_REV0, "Icelake-U Super" },</span><br><span style="color: hsl(120, 100%, 40%);">+  { PCI_DEVICE_ID_INTEL_ICL_SUPER_Y_LPC, "Icelake-Y Super" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_DEVICE_ID_INTEL_ICL_Y_PREMIUM_LPC, "Icelake-Y Premium" },</span><br><span> };</span><br><span> </span><br><span> static struct {</span><br><span>@@ -80,6 +93,21 @@</span><br><span>  { PCI_DEVICE_ID_INTEL_WHL_GT2_ULT_1, "Whiskeylake ULT GT1"},</span><br><span>       { PCI_DEVICE_ID_INTEL_CFL_H_GT2, "Coffeelake-H GT2" },</span><br><span>     { PCI_DEVICE_ID_INTEL_CFL_S_GT2, "Coffeelake-S GT2" },</span><br><span style="color: hsl(120, 100%, 40%);">+      { PCI_DEVICE_ID_INTEL_ICL_GT0_ULT, "Icelake ULT GT0" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { PCI_DEVICE_ID_INTEL_ICL_GT0_5_ULT, "Icelake ULT GT0.5" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_DEVICE_ID_INTEL_ICL_GT1_ULT, "Icelake U GT1" },</span><br><span style="color: hsl(120, 100%, 40%);">+       { PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_0, "Icelake Y GT2" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_1, "Icelake Y GT2" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { PCI_DEVICE_ID_INTEL_ICL_GT2_ULT_1, "Icelake U GT2" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_2, "Icelake Y GT2" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { PCI_DEVICE_ID_INTEL_ICL_GT2_ULT_2, "Icelake U GT2" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_3, "Icelake Y GT2" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { PCI_DEVICE_ID_INTEL_ICL_GT2_ULT_3, "Icelake U GT2" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_4, "Icelake Y GT2" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { PCI_DEVICE_ID_INTEL_ICL_GT2_ULT_4, "Icelake U GT2" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { PCI_DEVICE_ID_INTEL_ICL_GT2_ULX_5, "Icelake Y GT2" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { PCI_DEVICE_ID_INTEL_ICL_GT2_ULT_5, "Icelake U GT2" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { PCI_DEVICE_ID_INTEL_ICL_GT3_ULT, "Icelake U GT3" },</span><br><span> };</span><br><span> </span><br><span> static uint8_t get_dev_revision(pci_devfn_t dev)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29435">change 29435</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29435"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2c398957ffbc9bb0e5b363740d99433075ca66a3 </div>
<div style="display:none"> Gerrit-Change-Number: 29435 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>