<p>Nick Vaccaro has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29429">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variant/nocturne: use PLTRST for GPP_C11<br><br>GPP_C11 was set to DEEP, causing problems with S3.<br>Changed GPP_C11 configuration to use PLTRST instead.<br><br>BUG=b:114196791<br>TEST=Build, flash, boot nocturne, log in to kernel and execute<br>the following two commands and verify it passes :<br>  echo 0 > /var/lib/power_manager/suspend_to_idle && restart powerd<br>  sudo suspend_stress_test -c 2<br><br>Change-Id: I008532fce963c51a435378001440ac72b5ebfffc<br>Signed-off-by: Nick Vaccaro <nvaccaro@google.com><br>---<br>M src/mainboard/google/poppy/variants/nocturne/gpio.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/29429/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/gpio.c b/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>index 16ff982..9aa7706 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>@@ -135,7 +135,7 @@</span><br><span>  /* C10 : UART0_RTS# ==> PCH_FPMCU_RST_ODL */</span><br><span>      PAD_CFG_GPO(GPP_C10, 1, DEEP),</span><br><span>       /* C11 : UART0_CTS# ==> FPMCU_INT */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_GPI_APIC(GPP_C11, 20K_PU, DEEP),</span><br><span style="color: hsl(120, 100%, 40%);">+      PAD_CFG_GPI_APIC(GPP_C11, 20K_PU, PLTRST),</span><br><span>   /* C12 : UART1_RXD ==> PCH_MEM_CONFIG[0] */</span><br><span>       PAD_CFG_GPI_GPIO_DRIVER(GPP_C12, NONE, DEEP),</span><br><span>        /* C13 : UART1_TXD ==> PCH_MEM_CONFIG[1] */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29429">change 29429</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29429"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I008532fce963c51a435378001440ac72b5ebfffc </div>
<div style="display:none"> Gerrit-Change-Number: 29429 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com> </div>