<p>Frans Hendriks has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29371">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/drivers/intel/fsp1_1/raminit.c: Make check FSP HOBs independent of CONFIG_DISPLAY_HOBS.<br><br>Check for FSP HOBS is disabled when CONFIG_DISPLAY_HOBS is disabled.<br>Use the CONFIG_DISPLAY_HOBS for determination of display HOB info only.<br><br>BUG=N/A<br>TEST=Intel CherryHill CRB<br><br>Change-Id: I3776fa37866c7ef3aea090842387660c22bbdd4d<br>Signed-off-by: Frans Hendriks <fhendriks@eltan.com><br>---<br>M src/drivers/intel/fsp1_1/raminit.c<br>1 file changed, 2 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/29371/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/intel/fsp1_1/raminit.c b/src/drivers/intel/fsp1_1/raminit.c</span><br><span>index c7d8722..3adced2 100644</span><br><span>--- a/src/drivers/intel/fsp1_1/raminit.c</span><br><span>+++ b/src/drivers/intel/fsp1_1/raminit.c</span><br><span>@@ -50,10 +50,8 @@</span><br><span>   VPD_DATA_REGION *vpd_ptr;</span><br><span>    UPD_DATA_REGION *upd_ptr;</span><br><span>    int fsp_verification_failure = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-#if IS_ENABLED(CONFIG_DISPLAY_HOBS)</span><br><span>         unsigned long int data;</span><br><span>      EFI_PEI_HOB_POINTERS hob_ptr;</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span> </span><br><span>      /*</span><br><span>    * Find and copy the UPD region to the stack so the platform can modify</span><br><span>@@ -193,7 +191,6 @@</span><br><span>                        memory_info_hob);</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#if IS_ENABLED(CONFIG_DISPLAY_HOBS)</span><br><span>     if (hob_list_ptr == NULL)</span><br><span>            die("ERROR - HOB pointer is NULL!\n");</span><br><span> </span><br><span>@@ -241,8 +238,8 @@</span><br><span>                   "ERROR - Missing one or more required FSP HOBs!\n");</span><br><span> </span><br><span>   /* Display the HOBs */</span><br><span style="color: hsl(0, 100%, 40%);">-  print_hob_type_structure(0, hob_list_ptr);</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(120, 100%, 40%);">+      if (IS_ENABLED(CONFIG_DISPLAY_HOBS))</span><br><span style="color: hsl(120, 100%, 40%);">+          print_hob_type_structure(0, hob_list_ptr);</span><br><span> </span><br><span>       /* Get the address of the CBMEM region for the FSP reserved memory */</span><br><span>        fsp_reserved_memory_area = cbmem_find(CBMEM_ID_FSP_RESERVED_MEMORY);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29371">change 29371</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29371"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3776fa37866c7ef3aea090842387660c22bbdd4d </div>
<div style="display:none"> Gerrit-Change-Number: 29371 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com> </div>