<p>Tristan Corrick has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29385">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/haswell/gma: Support boards that have DDI E connected<br><br>On an ASRock H81M-HDS neither libgfxinit, nor Linux, is able to<br>initialise the display when lanes are not configured to be shared<br>between DDI A and DDI E.<br><br>Intel's reference manual [1] states that the decision to share lanes<br>between DDI A and DDI E is "based on board configuration". Hence, add a<br>new field to the devicetree that boards can set. All existing Haswell<br>boards have this unset, thus taking a value of 0, so there is no change<br>to existing behaviour.<br><br>[1]: Intel Open Source Graphics Programmer's Reference Manual (PRM)<br>     Volume 2c: Command Reference: Registers (Haswell)<br>     https://01.org/linuxgraphics/documentation/hardware-specification-prms/2013-intel-core-processor-family<br><br>Change-Id: I6f7832293215d2b53e31b0a5c985e6098eb72f1b<br>Signed-off-by: Tristan Corrick <tristan@corrick.kiwi><br>---<br>M src/northbridge/intel/haswell/chip.h<br>M src/northbridge/intel/haswell/gma.c<br>2 files changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/29385/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/haswell/chip.h b/src/northbridge/intel/haswell/chip.h</span><br><span>index 098bc33..fdabc3f 100644</span><br><span>--- a/src/northbridge/intel/haswell/chip.h</span><br><span>+++ b/src/northbridge/intel/haswell/chip.h</span><br><span>@@ -40,6 +40,8 @@</span><br><span>    u32 gpu_cpu_backlight;  /* CPU Backlight PWM value */</span><br><span>        u32 gpu_pch_backlight;  /* PCH Backlight PWM value */</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+     bool gpu_ddi_e_connected;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  struct i915_gpu_controller_info gfx;</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c</span><br><span>index efc9fa3..f4cec68 100644</span><br><span>--- a/src/northbridge/intel/haswell/gma.c</span><br><span>+++ b/src/northbridge/intel/haswell/gma.c</span><br><span>@@ -368,7 +368,10 @@</span><br><span>          bit 4: DDI A supports 4 lanes and DDI E is not used</span><br><span>          bit 7: DDI buffer is idle</span><br><span>         */</span><br><span style="color: hsl(0, 100%, 40%);">-      gtt_write(DDI_BUF_CTL_A, DDI_BUF_IS_IDLE | DDI_A_4_LANES | DDI_INIT_DISPLAY_DETECTED);</span><br><span style="color: hsl(120, 100%, 40%);">+        reg32 = DDI_BUF_IS_IDLE | DDI_INIT_DISPLAY_DETECTED;</span><br><span style="color: hsl(120, 100%, 40%);">+  if (!conf->gpu_ddi_e_connected)</span><br><span style="color: hsl(120, 100%, 40%);">+            reg32 |= DDI_A_4_LANES;</span><br><span style="color: hsl(120, 100%, 40%);">+       gtt_write(DDI_BUF_CTL_A, reg32);</span><br><span> </span><br><span>         /* Set FDI registers - is this required? */</span><br><span>  gtt_write(_FDI_RXA_MISC, 0x00200090);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29385">change 29385</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29385"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6f7832293215d2b53e31b0a5c985e6098eb72f1b </div>
<div style="display:none"> Gerrit-Change-Number: 29385 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Tristan Corrick <tristan@corrick.kiwi> </div>