<p><a href="https://review.coreboot.org/29406">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29406/1/src/soc/amd/stoneyridge/s3test_util.c">File src/soc/amd/stoneyridge/s3test_util.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29406/1/src/soc/amd/stoneyridge/s3test_util.c@249">Patch Set #1, Line 249:</a> <code style="font-family:monospace,monospace">        wbinvd();</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29406/1/src/soc/amd/stoneyridge/s3test_util.c@249">Patch Set #1, Line 249:</a> <code style="font-family:monospace,monospace">         wbinvd();</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29406/1/src/soc/amd/stoneyridge/s3test_util.c@249">Patch Set #1, Line 249:</a> <code style="font-family:monospace,monospace">       wbinvd();</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29406/1/src/soc/amd/stoneyridge/s3test_util.c@251">Patch Set #1, Line 251:</a> <code style="font-family:monospace,monospace">   err = 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29406/1/src/soc/amd/stoneyridge/s3test_util.c@251">Patch Set #1, Line 251:</a> <code style="font-family:monospace,monospace">          err = 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29406/1/src/soc/amd/stoneyridge/s3test_util.c@251">Patch Set #1, Line 251:</a> <code style="font-family:monospace,monospace">        err = 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29406">change 29406</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29406"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I375dd7ea9a3ab8992f1616126bcbd9724e4fc9a0 </div>
<div style="display:none"> Gerrit-Change-Number: 29406 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 31 Oct 2018 20:34:58 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>