<p>Frans Hendriks has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29374">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/soc/intel/braswell/acpi/lpss.asl: Remove disabled SPI1 and PWM devices<br><br>ACPI code for these devices is enabled, but devices are disabled on the platform.<br>Remove these devices when disabled.<br><br>BUG=N/A<br>TEST=Intel CherryHill CRB<br><br>Change-Id: I97aeb725ee5fb162b958e4f83f73814c55a6066b<br>Signed-off-by: Frans Hendriks <fhendriks@eltan.com><br>---<br>M src/soc/intel/braswell/Kconfig<br>M src/soc/intel/braswell/acpi/lpss.asl<br>2 files changed, 14 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/29374/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/braswell/Kconfig b/src/soc/intel/braswell/Kconfig</span><br><span>index 6e3adcd..1f44e78 100644</span><br><span>--- a/src/soc/intel/braswell/Kconfig</span><br><span>+++ b/src/soc/intel/braswell/Kconfig</span><br><span>@@ -127,6 +127,13 @@</span><br><span> string</span><br><span> default "soc/intel/braswell/bootblock/timestamp.inc"</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+config INCLUDE_SPI1_AND_PWM</span><br><span style="color: hsl(120, 100%, 40%);">+ bool "Include ASL code for SPI1 and PWM devices"</span><br><span style="color: hsl(120, 100%, 40%);">+ default y</span><br><span style="color: hsl(120, 100%, 40%);">+ help</span><br><span style="color: hsl(120, 100%, 40%);">+ Enable this if the SPI1 and PWM interfaces are supported</span><br><span style="color: hsl(120, 100%, 40%);">+ This requires an FSP update.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> config ENABLE_LPE_DEVICES</span><br><span> bool "Include ASL code for LPE devices"</span><br><span> default y</span><br><span>diff --git a/src/soc/intel/braswell/acpi/lpss.asl b/src/soc/intel/braswell/acpi/lpss.asl</span><br><span>index 4cc93cc..5e71101 100644</span><br><span>--- a/src/soc/intel/braswell/acpi/lpss.asl</span><br><span>+++ b/src/soc/intel/braswell/acpi/lpss.asl</span><br><span>@@ -2,6 +2,7 @@</span><br><span> * This file is part of the coreboot project.</span><br><span> *</span><br><span> * Copyright (C) 2013 Google Inc.</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2018 Eltan B.V.</span><br><span> *</span><br><span> * This program is free software; you can redistribute it and/or</span><br><span> * modify it under the terms of the GNU General Public License as</span><br><span>@@ -522,6 +523,11 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+//</span><br><span style="color: hsl(120, 100%, 40%);">+// Remove the devices that can't be enabled from ASL. This will keep Linux from trying to</span><br><span style="color: hsl(120, 100%, 40%);">+// use them even tough they are disabled.</span><br><span style="color: hsl(120, 100%, 40%);">+//</span><br><span style="color: hsl(120, 100%, 40%);">+#if IS_ENABLED(CONFIG_INCLUDE_SPI1_AND_PWM)</span><br><span> Device (SPI1)</span><br><span> {</span><br><span> Name (_HID, "8086228E")</span><br><span>@@ -630,6 +636,7 @@</span><br><span> }</span><br><span> }</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> </span><br><span> Device (UAR1)</span><br><span> {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29374">change 29374</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29374"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I97aeb725ee5fb162b958e4f83f73814c55a6066b </div>
<div style="display:none"> Gerrit-Change-Number: 29374 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com> </div>