<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +2</span></p><p><a href="https://review.coreboot.org/29378">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29378/1/src/northbridge/intel/haswell/haswell.h">File src/northbridge/intel/haswell/haswell.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29378/1/src/northbridge/intel/haswell/haswell.h@213">Patch Set #1, Line 213:</a> <code style="font-family:monospace,monospace">#define PCI_DEVICE_ID_HSW_DESKTOP 0x0c00</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">actually, we have a common header file for such definitions</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29378/1/src/northbridge/intel/haswell/northbridge.c">File src/northbridge/intel/haswell/northbridge.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29378/1/src/northbridge/intel/haswell/northbridge.c@468">Patch Set #1, Line 468:</a> <code style="font-family:monospace,monospace">};</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I guess you could alternatively combine all three `pci_driver`s<br>and use a `.devices` list.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29378">change 29378</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29378"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ie162cb7a27e313ffe612659e8444657a3772d3c9 </div>
<div style="display:none"> Gerrit-Change-Number: 29378 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Tristan Corrick <tristan@corrick.kiwi> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 31 Oct 2018 13:32:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>