<p>Karthik Ramasubramanian has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29358">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drivers/elog: Add support for early elog<br><br>Add support to log events during the romstage.<br><br>BUG=b:117884485<br><br>Change-Id: Ia69515961da3bc72740f9b048a53d91af79c5b0d<br>Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com><br>---<br>M src/drivers/elog/Makefile.inc<br>M src/drivers/elog/elog.c<br>2 files changed, 37 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/29358/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/elog/Makefile.inc b/src/drivers/elog/Makefile.inc</span><br><span>index 79a7cc0..e0c42e2 100644</span><br><span>--- a/src/drivers/elog/Makefile.inc</span><br><span>+++ b/src/drivers/elog/Makefile.inc</span><br><span>@@ -1,3 +1,4 @@</span><br><span style="color: hsl(120, 100%, 40%);">+romstage-$(CONFIG_ELOG) += elog.c</span><br><span> ramstage-$(CONFIG_ELOG) += elog.c</span><br><span> </span><br><span> smm-$(CONFIG_ELOG_GSMI) += elog.c gsmi.c</span><br><span>diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c</span><br><span>index d3c01c2..7d0e0a9 100644</span><br><span>--- a/src/drivers/elog/elog.c</span><br><span>+++ b/src/drivers/elog/elog.c</span><br><span>@@ -16,6 +16,7 @@</span><br><span> #if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME)</span><br><span> #include <arch/acpi.h></span><br><span> #endif</span><br><span style="color: hsl(120, 100%, 40%);">+#include <arch/early_variables.h></span><br><span> #include <bootstate.h></span><br><span> #include <cbmem.h></span><br><span> #include <console/console.h></span><br><span>@@ -42,6 +43,15 @@</span><br><span> #endif</span><br><span> </span><br><span> #define NV_NEEDS_ERASE (~(size_t)0)</span><br><span style="color: hsl(120, 100%, 40%);">+enum elog_state {</span><br><span style="color: hsl(120, 100%, 40%);">+ ELOG_UNINITIALIZED = 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ ELOG_INITIALIZED,</span><br><span style="color: hsl(120, 100%, 40%);">+ ELOG_BROKEN,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define MAX_ELOG_SIZE (4 * KiB)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#if ENV_RAMSTAGE</span><br><span> /*</span><br><span> * Static variables for ELOG state</span><br><span> */</span><br><span>@@ -60,11 +70,29 @@</span><br><span> /* Device that mirrors the eventlog in memory. */</span><br><span> static struct mem_region_device mirror_dev;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static enum {</span><br><span style="color: hsl(0, 100%, 40%);">- ELOG_UNINITIALIZED = 0,</span><br><span style="color: hsl(0, 100%, 40%);">- ELOG_INITIALIZED,</span><br><span style="color: hsl(0, 100%, 40%);">- ELOG_BROKEN,</span><br><span style="color: hsl(0, 100%, 40%);">-} elog_initialized = ELOG_UNINITIALIZED;</span><br><span style="color: hsl(120, 100%, 40%);">+static enum elog_state elog_initialized;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static uint8_t * get_elog_mirror_buffer(size_t elog_size) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (elog_size == MAX_ELOG_SIZE)</span><br><span style="color: hsl(120, 100%, 40%);">+ return (uint8_t *)malloc(elog_size);</span><br><span style="color: hsl(120, 100%, 40%);">+ return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+static u16 full_threshold CAR_GLOBAL;</span><br><span style="color: hsl(120, 100%, 40%);">+static u16 shrink_size CAR_GLOBAL;</span><br><span style="color: hsl(120, 100%, 40%);">+static size_t mirror_last_write CAR_GLOBAL;</span><br><span style="color: hsl(120, 100%, 40%);">+static size_t nv_last_write CAR_GLOBAL;</span><br><span style="color: hsl(120, 100%, 40%);">+static struct region_device nv_dev CAR_GLOBAL;</span><br><span style="color: hsl(120, 100%, 40%);">+static struct mem_region_device mirror_dev CAR_GLOBAL;</span><br><span style="color: hsl(120, 100%, 40%);">+static enum elog_state elog_initialized CAR_GLOBAL;</span><br><span style="color: hsl(120, 100%, 40%);">+static uint8_t early_elog_buf[MAX_ELOG_SIZE] CAR_GLOBAL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static uint8_t * get_elog_mirror_buffer(size_t elog_size) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (elog_size == MAX_ELOG_SIZE)</span><br><span style="color: hsl(120, 100%, 40%);">+ return (uint8_t *)car_get_var_ptr(early_elog_buf);</span><br><span style="color: hsl(120, 100%, 40%);">+ return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> </span><br><span> static inline struct region_device *mirror_dev_get(void)</span><br><span> {</span><br><span>@@ -776,7 +804,7 @@</span><br><span> return -1;</span><br><span> </span><br><span> elog_size = region_device_sz(&nv_dev);</span><br><span style="color: hsl(0, 100%, 40%);">- mirror_buffer = malloc(elog_size);</span><br><span style="color: hsl(120, 100%, 40%);">+ mirror_buffer = get_elog_mirror_buffer(elog_size);</span><br><span> if (!mirror_buffer) {</span><br><span> printk(BIOS_ERR, "ELOG: Unable to allocate backing store\n");</span><br><span> return -1;</span><br><span>@@ -800,6 +828,7 @@</span><br><span> full_threshold, shrink_size);</span><br><span> </span><br><span> if (elog_do_add_boot_count()) {</span><br><span style="color: hsl(120, 100%, 40%);">+#if ENV_RAMSTAGE</span><br><span> elog_add_event_dword(ELOG_TYPE_BOOT, boot_count_read());</span><br><span> </span><br><span> #if IS_ENABLED(CONFIG_ARCH_X86)</span><br><span>@@ -807,6 +836,7 @@</span><br><span> if (IS_ENABLED(CONFIG_CMOS_POST))</span><br><span> cmos_post_log();</span><br><span> #endif</span><br><span style="color: hsl(120, 100%, 40%);">+#endif /* ENV_RAMSTAGE */</span><br><span> }</span><br><span> return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29358">change 29358</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29358"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia69515961da3bc72740f9b048a53d91af79c5b0d </div>
<div style="display:none"> Gerrit-Change-Number: 29358 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Karthik Ramasubramanian <kramasub@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub@chromium.org> </div>