<p>Philipp Hug has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29339">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/arch/riscv/misaligned.c: Fix an off-by-one error when loading the opcode<br><br>Pointer to opcode increases by unit uint16_t not byte.<br><br>Change-Id: I2986ca5402ad86d80e0eb955478bfbdc5d50e1f5<br>Signed-off-by: Philipp Hug <philipp@hug.cx><br>---<br>M src/arch/riscv/misaligned.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/29339/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/arch/riscv/misaligned.c b/src/arch/riscv/misaligned.c</span><br><span>index ba96102..ebff2d6 100644</span><br><span>--- a/src/arch/riscv/misaligned.c</span><br><span>+++ b/src/arch/riscv/misaligned.c</span><br><span>@@ -160,7 +160,7 @@</span><br><span> static int fetch_32bit_instruction(uintptr_t vaddr, uintptr_t *insn, int *size)</span><br><span> {</span><br><span>      uint32_t l = (uint32_t)mprv_read_mxr_u16((uint16_t *)vaddr + 0);</span><br><span style="color: hsl(0, 100%, 40%);">-        uint32_t h = (uint32_t)mprv_read_mxr_u16((uint16_t *)vaddr + 2);</span><br><span style="color: hsl(120, 100%, 40%);">+      uint32_t h = (uint32_t)mprv_read_mxr_u16((uint16_t *)vaddr + 1);</span><br><span>     uint32_t ins = (h << 16) | l;</span><br><span>  if ((EXTRACT_FIELD(ins, 0x3) == 3) &&</span><br><span>                (EXTRACT_FIELD(ins, 0x1c) != 0x7)) {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29339">change 29339</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29339"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2986ca5402ad86d80e0eb955478bfbdc5d50e1f5 </div>
<div style="display:none"> Gerrit-Change-Number: 29339 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Philipp Hug <philipp@hug.cx> </div>