<p>Frans Hendriks has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29330">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/soc/intel/baytrail/southcluster.c: Replace fixed values by defines<br><br>The GPIO and ACPI base sizes have defines, but they are not used.<br>Use GPIO_BASE_SIZE and ACPI_BASE_SIZE.<br><br>BUG=N/A<br>TEST=Intel BayTrail CRB<br><br>Change-Id: I3fe50effdb8236bc45d33a2345a773653df68d90<br>Signed-off-by: Frans Hendriks <fhendriks@eltan.com><br>---<br>M src/soc/intel/baytrail/southcluster.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/29330/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/baytrail/southcluster.c b/src/soc/intel/baytrail/southcluster.c</span><br><span>index 0ef70d0..f44f502 100644</span><br><span>--- a/src/soc/intel/baytrail/southcluster.c</span><br><span>+++ b/src/soc/intel/baytrail/southcluster.c</span><br><span>@@ -3,6 +3,7 @@</span><br><span>  *</span><br><span>  * Copyright (C) 2008-2009 coresystems GmbH</span><br><span>  * Copyright (C) 2013 Google Inc.</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2018 Eltan B.V.</span><br><span>  *</span><br><span>  * This program is free software; you can redistribute it and/or modify</span><br><span>  * it under the terms of the GNU General Public License as published by</span><br><span>@@ -107,10 +108,10 @@</span><br><span>  res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;</span><br><span> </span><br><span>  /* GPIO */</span><br><span style="color: hsl(0, 100%, 40%);">-      sc_add_io_resource(dev, GPIO_BASE_ADDRESS, 256, GBASE);</span><br><span style="color: hsl(120, 100%, 40%);">+       sc_add_io_resource(dev, GPIO_BASE_ADDRESS, GPIO_BASE_SIZE, GBASE);</span><br><span> </span><br><span>       /* ACPI */</span><br><span style="color: hsl(0, 100%, 40%);">-      sc_add_io_resource(dev, ACPI_BASE_ADDRESS, 128, ABASE);</span><br><span style="color: hsl(120, 100%, 40%);">+       sc_add_io_resource(dev, ACPI_BASE_ADDRESS, ACPI_BASE_SIZE, ABASE);</span><br><span> }</span><br><span> </span><br><span> static void sc_read_resources(struct device *dev)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29330">change 29330</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29330"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3fe50effdb8236bc45d33a2345a773653df68d90 </div>
<div style="display:none"> Gerrit-Change-Number: 29330 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com> </div>