<p>Frans Hendriks has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29329">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/drivers/pc80/rtc/mc146818rtc.c: Reset RTC time on RTC power failure<br><br>RTC time contains invalid values on system without RTC battery<br>Add config to enable reset of RTC time when RTC power failure has been<br>detected.<br><br>BUG=N/A<br>TEST=Portwell PQ-M107<br><br>Change-Id: I5eae57d00f328400a8b03c28b7ecdbbc71522206<br>Signed-off-by: Frans Hendriks <fhendriks@eltan.com><br>---<br>M src/drivers/pc80/rtc/Kconfig<br>M src/drivers/pc80/rtc/mc146818rtc.c<br>2 files changed, 13 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/29329/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/pc80/rtc/Kconfig b/src/drivers/pc80/rtc/Kconfig</span><br><span>index 350863e..fd4675a4 100644</span><br><span>--- a/src/drivers/pc80/rtc/Kconfig</span><br><span>+++ b/src/drivers/pc80/rtc/Kconfig</span><br><span>@@ -2,3 +2,8 @@</span><br><span>       bool</span><br><span>         default y if ARCH_X86</span><br><span>        depends on PC80_SYSTEM</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config RESET_TIME_ON_RTC_POWERFAIL</span><br><span style="color: hsl(120, 100%, 40%);">+  bool</span><br><span style="color: hsl(120, 100%, 40%);">+  default n</span><br><span style="color: hsl(120, 100%, 40%);">+     depends on PC80_SYSTEM</span><br><span>diff --git a/src/drivers/pc80/rtc/mc146818rtc.c b/src/drivers/pc80/rtc/mc146818rtc.c</span><br><span>index 3b22a46..81d10cd 100644</span><br><span>--- a/src/drivers/pc80/rtc/mc146818rtc.c</span><br><span>+++ b/src/drivers/pc80/rtc/mc146818rtc.c</span><br><span>@@ -3,6 +3,7 @@</span><br><span>  *</span><br><span>  * Copyright 2014 The Chromium OS Authors. All rights reserved.</span><br><span>  * Copyright (C) 2015 Timothy Pearson <tpearson@raptorengineeringinc.com>, Raptor Engineering</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2018 Eltan B.V.</span><br><span>  *</span><br><span>  * This program is free software; you can redistribute it and/or modify</span><br><span>  * it under the terms of the GNU General Public License as published by</span><br><span>@@ -122,6 +123,13 @@</span><br><span>   x = cmos_read(RTC_VALID);</span><br><span>    cmos_invalid = !(x & RTC_VRT);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#if IS_ENABLED(CONFIG_RESET_TIME_ON_RTC_POWERFAIL)</span><br><span style="color: hsl(120, 100%, 40%);">+    if (invalid == true) {</span><br><span style="color: hsl(120, 100%, 40%);">+                cmos_invalid = true;</span><br><span style="color: hsl(120, 100%, 40%);">+          printk(BIOS_DEBUG, "Force cmos_invalid to true\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  if (IS_ENABLED(CONFIG_USE_OPTION_TABLE)) {</span><br><span>           /* See if there is a CMOS checksum error */</span><br><span>          checksum_invalid = !cmos_checksum_valid(PC_CKS_RANGE_START,</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29329">change 29329</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29329"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5eae57d00f328400a8b03c28b7ecdbbc71522206 </div>
<div style="display:none"> Gerrit-Change-Number: 29329 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com> </div>