<p>Jonathan Neuschäfer has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29336">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/sifive/hifive-unleashed: Use if (IS_ENABLED(...))<br><br>"if" is preferable over "#if", because it lets the compiler perform<br>syntax and type checks even if CONFIG_CONSOLE_SERIAL is disabled.<br><br>Change-Id: I45a763f2d854fbe9082795bc74de7a9d0fded3c9<br>Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net><br>---<br>M src/mainboard/sifive/hifive-unleashed/romstage.c<br>1 file changed, 1 insertion(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/29336/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/sifive/hifive-unleashed/romstage.c b/src/mainboard/sifive/hifive-unleashed/romstage.c</span><br><span>index 3767491..8277141 100644</span><br><span>--- a/src/mainboard/sifive/hifive-unleashed/romstage.c</span><br><span>+++ b/src/mainboard/sifive/hifive-unleashed/romstage.c</span><br><span>@@ -36,9 +36,8 @@</span><br><span>         clock_init();</span><br><span> </span><br><span>    // re-initialize UART</span><br><span style="color: hsl(0, 100%, 40%);">-   #if (IS_ENABLED(CONFIG_CONSOLE_SERIAL))</span><br><span style="color: hsl(120, 100%, 40%);">+       if (IS_ENABLED(CONFIG_CONSOLE_SERIAL))</span><br><span>               uart_init(CONFIG_UART_FOR_CONSOLE);</span><br><span style="color: hsl(0, 100%, 40%);">-     #endif</span><br><span> </span><br><span>   sdram_init();</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29336">change 29336</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29336"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I45a763f2d854fbe9082795bc74de7a9d0fded3c9 </div>
<div style="display:none"> Gerrit-Change-Number: 29336 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer@gmx.net> </div>