<p><a href="https://review.coreboot.org/29343">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29343/1/src/soc/amd/common/block/pi/agesawrapper.c">File src/soc/amd/common/block/pi/agesawrapper.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29343/1/src/soc/amd/common/block/pi/agesawrapper.c@328">Patch Set #1, Line 328:</a> <code style="font-family:monospace,monospace"> if (!dev->enabled</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">if (dev->enabled) ?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">nit: if(dev && dev->enabled)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29343/1/src/soc/amd/stoneyridge/northbridge.c">File src/soc/amd/stoneyridge/northbridge.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29343/1/src/soc/amd/stoneyridge/northbridge.c@513">Patch Set #1, Line 513:</a> <code style="font-family:monospace,monospace">dev->enabled</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">similar nit for dev=0.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29343">change 29343</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29343"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I6cfd6c81f47de23c54a49ec7cf87b219215ced5e </div>
<div style="display:none"> Gerrit-Change-Number: 29343 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marc Jones <marc@marcjonesconsulting.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 29 Oct 2018 23:29:55 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>