<p>Zhuohao Lee <strong>uploaded patch set #4</strong> to this change.</p><p><a href="https://review.coreboot.org/29191">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy: add the smi_events back<br><br>Before entering the OS, the AP relies on the smi handler to shutdown the<br>system when the lid closes. Without the smi_events setting, the AP will<br>not receive the smi handler. As a result, the AP won't shutdown and will<br>always keep in S0.<br>This problem is caused by the https://review.coreboot.org/c/coreboot/+/28983<br>and this patch adds the smi_events back to support the smi handler for<br>the lid close.<br><br>BRANCH=master<br>BUG=b:115572596<br>TEST=test_that -b ${BOARD} ${IP} firmware_ECLidShutdown<br><br>Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529<br>Signed-off-by: Zhuohao Lee <zhuohao@chromium.org><br>---<br>M src/mainboard/google/poppy/ec.c<br>M src/mainboard/google/poppy/variants/nocturne/ec.c<br>2 files changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/29191/4</pre><p>To view, visit <a href="https://review.coreboot.org/29191">change 29191</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29191"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>
<div style="display:none"> Gerrit-Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529 </div>
<div style="display:none"> Gerrit-Change-Number: 29191 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Zhuohao Lee <zhuohao@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Zhuohao Lee <zhuohao@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>