<p>Furquan Shaikh <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/29191">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Nick Vaccaro: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy: add the smi_events back<br><br>Before entering the OS, the AP relies on the smi handler to shutdown the<br>system when the lid closes. Without the smi_events setting, the AP will<br>not receive the smi handler. As a result, the AP won't shutdown and will<br>always keep in S0.<br>This problem is caused by the https://review.coreboot.org/c/coreboot/+/28983<br>and this patch adds the smi_events back to support the smi handler for<br>the lid close.<br><br>BRANCH=master<br>BUG=b:115572596<br>TEST=test_that -b ${BOARD} ${IP} firmware_ECLidShutdown<br><br>Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529<br>Signed-off-by: Zhuohao Lee <zhuohao@chromium.org><br>Reviewed-on: https://review.coreboot.org/29191<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Furquan Shaikh <furquan@google.com><br>Reviewed-by: Nick Vaccaro <nvaccaro@google.com><br>---<br>M src/mainboard/google/poppy/ec.c<br>M src/mainboard/google/poppy/variants/nocturne/ec.c<br>2 files changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/ec.c b/src/mainboard/google/poppy/ec.c</span><br><span>index 71327be..a93bf19 100644</span><br><span>--- a/src/mainboard/google/poppy/ec.c</span><br><span>+++ b/src/mainboard/google/poppy/ec.c</span><br><span>@@ -24,6 +24,7 @@</span><br><span>  static const struct google_chromeec_event_info info = {</span><br><span>              .log_events = MAINBOARD_EC_LOG_EVENTS,</span><br><span>               .sci_events = MAINBOARD_EC_SCI_EVENTS,</span><br><span style="color: hsl(120, 100%, 40%);">+                .smi_events = MAINBOARD_EC_SMI_EVENTS,</span><br><span>               .s3_wake_events = MAINBOARD_EC_S3_WAKE_EVENTS,</span><br><span>               .s5_wake_events = MAINBOARD_EC_S5_WAKE_EVENTS,</span><br><span>               .s0ix_wake_events = MAINBOARD_EC_S0IX_WAKE_EVENTS,</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/ec.c b/src/mainboard/google/poppy/variants/nocturne/ec.c</span><br><span>index 3e187fc..76d80d2 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/ec.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/ec.c</span><br><span>@@ -25,6 +25,7 @@</span><br><span>      static struct google_chromeec_event_info info = {</span><br><span>            .log_events = MAINBOARD_EC_LOG_EVENTS,</span><br><span>               .sci_events = MAINBOARD_EC_SCI_EVENTS,</span><br><span style="color: hsl(120, 100%, 40%);">+                .smi_events = MAINBOARD_EC_SMI_EVENTS,</span><br><span>               .s3_wake_events = MAINBOARD_EC_S3_WAKE_EVENTS,</span><br><span>               .s5_wake_events = MAINBOARD_EC_S5_WAKE_EVENTS,</span><br><span>               .s0ix_wake_events = MAINBOARD_EC_S0IX_WAKE_EVENTS,</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29191">change 29191</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29191"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529 </div>
<div style="display:none"> Gerrit-Change-Number: 29191 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Zhuohao Lee <zhuohao@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Zhuohao Lee <zhuohao@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>