<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29246">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd/common/def_callouts.c: Prefer using '"%s...", __func__'<br><br>In function agesa_GfxGetVbiosImage(), the function name is used in a print<br>string. Use __func__ instead.<br><br>BUG=b:117642170<br>TEST=Build grunt.<br><br>Change-Id: I95a042bd95cc729305a8a008e3bb464f60c2668d<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/soc/amd/common/block/pi/def_callouts.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/29246/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/common/block/pi/def_callouts.c b/src/soc/amd/common/block/pi/def_callouts.c</span><br><span>index d136084..2da00cb 100644</span><br><span>--- a/src/soc/amd/common/block/pi/def_callouts.c</span><br><span>+++ b/src/soc/amd/common/block/pi/def_callouts.c</span><br><span>@@ -152,8 +152,8 @@</span><br><span>        pVbiosImageInfo->ImagePtr = cbfs_boot_map_with_leak(</span><br><span>                      "pci"CONFIG_VGA_BIOS_ID".rom",</span><br><span>                   CBFS_TYPE_OPTIONROM, NULL);</span><br><span style="color: hsl(0, 100%, 40%);">-     printk(BIOS_DEBUG, "agesa_GfxGetVbiosImage: IMGptr=%p\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                                             pVbiosImageInfo->ImagePtr);</span><br><span style="color: hsl(120, 100%, 40%);">+        printk(BIOS_DEBUG, "%s: IMGptr=%p\n", __func__,</span><br><span style="color: hsl(120, 100%, 40%);">+                         pVbiosImageInfo->ImagePtr);</span><br><span>   return pVbiosImageInfo->ImagePtr ? AGESA_SUCCESS : AGESA_WARNING;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29246">change 29246</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29246"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I95a042bd95cc729305a8a008e3bb464f60c2668d </div>
<div style="display:none"> Gerrit-Change-Number: 29246 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>