<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29199">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/common/block/gpio: Configure Tx Disable in IO standby for GPIs<br><br>This change updates various PAD_CFG_GPI* macros to configure Tx as<br>Disabled in IO Standby state. This is done to ensure that the Tx<br>setting is same in IO Standby state as it was in active state i.e. Tx<br>disabled.<br><br>BUG=b:17553222<br><br>Change-Id: If462aee3884cc61a519fb358b84867c695ace251<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/soc/intel/common/block/include/intelblocks/gpio_defs.h<br>1 file changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/29199/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h</span><br><span>index 855659a..ae6bbfc 100644</span><br><span>--- a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h</span><br><span>+++ b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h</span><br><span>@@ -196,7 +196,7 @@</span><br><span> #define PAD_CFG_GPI(pad, pull, rst) \</span><br><span> _PAD_CFG_STRUCT(pad, \</span><br><span> PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_CFG0_TX_DISABLE, \</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_PULL(pull) | PAD_IOSSTATE(TxLASTRxE))</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_PULL(pull) | PAD_IOSSTATE(TxDRxE))</span><br><span> </span><br><span> /* General purpose input. The following macro sets the</span><br><span> * Host Software Pad Ownership to GPIO Driver mode.</span><br><span>@@ -204,7 +204,7 @@</span><br><span> #define PAD_CFG_GPI_GPIO_DRIVER(pad, pull, rst) \</span><br><span> _PAD_CFG_STRUCT(pad, \</span><br><span> PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_CFG0_TX_DISABLE, \</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_PULL(pull) | PAD_CFG1_GPIO_DRIVER | PAD_IOSSTATE(TxLASTRxE))</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_PULL(pull) | PAD_CFG1_GPIO_DRIVER | PAD_IOSSTATE(TxDRxE))</span><br><span> </span><br><span> #define PAD_CFG_GPIO_DRIVER_HI_Z(pad, pull, rst, iosstate, iosterm) \</span><br><span> _PAD_CFG_STRUCT(pad, \</span><br><span>@@ -224,7 +224,7 @@</span><br><span> _PAD_CFG_STRUCT(pad, \</span><br><span> PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_CFG0_TX_DISABLE | \</span><br><span> PAD_CFG0_TRIG_##trig | PAD_CFG0_RX_POL_NONE, \</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_PULL(pull) | PAD_CFG1_GPIO_DRIVER | PAD_IOSSTATE(TxLASTRxE))</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_PULL(pull) | PAD_CFG1_GPIO_DRIVER | PAD_IOSSTATE(TxDRxE))</span><br><span> </span><br><span> /* No Connect configuration for unused pad.</span><br><span> * NC should be GPI with Term as PU20K, PD20K, NONE depending upon default Term</span><br><span>@@ -263,7 +263,7 @@</span><br><span> _PAD_CFG_STRUCT(pad, \</span><br><span> PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_CFG0_TX_DISABLE | \</span><br><span> PAD_IRQ_CFG(IOAPIC, trig, inv), PAD_PULL(pull) | \</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_IOSSTATE(TxLASTRxE))</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_IOSSTATE(TxDRxE))</span><br><span> #endif</span><br><span> </span><br><span> /* General purpose input, routed to APIC - with IOStandby Config*/</span><br><span>@@ -292,7 +292,7 @@</span><br><span> _PAD_CFG_STRUCT(pad, \</span><br><span> PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_CFG0_TX_DISABLE | \</span><br><span> PAD_IRQ_CFG(SMI, trig, inv), PAD_PULL(pull) | \</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_IOSSTATE(TxLASTRxE))</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_IOSSTATE(TxDRxE))</span><br><span> </span><br><span> /* General purpose input, routed to SMI */</span><br><span> #define PAD_CFG_GPI_SMI_IOS(pad, pull, rst, trig, inv, iosstate, iosterm) \</span><br><span>@@ -312,7 +312,7 @@</span><br><span> _PAD_CFG_STRUCT(pad, \</span><br><span> PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_CFG0_TX_DISABLE | \</span><br><span> PAD_IRQ_CFG(SCI, trig, inv), PAD_PULL(pull) | \</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_IOSSTATE(TxLASTRxE))</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_IOSSTATE(TxDRxE))</span><br><span> </span><br><span> /* General purpose input, routed to SCI */</span><br><span> #define PAD_CFG_GPI_SCI_IOS(pad, pull, rst, trig, inv, iosstate, iosterm) \</span><br><span>@@ -332,6 +332,6 @@</span><br><span> _PAD_CFG_STRUCT(pad, \</span><br><span> PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_CFG0_TX_DISABLE | \</span><br><span> PAD_IRQ_CFG(NMI, trig, inv), PAD_PULL(pull) | \</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_IOSSTATE(TxLASTRxE))</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_IOSSTATE(TxDRxE))</span><br><span> </span><br><span> #endif /* _SOC_BLOCK_GPIO_DEFS_H_ */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29199">change 29199</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29199"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If462aee3884cc61a519fb358b84867c695ace251 </div>
<div style="display:none"> Gerrit-Change-Number: 29199 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>