<p><a href="https://review.coreboot.org/29164">View Change</a></p><p>12 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/chromeos.c">File src/mainboard/intel/icelake_rvp/chromeos.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/chromeos.c@42">Patch Set #4, Line 42:</a> <code style="font-family:monospace,monospace">        /* Lid always open */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/chromeos.c@43">Patch Set #4, Line 43:</a> <code style="font-family:monospace,monospace">        return 1;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/chromeos.c@43">Patch Set #4, Line 43:</a> <code style="font-family:monospace,monospace">        return 1;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/chromeos.c@48">Patch Set #4, Line 48:</a> <code style="font-family:monospace,monospace">        return 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/chromeos.c@48">Patch Set #4, Line 48:</a> <code style="font-family:monospace,monospace">        return 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/spd/spd_util.c">File src/mainboard/intel/icelake_rvp/spd/spd_util.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/spd/spd_util.c@26">Patch Set #4, Line 26:</a> <code style="font-family:monospace,monospace">               0x0F, 0xF0, 0x0F, 0xF0, 0xFF, 0x00 ,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxE)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c">File src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c@314">Patch Set #4, Line 314:</a> <code style="font-family:monospace,monospace">        CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c@314">Patch Set #4, Line 314:</a> <code style="font-family:monospace,monospace">        CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c@319">Patch Set #4, Line 319:</a> <code style="font-family:monospace,monospace">        *num = ARRAY_SIZE(cros_gpios);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c@319">Patch Set #4, Line 319:</a> <code style="font-family:monospace,monospace">        *num = ARRAY_SIZE(cros_gpios);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c@320">Patch Set #4, Line 320:</a> <code style="font-family:monospace,monospace">        return cros_gpios;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29164/4/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c@320">Patch Set #4, Line 320:</a> <code style="font-family:monospace,monospace">        return cros_gpios;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29164">change 29164</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29164"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I875972d1fb2f630bf5eb29bd955c484e7f9aa415 </div>
<div style="display:none"> Gerrit-Change-Number: 29164 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 19 Oct 2018 04:56:50 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>