<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/29167">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/inteltool: Fix LynxPoint (non-LP) GPIO register map<br><br>The GPIO register dumper code for the LynxPoint family PCH chips<br>(Intel 8 Series and C220 Series) was incorrectly using a<br>shortened version of the LynxPoint-LP GPIO register map.<br>Switched to the correct register map for the affected chipsets.<br><br>Change-Id: I394a198bbb6628915cb73cabc5c8ff808579a07f<br>Signed-off-by: Fehér Roland Ádám <feherneoh@gmail.com><br>Reviewed-on: https://review.coreboot.org/29167<br>Reviewed-by: Nico Huber <nico.h@gmx.de><br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>---<br>M util/inteltool/gpio.c<br>1 file changed, 2 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/inteltool/gpio.c b/util/inteltool/gpio.c</span><br><span>index c38051c..b4225a7 100644</span><br><span>--- a/util/inteltool/gpio.c</span><br><span>+++ b/util/inteltool/gpio.c</span><br><span>@@ -869,9 +869,8 @@</span><br><span>       case PCI_DEVICE_ID_INTEL_C226:</span><br><span>       case PCI_DEVICE_ID_INTEL_H81:</span><br><span>                gpiobase = pci_read_word(sb, 0x48) & 0xfffc;</span><br><span style="color: hsl(0, 100%, 40%);">-                gpio_registers = lynxpoint_lp_gpio_registers;</span><br><span style="color: hsl(0, 100%, 40%);">-           /* Shares register locations but has less of them */</span><br><span style="color: hsl(0, 100%, 40%);">-            size = 29;</span><br><span style="color: hsl(120, 100%, 40%);">+            gpio_registers = pch_gpio_registers;</span><br><span style="color: hsl(120, 100%, 40%);">+          size = ARRAY_SIZE(pch_gpio_registers);</span><br><span>               break;</span><br><span>       case PCI_DEVICE_ID_INTEL_3400:</span><br><span>       case PCI_DEVICE_ID_INTEL_3420:</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29167">change 29167</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29167"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I394a198bbb6628915cb73cabc5c8ff808579a07f </div>
<div style="display:none"> Gerrit-Change-Number: 29167 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Roland Fehér <feherneoh@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Roland Fehér <feherneoh@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>