<p>Nico Huber <strong>uploaded patch set #2</strong> to this change.</p><p><a href="https://review.coreboot.org/29169">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">intel: Use CF9 reset (part 2)<br><br>Make use of the common CF9 reset in SOC_INTEL_COMMON_RESET. Also<br>implement board_reset() as a "full reset" (aka. cold reset) as that<br>is what was used here for hard_reset().<br><br>We leave some comments to remind us that a system_reset() should<br>be enough, where a full_reset() is called now to retain current<br>behaviour.<br><br>Note, as no global_reset() is implemented for Denverton-NS, we halt<br>there now instead of issuing a non-global reset. This seems safer;<br>a non-global reset might result in a reset loop.<br><br>Change-Id: I5e7025c3c9ea6ded18e72037412b60a1df31bd53<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M src/drivers/intel/fsp1_1/raminit.c<br>M src/drivers/intel/fsp1_1/romstage.c<br>M src/drivers/intel/fsp2_0/memory_init.c<br>M src/drivers/intel/fsp2_0/util.c<br>D src/include/cpu/intel/reset.h<br>M src/include/reset.h<br>M src/lib/reset.c<br>M src/soc/intel/apollolake/Kconfig<br>M src/soc/intel/apollolake/reset.c<br>M src/soc/intel/apollolake/romstage.c<br>M src/soc/intel/braswell/Kconfig<br>M src/soc/intel/cannonlake/Kconfig<br>M src/soc/intel/cannonlake/reset.c<br>M src/soc/intel/common/Kconfig<br>M src/soc/intel/common/block/acpi/acpi.c<br>M src/soc/intel/common/reset.c<br>M src/soc/intel/denverton_ns/Kconfig<br>M src/soc/intel/denverton_ns/reset.c<br>M src/soc/intel/denverton_ns/romstage.c<br>M src/soc/intel/quark/Kconfig<br>M src/soc/intel/quark/reset.c<br>M src/soc/intel/skylake/Kconfig<br>M src/soc/intel/skylake/reset.c<br>23 files changed, 52 insertions(+), 106 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/29169/2</pre><p>To view, visit <a href="https://review.coreboot.org/29169">change 29169</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29169"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>
<div style="display:none"> Gerrit-Change-Id: I5e7025c3c9ea6ded18e72037412b60a1df31bd53 </div>
<div style="display:none"> Gerrit-Change-Number: 29169 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>