<p><a href="https://review.coreboot.org/29162">View Change</a></p><p>9 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29162/1/src/soc/intel/icelake/acpi.c">File src/soc/intel/icelake/acpi.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29162/1/src/soc/intel/icelake/acpi.c@208">Patch Set #1, Line 208:</a> <code style="font-family:monospace,monospace"> if (IS_ENABLED(CONFIG_CONSOLE_CBMEM))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (8, 8)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29162/1/src/soc/intel/icelake/bootblock/pch.c">File src/soc/intel/icelake/bootblock/pch.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29162/1/src/soc/intel/icelake/bootblock/pch.c@53">Patch Set #1, Line 53:</a> <code style="font-family:monospace,monospace">#define TCOEN (1 << 1) /* Enable TCO I/O range decode. */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29162/1/src/soc/intel/icelake/bootblock/pch.c@124">Patch Set #1, Line 124:</a> <code style="font-family:monospace,monospace"> if (pmc_reg_value != 0xFFFFFFFF)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">that open brace { should be on the previous line</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29162/1/src/soc/intel/icelake/bootblock/report_platform.c">File src/soc/intel/icelake/bootblock/report_platform.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29162/1/src/soc/intel/icelake/bootblock/report_platform.c@104">Patch Set #1, Line 104:</a> <code style="font-family:monospace,monospace"> int j=0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces required around that '=' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29162/1/src/soc/intel/icelake/bootblock/report_platform.c@113">Patch Set #1, Line 113:</a> <code style="font-family:monospace,monospace"> p[12]=0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces required around that '=' (ctx:VxV)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29162/1/src/soc/intel/icelake/cbmem.c">File src/soc/intel/icelake/cbmem.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29162/1/src/soc/intel/icelake/cbmem.c@20">Patch Set #1, Line 20:</a> <code style="font-family:monospace,monospace"> /* not implemented yet */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29162/1/src/soc/intel/icelake/include/soc/romstage.h">File src/soc/intel/icelake/include/soc/romstage.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29162/1/src/soc/intel/icelake/include/soc/romstage.h@22">Patch Set #1, Line 22:</a> <code style="font-family:monospace,monospace">void mainboard_memory_init_params(FSPM_UPD *mupd);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">need consistent spacing around '*' (ctx:WxV)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29162/1/src/soc/intel/icelake/sd.c">File src/soc/intel/icelake/sd.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29162/1/src/soc/intel/icelake/sd.c@19">Patch Set #1, Line 19:</a> <code style="font-family:monospace,monospace">int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, struct device *dev)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29162/1/src/soc/intel/icelake/smihandler.c">File src/soc/intel/icelake/smihandler.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29162/1/src/soc/intel/icelake/smihandler.c@83">Patch Set #1, Line 83:</a> <code style="font-family:monospace,monospace"> return ;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before semicolon</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29162">change 29162</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29162"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I756fa7275c4190aebc0695f14484498aaf5662a5 </div>
<div style="display:none"> Gerrit-Change-Number: 29162 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 17 Oct 2018 12:58:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>