<p><a href="https://review.coreboot.org/29161">View Change</a></p><p>150 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/amd/family_10h-family_15h/fidvid.c">File src/cpu/amd/family_10h-family_15h/fidvid.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/amd/family_10h-family_15h/fidvid.c@173">Patch Set #1, Line 173:</a> <code style="font-family:monospace,monospace"> if (nbPState){</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open brace '{'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/amd/family_10h-family_15h/fidvid.c@178">Patch Set #1, Line 178:</a> <code style="font-family:monospace,monospace"> if (msr.hi & PS_EN_MASK) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (32, 32)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/amd/family_10h-family_15h/fidvid.c@383">Patch Set #1, Line 383:</a> <code style="font-family:monospace,monospace"> if (AMD_CpuFindCapability(node, 0, &offset)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (8, 10)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/amd/family_10h-family_15h/fidvid.c@415">Patch Set #1, Line 415:</a> <code style="font-family:monospace,monospace"> for (j=0; (j<4) && (!isocEn); j++) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces required around that '=' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/amd/family_10h-family_15h/fidvid.c@415">Patch Set #1, Line 415:</a> <code style="font-family:monospace,monospace"> for (j=0; (j<4) && (!isocEn); j++) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces required around that '<' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/amd/family_10h-family_15h/fidvid.c@498">Patch Set #1, Line 498:</a> <code style="font-family:monospace,monospace"> if (cpuRev & (AMD_DA_Cx | AMD_RB_C3)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/amd/family_10h-family_15h/fidvid.c@503">Patch Set #1, Line 503:</a> <code style="font-family:monospace,monospace"> if ((procPkg == AMD_PKGTYPE_G34) || (procPkg == AMD_PKGTYPE_C32)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/amd/family_10h-family_15h/fidvid.c@666">Patch Set #1, Line 666:</a> <code style="font-family:monospace,monospace"> if ((((u32)0xffffffff) - initial_msr.lo) < corrected_timeout) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/amd/family_10h-family_15h/fidvid.c@675">Patch Set #1, Line 675:</a> <code style="font-family:monospace,monospace"> || ((tsc_msr.hi == timeout.hi) && (tsc_msr.lo > timeout.lo));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/amd/family_10h-family_15h/fidvid.c@676">Patch Set #1, Line 676:</a> <code style="font-family:monospace,monospace"> } while ((pstate_msr.lo != target_pstate) && (! timedout));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited after that '!' (ctx:BxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/amd/family_10h-family_15h/fidvid.c@685">Patch Set #1, Line 685:</a> <code style="font-family:monospace,monospace"> } while (pstate_msr.lo != target_pstate );</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that close parenthesis ')'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/amd/family_10h-family_15h/fidvid.c@842">Patch Set #1, Line 842:</a> <code style="font-family:monospace,monospace"> vid_max = (reg1fc & SINGLE_PLANE_NB_VID_MASK) >> SINGLE_PLANE_NB_VID_SHIFT;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/amd/family_10h-family_15h/fidvid.c@843">Patch Set #1, Line 843:</a> <code style="font-family:monospace,monospace"> fid_max = (reg1fc & SINGLE_PLANE_NB_FID_MASK) >> SINGLE_PLANE_NB_FID_SHIFT;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/amd/family_10h-family_15h/fidvid.c@846">Patch Set #1, Line 846:</a> <code style="font-family:monospace,monospace"> vid_max = vid_max - ((reg1fc & DUAL_PLANE_NB_VID_OFF_MASK) >> DUAL_PLANE_NB_VID_SHIFT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/amd/family_10h-family_15h/fidvid.c@847">Patch Set #1, Line 847:</a> <code style="font-family:monospace,monospace"> fid_max = fid_max + ((reg1fc & DUAL_PLANE_NB_FID_OFF_MASK) >> DUAL_PLANE_NB_FID_SHIFT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/amd/family_10h-family_15h/fidvid.c@951">Patch Set #1, Line 951:</a> <code style="font-family:monospace,monospace"> if ( (msr.hi & PS_IDD_VALUE_MASK)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited after that open parenthesis '('</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/via/nano/nano_init.c">File src/cpu/via/nano/nano_init.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/via/nano/nano_init.c@120">Patch Set #1, Line 120:</a> <code style="font-family:monospace,monospace"> u8 stepping = (cpuid_eax(0x1)) &0xf;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">need consistent spacing around '&' (ctx:WxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/cpu/via/nano/nano_init.c@125">Patch Set #1, Line 125:</a> <code style="font-family:monospace,monospace"> msr.lo |= ((1 << 25) | (1 << 26) | (1 << 31)); /* C1e, C2e, C3e */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c">File src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c@71">Patch Set #1, Line 71:</a> <code style="font-family:monospace,monospace"> if(!(sysconf.pci1234[i] & 0x1)) continue;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c@71">Patch Set #1, Line 71:</a> <code style="font-family:monospace,monospace"> if(!(sysconf.pci1234[i] & 0x1)) continue;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing statements should be on next line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c@108">Patch Set #1, Line 108:</a> <code style="font-family:monospace,monospace"> current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *) current, 0, 0, 2, 5);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c@140">Patch Set #1, Line 140:</a> <code style="font-family:monospace,monospace"> if((sysconf.pci1234[i] & 1) != 1) continue;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c@140">Patch Set #1, Line 140:</a> <code style="font-family:monospace,monospace"> if((sysconf.pci1234[i] & 1) != 1) continue;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing statements should be on next line</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/amd/serengeti_cheetah_fam10/get_bus_conf.c">File src/mainboard/amd/serengeti_cheetah_fam10/get_bus_conf.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/amd/serengeti_cheetah_fam10/get_bus_conf.c@148">Patch Set #1, Line 148:</a> <code style="font-family:monospace,monospace"> if(!(sysconf.pci1234[i] & 0x1)) continue;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/amd/serengeti_cheetah_fam10/get_bus_conf.c@148">Patch Set #1, Line 148:</a> <code style="font-family:monospace,monospace"> if(!(sysconf.pci1234[i] & 0x1)) continue;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing statements should be on next line</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/amd/serengeti_cheetah_fam10/mptable.c">File src/mainboard/amd/serengeti_cheetah_fam10/mptable.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/amd/serengeti_cheetah_fam10/mptable.c@71">Patch Set #1, Line 71:</a> <code style="font-family:monospace,monospace"> if(!(sysconf.pci1234[i] & 0x1)) continue;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/amd/serengeti_cheetah_fam10/mptable.c@71">Patch Set #1, Line 71:</a> <code style="font-family:monospace,monospace"> if(!(sysconf.pci1234[i] & 0x1)) continue;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing statements should be on next line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/amd/serengeti_cheetah_fam10/mptable.c@134">Patch Set #1, Line 134:</a> <code style="font-family:monospace,monospace"> if(!(sysconf.pci1234[i] & 0x1)) continue;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/amd/serengeti_cheetah_fam10/mptable.c@134">Patch Set #1, Line 134:</a> <code style="font-family:monospace,monospace"> if(!(sysconf.pci1234[i] & 0x1)) continue;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing statements should be on next line</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/amd/torpedo/gpio.c">File src/mainboard/amd/torpedo/gpio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/amd/torpedo/gpio.c@94">Patch Set #1, Line 94:</a> <code style="font-family:monospace,monospace"> if (BoardType == 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c">File src/mainboard/biostar/am1ml/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@62">Patch Set #1, Line 62:</a> <code style="font-family:monospace,monospace"> it_sio_write(dev, 0xf1 , 0x40);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@63">Patch Set #1, Line 63:</a> <code style="font-family:monospace,monospace"> it_sio_write(dev, 0xf4 , 0x80);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@64">Patch Set #1, Line 64:</a> <code style="font-family:monospace,monospace"> it_sio_write(dev, 0xf5 , 0x00);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@65">Patch Set #1, Line 65:</a> <code style="font-family:monospace,monospace"> it_sio_write(dev, 0xf6 , 0xf0);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@66">Patch Set #1, Line 66:</a> <code style="font-family:monospace,monospace"> it_sio_write(dev, 0xf9 , 0x48);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@67">Patch Set #1, Line 67:</a> <code style="font-family:monospace,monospace"> it_sio_write(dev, 0xfa , 0x00);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@68">Patch Set #1, Line 68:</a> <code style="font-family:monospace,monospace"> it_sio_write(dev, 0xfb , 0x00);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@75">Patch Set #1, Line 75:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0x25 , 0x80);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@75">Patch Set #1, Line 75:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0x25 , 0x80);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@76">Patch Set #1, Line 76:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0x26 , 0x07);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@76">Patch Set #1, Line 76:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0x26 , 0x07);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@77">Patch Set #1, Line 77:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0x28 , 0x81);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@77">Patch Set #1, Line 77:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0x28 , 0x81);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@78">Patch Set #1, Line 78:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0x2c , 0x06);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@78">Patch Set #1, Line 78:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0x2c , 0x06);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@79">Patch Set #1, Line 79:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0x72 , 0x00);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@79">Patch Set #1, Line 79:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0x72 , 0x00);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@80">Patch Set #1, Line 80:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0x73 , 0x00);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@80">Patch Set #1, Line 80:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0x73 , 0x00);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@81">Patch Set #1, Line 81:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xb3 , 0x01);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@81">Patch Set #1, Line 81:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xb3 , 0x01);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@82">Patch Set #1, Line 82:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xb8 , 0x00);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@82">Patch Set #1, Line 82:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xb8 , 0x00);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@83">Patch Set #1, Line 83:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xc0 , 0x00);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@83">Patch Set #1, Line 83:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xc0 , 0x00);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@84">Patch Set #1, Line 84:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xc3 , 0x00);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@84">Patch Set #1, Line 84:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xc3 , 0x00);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@85">Patch Set #1, Line 85:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xc8 , 0x00);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@85">Patch Set #1, Line 85:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xc8 , 0x00);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@86">Patch Set #1, Line 86:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xc9 , 0x07);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@86">Patch Set #1, Line 86:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xc9 , 0x07);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@87">Patch Set #1, Line 87:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xcb , 0x01);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@87">Patch Set #1, Line 87:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xcb , 0x01);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@88">Patch Set #1, Line 88:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xf0 , 0x10);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@88">Patch Set #1, Line 88:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xf0 , 0x10);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@89">Patch Set #1, Line 89:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xf4 , 0x27);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@89">Patch Set #1, Line 89:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xf4 , 0x27);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@90">Patch Set #1, Line 90:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xf8 , 0x20);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@90">Patch Set #1, Line 90:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xf8 , 0x20);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@91">Patch Set #1, Line 91:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xf9 , 0x01);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/biostar/am1ml/romstage.c@91">Patch Set #1, Line 91:</a> <code style="font-family:monospace,monospace"> it_sio_write (dev, 0xf9 , 0x01);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/gizmosphere/gizmo/OemCustomize.c">File src/mainboard/gizmosphere/gizmo/OemCustomize.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/gizmosphere/gizmo/OemCustomize.c@126">Patch Set #1, Line 126:</a> <code style="font-family:monospace,monospace"> HW_RXEN_SEED(ANY_SOCKET, ANY_CHANNEL, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lenovo/t60/smihandler.c">File src/mainboard/lenovo/t60/smihandler.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lenovo/t60/smihandler.c@52">Patch Set #1, Line 52:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "bar: %08X, level %02X\n", (unsigned int)bar, *(bar+LVTMA_BL_MOD_LEVEL));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lenovo/z61t/smihandler.c">File src/mainboard/lenovo/z61t/smihandler.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lenovo/z61t/smihandler.c@53">Patch Set #1, Line 53:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "bar: %08X, level %02X\n", (unsigned int)bar,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lippert/frontrunner-af/mainboard.c">File src/mainboard/lippert/frontrunner-af/mainboard.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lippert/frontrunner-af/mainboard.c@68">Patch Set #1, Line 68:</a> <code style="font-family:monospace,monospace"> FCH_IOMUX(50) = 2; // GPIO50: FCH_ARST#_GATE resets stuck PCIe devices</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lippert/frontrunner-af/mainboard.c@69">Patch Set #1, Line 69:</a> <code style="font-family:monospace,monospace"> FCH_GPIO (50) = 0xC0; // = output set to 1 as it's never needed</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lippert/frontrunner-af/mainboard.c@72">Patch Set #1, Line 72:</a> <code style="font-family:monospace,monospace"> FCH_GPIO (56) = 0x28; // = inputs, disable int. pull-ups</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lippert/frontrunner-af/mainboard.c@74">Patch Set #1, Line 74:</a> <code style="font-family:monospace,monospace"> FCH_GPIO (57) = 0x28;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lippert/frontrunner-af/mainboard.c@76">Patch Set #1, Line 76:</a> <code style="font-family:monospace,monospace"> FCH_GPIO (58) = 0x28;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lippert/frontrunner-af/mainboard.c@77">Patch Set #1, Line 77:</a> <code style="font-family:monospace,monospace"> FCH_IOMUX(96) = 1; // "Gpio96": GEVENT0# signal on X2 connector (int. PU)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lippert/frontrunner-af/mainboard.c@78">Patch Set #1, Line 78:</a> <code style="font-family:monospace,monospace"> FCH_IOMUX(52) = 1; // GPIO52,61,62,187-192 free to use on X2 connector</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lippert/toucan-af/mainboard.c">File src/mainboard/lippert/toucan-af/mainboard.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lippert/toucan-af/mainboard.c@36">Patch Set #1, Line 36:</a> <code style="font-family:monospace,monospace"> FCH_IOMUX(50) = 2; // GPIO50: FCH_ARST#_GATE resets stuck PCIe devices</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lippert/toucan-af/mainboard.c@37">Patch Set #1, Line 37:</a> <code style="font-family:monospace,monospace"> FCH_GPIO (50) = 0xC0; // = output set to 1 as it's never needed</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lippert/toucan-af/mainboard.c@41">Patch Set #1, Line 41:</a> <code style="font-family:monospace,monospace"> FCH_GPIO (56) = 0x28; // = inputs, disable int. pull-ups</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lippert/toucan-af/mainboard.c@43">Patch Set #1, Line 43:</a> <code style="font-family:monospace,monospace"> FCH_GPIO (57) = 0x28;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/lippert/toucan-af/mainboard.c@45">Patch Set #1, Line 45:</a> <code style="font-family:monospace,monospace"> FCH_GPIO (58) = 0x28;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/msi/ms9652_fam10/get_bus_conf.c">File src/mainboard/msi/ms9652_fam10/get_bus_conf.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/msi/ms9652_fam10/get_bus_conf.c@109">Patch Set #1, Line 109:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:%02x.0, using defaults\n", m->bus_mcp55[0], sysconf.sbdn + 0x0a + i - 2);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/pcengines/apu1/OemCustomize.c">File src/mainboard/pcengines/apu1/OemCustomize.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/pcengines/apu1/OemCustomize.c@111">Patch Set #1, Line 111:</a> <code style="font-family:monospace,monospace"> HW_RXEN_SEED(ANY_SOCKET, ANY_CHANNEL, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/pcengines/apu2/mainboard.c">File src/mainboard/pcengines/apu2/mainboard.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/pcengines/apu2/mainboard.c@170">Patch Set #1, Line 170:</a> <code style="font-family:monospace,monospace"> pm_write16 (PM_RTC_CONTROL, pm_read16(PM_RTC_CONTROL) | (1 << 11));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/pcengines/apu2/mainboard.c@175">Patch Set #1, Line 175:</a> <code style="font-family:monospace,monospace"> pm_write16 (PM_S_STATE_CONTROL, pm_read16(PM_S_STATE_CONTROL) | (1 << 14));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/pcengines/apu2/mainboard.c@175">Patch Set #1, Line 175:</a> <code style="font-family:monospace,monospace"> pm_write16 (PM_S_STATE_CONTROL, pm_read16(PM_S_STATE_CONTROL) | (1 << 14));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/supermicro/h8dmr_fam10/get_bus_conf.c">File src/mainboard/supermicro/h8dmr_fam10/get_bus_conf.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/supermicro/h8dmr_fam10/get_bus_conf.c@107">Patch Set #1, Line 107:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:%02x.0, using defaults\n", m->bus_mcp55[0], sysconf.sbdn + 0x0a + i - 2);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/supermicro/h8qme_fam10/get_bus_conf.c">File src/mainboard/supermicro/h8qme_fam10/get_bus_conf.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/supermicro/h8qme_fam10/get_bus_conf.c@113">Patch Set #1, Line 113:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:%02x.0, using defaults\n", m->bus_mcp55[0], sysconf.sbdn + 0x0a + i - 2);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/tyan/s2912_fam10/get_bus_conf.c">File src/mainboard/tyan/s2912_fam10/get_bus_conf.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/mainboard/tyan/s2912_fam10/get_bus_conf.c@106">Patch Set #1, Line 106:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:%02x.0, using defaults\n", m->bus_mcp55[0], sysconf.sbdn + 0x0a + i - 2);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/northbridge/amd/agesa/family12/dimmSpd.c">File src/northbridge/amd/agesa/family12/dimmSpd.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/northbridge/amd/agesa/family12/dimmSpd.c@58">Patch Set #1, Line 58:</a> <code style="font-family:monospace,monospace"> )</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/northbridge/amd/pi/00730F01/dimmSpd.c">File src/northbridge/amd/pi/00730F01/dimmSpd.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/northbridge/amd/pi/00730F01/dimmSpd.c@37">Patch Set #1, Line 37:</a> <code style="font-family:monospace,monospace"> if (info->SocketId >= DIMENSION(config->spdAddrLookup ))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that close parenthesis ')'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/northbridge/amd/pi/00730F01/dimmSpd.c@39">Patch Set #1, Line 39:</a> <code style="font-family:monospace,monospace"> if (info->MemChannelId >= DIMENSION(config->spdAddrLookup[0] ))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that close parenthesis ')'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/northbridge/intel/e7505/debug.c">File src/northbridge/intel/e7505/debug.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/northbridge/intel/e7505/debug.c@151">Patch Set #1, Line 151:</a> <code style="font-family:monospace,monospace"> if (spd_read_byte(device, 0) < 0) continue;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing statements should be on next line</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/northbridge/intel/fsp_rangeley/northbridge.c">File src/northbridge/intel/fsp_rangeley/northbridge.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/northbridge/intel/fsp_rangeley/northbridge.c@134">Patch Set #1, Line 134:</a> <code style="font-family:monospace,monospace"> ram_resource(dev, index++, 0x100000000 >> 10, (bmbound_hi - 0x100000000) >> 10);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c">File src/soc/broadcom/cygnus/ddr_init.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@74">Patch Set #1, Line 74:</a> <code style="font-family:monospace,monospace"> reg32_write ((volatile uint32_t *)DDR_PHY_CONTROL_REGS_STATIC_PAD_CTL, (readvalue & ~(1 << DDR_PHY_CONTROL_REGS_STATIC_PAD_CTL__RX_MODE_R)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@74">Patch Set #1, Line 74:</a> <code style="font-family:monospace,monospace"> reg32_write ((volatile uint32_t *)DDR_PHY_CONTROL_REGS_STATIC_PAD_CTL, (readvalue & ~(1 << DDR_PHY_CONTROL_REGS_STATIC_PAD_CTL__RX_MODE_R)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@78">Patch Set #1, Line 78:</a> <code style="font-family:monospace,monospace"> reg32_write ((volatile uint32_t *)DDR_PHY_CONTROL_REGS_ZQ_CAL, (readvalue & ~(1 << DDR_PHY_CONTROL_REGS_ZQ_CAL__ZQ_IDDQ)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@78">Patch Set #1, Line 78:</a> <code style="font-family:monospace,monospace"> reg32_write ((volatile uint32_t *)DDR_PHY_CONTROL_REGS_ZQ_CAL, (readvalue & ~(1 << DDR_PHY_CONTROL_REGS_ZQ_CAL__ZQ_IDDQ)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@82">Patch Set #1, Line 82:</a> <code style="font-family:monospace,monospace"> reg32_write ((volatile uint32_t *)DDR_PHY_BYTE_LANE_0_IDLE_PAD_CONTROL, (readvalue & ~(1 << DDR_PHY_BYTE_LANE_0_IDLE_PAD_CONTROL__IDLE)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@82">Patch Set #1, Line 82:</a> <code style="font-family:monospace,monospace"> reg32_write ((volatile uint32_t *)DDR_PHY_BYTE_LANE_0_IDLE_PAD_CONTROL, (readvalue & ~(1 << DDR_PHY_BYTE_LANE_0_IDLE_PAD_CONTROL__IDLE)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@85">Patch Set #1, Line 85:</a> <code style="font-family:monospace,monospace"> reg32_write ((volatile uint32_t *)DDR_PHY_BYTE_LANE_0_IDLE_PAD_CONTROL, (readvalue & 0xffff800f));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@85">Patch Set #1, Line 85:</a> <code style="font-family:monospace,monospace"> reg32_write ((volatile uint32_t *)DDR_PHY_BYTE_LANE_0_IDLE_PAD_CONTROL, (readvalue & 0xffff800f));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@88">Patch Set #1, Line 88:</a> <code style="font-family:monospace,monospace"> reg32_write ((volatile uint32_t *)DDR_PHY_BYTE_LANE_0_IDLE_PAD_CONTROL, (readvalue & ~(1 << DDR_PHY_BYTE_LANE_0_IDLE_PAD_CONTROL__IDDQ)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@88">Patch Set #1, Line 88:</a> <code style="font-family:monospace,monospace"> reg32_write ((volatile uint32_t *)DDR_PHY_BYTE_LANE_0_IDLE_PAD_CONTROL, (readvalue & ~(1 << DDR_PHY_BYTE_LANE_0_IDLE_PAD_CONTROL__IDDQ)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@92">Patch Set #1, Line 92:</a> <code style="font-family:monospace,monospace"> reg32_write ((volatile uint32_t *)DDR_PHY_BYTE_LANE_1_IDLE_PAD_CONTROL, (readvalue & ~(1 << DDR_PHY_BYTE_LANE_1_IDLE_PAD_CONTROL__IDLE)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@92">Patch Set #1, Line 92:</a> <code style="font-family:monospace,monospace"> reg32_write ((volatile uint32_t *)DDR_PHY_BYTE_LANE_1_IDLE_PAD_CONTROL, (readvalue & ~(1 << DDR_PHY_BYTE_LANE_1_IDLE_PAD_CONTROL__IDLE)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@95">Patch Set #1, Line 95:</a> <code style="font-family:monospace,monospace"> reg32_write ((volatile uint32_t *)DDR_PHY_BYTE_LANE_1_IDLE_PAD_CONTROL, (readvalue & 0xffff800f));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@95">Patch Set #1, Line 95:</a> <code style="font-family:monospace,monospace"> reg32_write ((volatile uint32_t *)DDR_PHY_BYTE_LANE_1_IDLE_PAD_CONTROL, (readvalue & 0xffff800f));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@98">Patch Set #1, Line 98:</a> <code style="font-family:monospace,monospace"> reg32_write ((volatile uint32_t *)DDR_PHY_BYTE_LANE_1_IDLE_PAD_CONTROL, (readvalue & ~(1 << DDR_PHY_BYTE_LANE_1_IDLE_PAD_CONTROL__IDDQ)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@98">Patch Set #1, Line 98:</a> <code style="font-family:monospace,monospace"> reg32_write ((volatile uint32_t *)DDR_PHY_BYTE_LANE_1_IDLE_PAD_CONTROL, (readvalue & ~(1 << DDR_PHY_BYTE_LANE_1_IDLE_PAD_CONTROL__IDDQ)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@146">Patch Set #1, Line 146:</a> <code style="font-family:monospace,monospace">#define SET_OVR_STEP(v) (0x30000 | ((v) & 0x3F)) /* OVR_FORCE = OVR_EN = 1, OVR_STEP = v */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@449">Patch Set #1, Line 449:</a> <code style="font-family:monospace,monospace"> reg32_clear_bits((volatile uint32_t *)DDR_DENALI_CTL_89 , 1 << 18);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@452">Patch Set #1, Line 452:</a> <code style="font-family:monospace,monospace"> reg32_write((volatile uint32_t *)DDR_DENALI_CTL_43 , (1 << 17) | (1 << 24) | (1 << 25));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@452">Patch Set #1, Line 452:</a> <code style="font-family:monospace,monospace"> reg32_write((volatile uint32_t *)DDR_DENALI_CTL_43 , (1 << 17) | (1 << 24) | (1 << 25));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@455">Patch Set #1, Line 455:</a> <code style="font-family:monospace,monospace"> reg32_set_bits((volatile uint32_t *)DDR_DENALI_CTL_43 , 1 << 25);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@458">Patch Set #1, Line 458:</a> <code style="font-family:monospace,monospace"> if (reg32_read((volatile uint32_t *)DDR_DENALI_CTL_89) & (1 << 18)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@458">Patch Set #1, Line 458:</a> <code style="font-family:monospace,monospace"> if (reg32_read((volatile uint32_t *)DDR_DENALI_CTL_89) & (1 << 18)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@464">Patch Set #1, Line 464:</a> <code style="font-family:monospace,monospace"> if (j == 0 && (reg32_read((volatile uint32_t *)DDR_DENALI_CTL_89) & (1 << 18)) == 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@968">Patch Set #1, Line 968:</a> <code style="font-family:monospace,monospace"> if ((((uint32_t)reg >= DDR_PHY_WORD_LANE_0_VDL_OVRIDE_BYTE_RD_EN) && ((uint32_t)reg <= (DDR_PHY_WORD_LANE_0_VDL_OVRIDE_BYTE_RD_EN + 0x114)))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@986">Patch Set #1, Line 986:</a> <code style="font-family:monospace,monospace"> if (CONFIG_SHMOO_REUSE_MEMTEST_LENGTH > 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@1121">Patch Set #1, Line 1121:</a> <code style="font-family:monospace,monospace"> for (i = 0; i < 1000; i++);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@1121">Patch Set #1, Line 1121:</a> <code style="font-family:monospace,monospace"> for (i = 0; i < 1000; i++);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing statements should be on next line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/ddr_init.c@1380">Patch Set #1, Line 1380:</a> <code style="font-family:monospace,monospace"> if (val != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (16, 12)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/phy_reg_access.c">File src/soc/broadcom/cygnus/phy_reg_access.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/phy_reg_access.c@20">Patch Set #1, Line 20:</a> <code style="font-family:monospace,monospace"> data = (* (volatile uint32 *) (((uint32)GLOBAL_REG_RBUS_START) | (address)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/phy_reg_access.c@27">Patch Set #1, Line 27:</a> <code style="font-family:monospace,monospace"> ((* (volatile uint32 *) (((uint32)GLOBAL_REG_RBUS_START) | (address))) = data);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/broadcom/cygnus/phy_reg_access.c@27">Patch Set #1, Line 27:</a> <code style="font-family:monospace,monospace"> ((* (volatile uint32 *) (((uint32)GLOBAL_REG_RBUS_START) | (address))) = data);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/soc/intel/baytrail/perf_power.c">File src/soc/intel/baytrail/perf_power.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/intel/baytrail/perf_power.c@224">Patch Set #1, Line 224:</a> <code style="font-family:monospace,monospace">E(CCU, 0x1c, MASK_VAL(1, 0, 0x0)), //vlv.ccu.clkgate_en_1.lps_free_clkgate_en</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c">File src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c@325">Patch Set #1, Line 325:</a> <code style="font-family:monospace,monospace"> printk(BIOS_WARNING,"Rebooting..\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/soc/intel/fsp_baytrail/northcluster.c">File src/soc/intel/fsp_baytrail/northcluster.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/soc/intel/fsp_baytrail/northcluster.c@161">Patch Set #1, Line 161:</a> <code style="font-family:monospace,monospace"> ram_resource(dev, index++, 0x100000000 >> 10, highmem_size >> 10);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/amd8132/bridge.c">File src/southbridge/amd/amd8132/bridge.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/amd8132/bridge.c@388">Patch Set #1, Line 388:</a> <code style="font-family:monospace,monospace"> if ((chip_rev == 0x11) ||(chip_rev == 0x12)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces required around that '||' (ctx:WxV)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/cimx/sb800/fan.c">File src/southbridge/amd/cimx/sb800/fan.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/cimx/sb800/fan.c@234">Patch Set #1, Line 234:</a> <code style="font-family:monospace,monospace"> sb_config.Pecstruct.MSGFun89zone0MSGREG2 = (sb_chip->imc_tempin0_at & 0xff);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/cimx/sb800/fan.c@238">Patch Set #1, Line 238:</a> <code style="font-family:monospace,monospace"> sb_config.Pecstruct.MSGFun89zone0MSGREG6 = (sb_chip->imc_tempin0_ct & 0xff);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/cimx/sb800/fan.c@252">Patch Set #1, Line 252:</a> <code style="font-family:monospace,monospace"> sb_config.Pecstruct.MSGFun89zone1MSGREG2 = (sb_chip->imc_tempin1_at & 0xff);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/cimx/sb800/fan.c@256">Patch Set #1, Line 256:</a> <code style="font-family:monospace,monospace"> sb_config.Pecstruct.MSGFun89zone1MSGREG6 = (sb_chip->imc_tempin1_ct & 0xff);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/cimx/sb800/fan.c@270">Patch Set #1, Line 270:</a> <code style="font-family:monospace,monospace"> sb_config.Pecstruct.MSGFun89zone2MSGREG2 = (sb_chip->imc_tempin2_at & 0xff);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/cimx/sb800/fan.c@274">Patch Set #1, Line 274:</a> <code style="font-family:monospace,monospace"> sb_config.Pecstruct.MSGFun89zone2MSGREG6 = (sb_chip->imc_tempin2_ct & 0xff);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/cimx/sb800/fan.c@288">Patch Set #1, Line 288:</a> <code style="font-family:monospace,monospace"> sb_config.Pecstruct.MSGFun89zone3MSGREG2 = (sb_chip->imc_tempin3_at & 0xff);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/cimx/sb800/fan.c@292">Patch Set #1, Line 292:</a> <code style="font-family:monospace,monospace"> sb_config.Pecstruct.MSGFun89zone3MSGREG6 = (sb_chip->imc_tempin3_ct & 0xff);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/rs780/gfx.c">File src/southbridge/amd/rs780/gfx.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/rs780/gfx.c@250">Patch Set #1, Line 250:</a> <code style="font-family:monospace,monospace"> if (Attribute & MMIO_ATTRIB_NP_ONLY && pMMIO[k].Attribute == 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/rs780/gfx.c@250">Patch Set #1, Line 250:</a> <code style="font-family:monospace,monospace"> if (Attribute & MMIO_ATTRIB_NP_ONLY && pMMIO[k].Attribute == 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/sb700/sata.c">File src/southbridge/amd/sb700/sata.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/sb700/sata.c@473">Patch Set #1, Line 473:</a> <code style="font-family:monospace,monospace"> (i % 2) ? "Slave" : "Master", i);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/sr5650/pcie.c">File src/southbridge/amd/sr5650/pcie.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/amd/sr5650/pcie.c@809">Patch Set #1, Line 809:</a> <code style="font-family:monospace,monospace"> if (!((pci_read_config32(dev, 0x6C) >> 6) & 0x01)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/ricoh/rl5c476/rl5c476.c">File src/southbridge/ricoh/rl5c476/rl5c476.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/ricoh/rl5c476/rl5c476.c@169">Patch Set #1, Line 169:</a> <code style="font-family:monospace,monospace"> if (enable_cf_boot && (PCI_FUNC(dev->path.pci.devfn) == 1)){</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open brace '{'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/ricoh/rl5c476/rl5c476.c@184">Patch Set #1, Line 184:</a> <code style="font-family:monospace,monospace"> if (enable_cf_boot && (PCI_FUNC(dev->path.pci.devfn) == 1)){</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open brace '{'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29161/1/src/southbridge/ricoh/rl5c476/rl5c476.c@186">Patch Set #1, Line 186:</a> <code style="font-family:monospace,monospace"> if (!(resource->flags & IORESOURCE_STORED)){</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open brace '{'</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29161">change 29161</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29161"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I6c77f4289b46646872731ef9c20dc115f0cf876d </div>
<div style="display:none"> Gerrit-Change-Number: 29161 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 17 Oct 2018 08:59:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>