<p>Duncan Laurie has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29124">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ec/google/wilco: Add ACPI EC event handlers<br><br>Add methods to handle ACPI EC events at runtime. Currently only<br>some common events are handled like lid switch and battery info,<br>and the event status is printed for debug on other events.<br><br>Change-Id: Ic0bd070940c8a2dfa6a251f3464301418bdb69c1<br>Signed-off-by: Duncan Laurie <dlaurie@google.com><br>---<br>M src/ec/google/wilco/acpi/ec.asl<br>A src/ec/google/wilco/acpi/event.asl<br>2 files changed, 127 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/29124/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ec/google/wilco/acpi/ec.asl b/src/ec/google/wilco/acpi/ec.asl</span><br><span>index d669854..cddfe3f 100644</span><br><span>--- a/src/ec/google/wilco/acpi/ec.asl</span><br><span>+++ b/src/ec/google/wilco/acpi/ec.asl</span><br><span>@@ -134,6 +134,7 @@</span><br><span> #include "ec_ram.asl"</span><br><span> #include "ac.asl"</span><br><span> #include "battery.asl"</span><br><span style="color: hsl(120, 100%, 40%);">+ #include "event.asl"</span><br><span> #include "lid.asl"</span><br><span> #include "platform.asl"</span><br><span> }</span><br><span>diff --git a/src/ec/google/wilco/acpi/event.asl b/src/ec/google/wilco/acpi/event.asl</span><br><span>new file mode 100644</span><br><span>index 0000000..b43086c</span><br><span>--- /dev/null</span><br><span>+++ b/src/ec/google/wilco/acpi/event.asl</span><br><span>@@ -0,0 +1,126 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright 2018 Google LLC</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or</span><br><span style="color: hsl(120, 100%, 40%);">+ * modify it under the terms of the GNU General Public License as</span><br><span style="color: hsl(120, 100%, 40%);">+ * published by the Free Software Foundation; version 2 of</span><br><span style="color: hsl(120, 100%, 40%);">+ * the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* ACPI_POWER_RECORD */</span><br><span style="color: hsl(120, 100%, 40%);">+Name (ECPR, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Method (ECQP, 0, Serialized)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ Local0 = R (APWR)</span><br><span style="color: hsl(120, 100%, 40%);">+ Local1 = Local0 ^ ECPR</span><br><span style="color: hsl(120, 100%, 40%);">+ ECPR = Local0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ If (EBIT (APAC, Local1)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Printf ("AC Power Status Changed")</span><br><span style="color: hsl(120, 100%, 40%);">+ Notify (AC, 0x80)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ If (EBIT (APB1, Local1)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ If (EBIT (APB1, Local0)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Printf ("BAT0 Inserted")</span><br><span style="color: hsl(120, 100%, 40%);">+ Notify (BAT0, 0x81)</span><br><span style="color: hsl(120, 100%, 40%);">+ } Else {</span><br><span style="color: hsl(120, 100%, 40%);">+ Printf ("BAT0 Removed")</span><br><span style="color: hsl(120, 100%, 40%);">+ Notify (BAT0, 0x80)</span><br><span style="color: hsl(120, 100%, 40%);">+ Notify (BAT0, 0x81)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ If (EBIT (APC1, Local1)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Printf ("BAT0 Status Change")</span><br><span style="color: hsl(120, 100%, 40%);">+ Notify (BAT0, 0x80)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Handle events in PmEv1 */</span><br><span style="color: hsl(120, 100%, 40%);">+Method (ECQ1, 1, Serialized)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Power button pressed */</span><br><span style="color: hsl(120, 100%, 40%);">+ If (EBIT (E1PB, Arg0)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Printf ("Power Button Event")</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Do not notify \_SB.PWRB here to prevent double event */</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* LID state changed */</span><br><span style="color: hsl(120, 100%, 40%);">+ If (EBIT (E1LD, Arg0)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Printf ("Lid State Changed")</span><br><span style="color: hsl(120, 100%, 40%);">+ Notify (^LID, 0x80)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Power Event */</span><br><span style="color: hsl(120, 100%, 40%);">+ If (EBIT (E1PW, Arg0)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Printf ("Power Event")</span><br><span style="color: hsl(120, 100%, 40%);">+ ECQP ()</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Sleep Button */</span><br><span style="color: hsl(120, 100%, 40%);">+ If (EBIT (E1SB, Arg0)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Printf ("Sleep Button")</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Handle events in PmEv2 */</span><br><span style="color: hsl(120, 100%, 40%);">+Method (ECQ2, 1, Serialized)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ Printf ("EVT2: %o", Arg0)</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Handle events in PmEv3 */</span><br><span style="color: hsl(120, 100%, 40%);">+Method (ECQ3, 1, Serialized)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ Printf ("EVT3: %o", Arg0)</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Handle events in PmEv4 */</span><br><span style="color: hsl(120, 100%, 40%);">+Method (ECQ4, 1, Serialized)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ Printf ("EVT4: %o", Arg0)</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Handle QuickSet events */</span><br><span style="color: hsl(120, 100%, 40%);">+Method (ECQS, 1, Serialized)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ Printf ("QS EVENT %o", Arg0)</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Process all events */</span><br><span style="color: hsl(120, 100%, 40%);">+Method (_Q66, 0, Serialized)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ Local0 = R (EVT1)</span><br><span style="color: hsl(120, 100%, 40%);">+ If (Local0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ECQ1 (Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Local0 = R (EVT2)</span><br><span style="color: hsl(120, 100%, 40%);">+ If (Local0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ECQ2 (Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Local0 = R (EVT3)</span><br><span style="color: hsl(120, 100%, 40%);">+ If (Local0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ECQ3 (Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Local0 = R (EVT4)</span><br><span style="color: hsl(120, 100%, 40%);">+ If (Local0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ECQ4 (Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Local0 = R (QSEC)</span><br><span style="color: hsl(120, 100%, 40%);">+ For (Local1 = 0, Local1 < Local0, Local1++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ECQS (R (QSEB))</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29124">change 29124</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29124"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic0bd070940c8a2dfa6a251f3464301418bdb69c1 </div>
<div style="display:none"> Gerrit-Change-Number: 29124 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>