<p>Duncan Laurie has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29120">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ec/google/wilco: Save and restore PS/2 data for S3<br><br>Send a command to the EC on the way into S3 suspend state telling<br>it to save the PS/2 data, and on resume send it a command for<br>restoring the PS/2 data that was previously saved.<br><br>Change-Id: Ic4b5d6d2656dbb1c476b9211b0d60c71b0cd7b32<br>Signed-off-by: Duncan Laurie <dlaurie@google.com><br>---<br>M src/ec/google/wilco/chip.c<br>M src/ec/google/wilco/commands.h<br>M src/ec/google/wilco/smihandler.c<br>3 files changed, 12 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/29120/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ec/google/wilco/chip.c b/src/ec/google/wilco/chip.c</span><br><span>index fe4ef6a..d8ec281 100644</span><br><span>--- a/src/ec/google/wilco/chip.c</span><br><span>+++ b/src/ec/google/wilco/chip.c</span><br><span>@@ -44,6 +44,13 @@</span><br><span> BOOT_STATE_INIT_ENTRY(BS_DEV_INIT, BS_ON_EXIT,</span><br><span>                  wilco_ec_post_video_init, NULL);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void wilco_ec_suspend_resume(void *unused)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+      wilco_ec_send_noargs(KB_RESTORE);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+BOOT_STATE_INIT_ENTRY(BS_OS_RESUME, BS_ON_ENTRY,</span><br><span style="color: hsl(120, 100%, 40%);">+                      wilco_ec_suspend_resume, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static void wilco_ec_init(struct device *dev)</span><br><span> {</span><br><span>        if (!dev->enabled)</span><br><span>diff --git a/src/ec/google/wilco/commands.h b/src/ec/google/wilco/commands.h</span><br><span>index a74e1b2..eeb6d30 100644</span><br><span>--- a/src/ec/google/wilco/commands.h</span><br><span>+++ b/src/ec/google/wilco/commands.h</span><br><span>@@ -25,6 +25,10 @@</span><br><span>      KB_POWER_STATUS = 0x05,</span><br><span>      /* Inform the EC aboout the reason host is turning off */</span><br><span>    KB_POWER_OFF = 0x08,</span><br><span style="color: hsl(120, 100%, 40%);">+  /* Save PS/2 data before S3 suspend */</span><br><span style="color: hsl(120, 100%, 40%);">+        KB_SAVE = 0x2f,</span><br><span style="color: hsl(120, 100%, 40%);">+       /* Restore PS/2 data after S3 resume */</span><br><span style="color: hsl(120, 100%, 40%);">+       KB_RESTORE = 0x30,</span><br><span>   /* Retrieve information about the EC */</span><br><span>      KB_EC_INFO = 0x38,</span><br><span>   /* Set ACPI mode on or off */</span><br><span>diff --git a/src/ec/google/wilco/smihandler.c b/src/ec/google/wilco/smihandler.c</span><br><span>index 9fb1518..adad533 100644</span><br><span>--- a/src/ec/google/wilco/smihandler.c</span><br><span>+++ b/src/ec/google/wilco/smihandler.c</span><br><span>@@ -25,6 +25,7 @@</span><br><span> {</span><br><span>  switch (slp_type) {</span><br><span>  case ACPI_S3:</span><br><span style="color: hsl(120, 100%, 40%);">+         wilco_ec_send_noargs(KB_SAVE);</span><br><span>               wilco_ec_slp_en();</span><br><span>           break;</span><br><span>       case ACPI_S5:</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29120">change 29120</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29120"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic4b5d6d2656dbb1c476b9211b0d60c71b0cd7b32 </div>
<div style="display:none"> Gerrit-Change-Number: 29120 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>