<p>Peter Lemenkov has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29107">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/lenovo/*/romstage: Remove explicit power-on defaults<br><br>Change-Id: Ib359e4039f87bb87faac040f24f70cc0988c0ea8<br>Signed-off-by: Peter Lemenkov <lemenkov@gmail.com><br>---<br>M src/mainboard/lenovo/l520/romstage.c<br>M src/mainboard/lenovo/t420/romstage.c<br>M src/mainboard/lenovo/t420s/romstage.c<br>M src/mainboard/lenovo/t430s/romstage.c<br>M src/mainboard/lenovo/t520/romstage.c<br>M src/mainboard/lenovo/t530/romstage.c<br>M src/mainboard/lenovo/x220/romstage.c<br>M src/mainboard/lenovo/x230/romstage.c<br>8 files changed, 1 insertion(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/29107/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/lenovo/l520/romstage.c b/src/mainboard/lenovo/l520/romstage.c</span><br><span>index 0f6ffed..61319f5 100644</span><br><span>--- a/src/mainboard/lenovo/l520/romstage.c</span><br><span>+++ b/src/mainboard/lenovo/l520/romstage.c</span><br><span>@@ -34,8 +34,8 @@</span><br><span> </span><br><span> void mainboard_rcba_config(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-  RCBA32(0x3414) = 0x00000000;</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> const struct southbridge_usb_port mainboard_usb_ports[] = {</span><br><span>   { 1, 0, -1 },</span><br><span>        { 1, 0, -1 },</span><br><span>diff --git a/src/mainboard/lenovo/t420/romstage.c b/src/mainboard/lenovo/t420/romstage.c</span><br><span>index bef2562..aad8348 100644</span><br><span>--- a/src/mainboard/lenovo/t420/romstage.c</span><br><span>+++ b/src/mainboard/lenovo/t420/romstage.c</span><br><span>@@ -65,7 +65,6 @@</span><br><span> </span><br><span> void mainboard_rcba_config(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-     RCBA32(BUC) = 0;</span><br><span> }</span><br><span> </span><br><span> // OC3 set in bios to port 2-7, OC7 set in bios to port 10-13</span><br><span>diff --git a/src/mainboard/lenovo/t420s/romstage.c b/src/mainboard/lenovo/t420s/romstage.c</span><br><span>index be8052c..8004e2f 100644</span><br><span>--- a/src/mainboard/lenovo/t420s/romstage.c</span><br><span>+++ b/src/mainboard/lenovo/t420s/romstage.c</span><br><span>@@ -67,7 +67,6 @@</span><br><span> </span><br><span> void mainboard_rcba_config(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(BUC) = 0;</span><br><span> }</span><br><span> </span><br><span> const struct southbridge_usb_port mainboard_usb_ports[] = {</span><br><span>diff --git a/src/mainboard/lenovo/t430s/romstage.c b/src/mainboard/lenovo/t430s/romstage.c</span><br><span>index 633ba3f..b409b5e 100644</span><br><span>--- a/src/mainboard/lenovo/t430s/romstage.c</span><br><span>+++ b/src/mainboard/lenovo/t430s/romstage.c</span><br><span>@@ -40,7 +40,6 @@</span><br><span> </span><br><span> void mainboard_rcba_config(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-      RCBA32(BUC) = 0;</span><br><span> }</span><br><span> </span><br><span> const struct southbridge_usb_port mainboard_usb_ports[] = {</span><br><span>diff --git a/src/mainboard/lenovo/t520/romstage.c b/src/mainboard/lenovo/t520/romstage.c</span><br><span>index 4fcd651..cdd0d45 100644</span><br><span>--- a/src/mainboard/lenovo/t520/romstage.c</span><br><span>+++ b/src/mainboard/lenovo/t520/romstage.c</span><br><span>@@ -77,7 +77,6 @@</span><br><span> </span><br><span> void mainboard_rcba_config(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-  RCBA32(BUC) = 0;</span><br><span> }</span><br><span> </span><br><span> const struct southbridge_usb_port mainboard_usb_ports[] = {</span><br><span>diff --git a/src/mainboard/lenovo/t530/romstage.c b/src/mainboard/lenovo/t530/romstage.c</span><br><span>index 88e07c1..68dd694 100644</span><br><span>--- a/src/mainboard/lenovo/t530/romstage.c</span><br><span>+++ b/src/mainboard/lenovo/t530/romstage.c</span><br><span>@@ -69,7 +69,6 @@</span><br><span> </span><br><span> void mainboard_rcba_config(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-  RCBA32(BUC) = 0;</span><br><span> }</span><br><span> </span><br><span> void mainboard_early_init(int s3resume)</span><br><span>diff --git a/src/mainboard/lenovo/x220/romstage.c b/src/mainboard/lenovo/x220/romstage.c</span><br><span>index 96e0284..6efcd01 100644</span><br><span>--- a/src/mainboard/lenovo/x220/romstage.c</span><br><span>+++ b/src/mainboard/lenovo/x220/romstage.c</span><br><span>@@ -50,7 +50,6 @@</span><br><span> </span><br><span> void mainboard_rcba_config(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-      RCBA32(BUC) = 0;</span><br><span> }</span><br><span> </span><br><span> void mainboard_fill_pei_data(struct pei_data *pei_data)</span><br><span>diff --git a/src/mainboard/lenovo/x230/romstage.c b/src/mainboard/lenovo/x230/romstage.c</span><br><span>index 1ddaedf..94bcab3 100644</span><br><span>--- a/src/mainboard/lenovo/x230/romstage.c</span><br><span>+++ b/src/mainboard/lenovo/x230/romstage.c</span><br><span>@@ -48,7 +48,6 @@</span><br><span> </span><br><span> void mainboard_rcba_config(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-      RCBA32(BUC) = 0;</span><br><span> }</span><br><span> </span><br><span> const struct southbridge_usb_port mainboard_usb_ports[] = {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29107">change 29107</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29107"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib359e4039f87bb87faac040f24f70cc0988c0ea8 </div>
<div style="display:none"> Gerrit-Change-Number: 29107 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Peter Lemenkov <lemenkov@gmail.com> </div>