<p>Peter Lemenkov would like Patrick Rudolph to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/29032">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On<br><br>Port commit f1395d82: "ec/lenovo/h8: Add USB Always On" to the Thinkpad<br>x1_carbon_gen1 board as well, as it seems to work fine on all<br>generations.<br><br>See also commit 7ffb329f278d6b027bb3b3660b69e87f1ddd69d8<br><br>Change-Id: Ib9070b659b0c9ad5dde4200ec2845c6fa2b78b25<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>Signed-off-by: Peter Lemenkov <lemenkov@gmail.com><br>---<br>M src/mainboard/lenovo/x1_carbon_gen1/cmos.default<br>M src/mainboard/lenovo/x1_carbon_gen1/cmos.layout<br>M src/mainboard/lenovo/x1_carbon_gen1/smihandler.c<br>3 files changed, 7 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/29032/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/lenovo/x1_carbon_gen1/cmos.default b/src/mainboard/lenovo/x1_carbon_gen1/cmos.default</span><br><span>index 3044c6c..bcabae5 100644</span><br><span>--- a/src/mainboard/lenovo/x1_carbon_gen1/cmos.default</span><br><span>+++ b/src/mainboard/lenovo/x1_carbon_gen1/cmos.default</span><br><span>@@ -13,3 +13,4 @@</span><br><span> sticky_fn=Disable</span><br><span> trackpoint=Enable</span><br><span> backlight=Both</span><br><span style="color: hsl(120, 100%, 40%);">+usb_always_on=Disable</span><br><span>\ No newline at end of file</span><br><span>diff --git a/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout b/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout</span><br><span>index ad5a489..bb25261 100644</span><br><span>--- a/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout</span><br><span>+++ b/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout</span><br><span>@@ -67,7 +67,7 @@</span><br><span> 416         1       e       1        trackpoint</span><br><span> 417         1       e       1        fn_ctrl_swap</span><br><span> 418         1       e       1        sticky_fn</span><br><span style="color: hsl(0, 100%, 40%);">-#419        2       r       0        unused</span><br><span style="color: hsl(120, 100%, 40%);">+419         2       e      12        usb_always_on</span><br><span> 421         1       e       9        sata_mode</span><br><span> 422         2       e      10        backlight</span><br><span> </span><br><span>@@ -126,6 +126,9 @@</span><br><span> 11    4     160M</span><br><span> 11    5     192M</span><br><span> 11    6     224M</span><br><span style="color: hsl(120, 100%, 40%);">+12    0     Disable</span><br><span style="color: hsl(120, 100%, 40%);">+12    1     AC and battery</span><br><span style="color: hsl(120, 100%, 40%);">+12    2     AC only</span><br><span> </span><br><span> # -----------------------------------------------------------------</span><br><span> checksums</span><br><span>diff --git a/src/mainboard/lenovo/x1_carbon_gen1/smihandler.c b/src/mainboard/lenovo/x1_carbon_gen1/smihandler.c</span><br><span>index 2425927..a69b78f 100644</span><br><span>--- a/src/mainboard/lenovo/x1_carbon_gen1/smihandler.c</span><br><span>+++ b/src/mainboard/lenovo/x1_carbon_gen1/smihandler.c</span><br><span>@@ -72,6 +72,8 @@</span><br><span> </span><br><span> void mainboard_smi_sleep(u8 slp_typ)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+   h8_usb_always_on();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>        if (slp_typ == 3) {</span><br><span>          u8 ec_wake = ec_read(0x32);</span><br><span>          /* If EC wake events are enabled, enable wake on EC WAKE GPE.  */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29032">change 29032</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29032"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib9070b659b0c9ad5dde4200ec2845c6fa2b78b25 </div>
<div style="display:none"> Gerrit-Change-Number: 29032 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Peter Lemenkov <lemenkov@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>