<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29051">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/mediatek: Convert to `board_reset()`<br><br>Note, we select MISSING_BOARD_RESET for MT8183 because it didn't select<br>HAVE_HARD_RESET before. Although, it is implemented?<br><br>Change-Id: Ic850f2775ada5e6e543ffb92aaa033b9209596f5<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M src/soc/mediatek/common/wdt.c<br>M src/soc/mediatek/mt8173/Kconfig<br>M src/soc/mediatek/mt8183/Kconfig<br>3 files changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/29051/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/mediatek/common/wdt.c b/src/soc/mediatek/common/wdt.c</span><br><span>index c261753..2f70454 100644</span><br><span>--- a/src/soc/mediatek/common/wdt.c</span><br><span>+++ b/src/soc/mediatek/common/wdt.c</span><br><span>@@ -57,7 +57,10 @@</span><br><span>        return wdt_sta;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void do_hard_reset(void)</span><br><span style="color: hsl(120, 100%, 40%);">+/* FIXME: Disabled for MT8183, probably by accident? */</span><br><span style="color: hsl(120, 100%, 40%);">+#if !IS_ENABLED(CONFIG_MISSING_BOARD_RESET)</span><br><span style="color: hsl(120, 100%, 40%);">+void do_board_reset(void)</span><br><span> {</span><br><span>       write32(&mtk_wdt->wdt_swrst, MTK_WDT_SWRST_KEY);</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span>diff --git a/src/soc/mediatek/mt8173/Kconfig b/src/soc/mediatek/mt8173/Kconfig</span><br><span>index de9b932..cf0c8d9 100644</span><br><span>--- a/src/soc/mediatek/mt8173/Kconfig</span><br><span>+++ b/src/soc/mediatek/mt8173/Kconfig</span><br><span>@@ -12,7 +12,6 @@</span><br><span>    select HAVE_MONOTONIC_TIMER</span><br><span>  select GENERIC_UDELAY</span><br><span>        select GENERIC_GPIO_LIB</span><br><span style="color: hsl(0, 100%, 40%);">- select HAVE_HARD_RESET</span><br><span>       select RTC</span><br><span> </span><br><span> if SOC_MEDIATEK_MT8173</span><br><span>diff --git a/src/soc/mediatek/mt8183/Kconfig b/src/soc/mediatek/mt8183/Kconfig</span><br><span>index b58be7f..4832fbf 100644</span><br><span>--- a/src/soc/mediatek/mt8183/Kconfig</span><br><span>+++ b/src/soc/mediatek/mt8183/Kconfig</span><br><span>@@ -11,6 +11,7 @@</span><br><span>        select HAVE_UART_SPECIAL</span><br><span>     select HAVE_MONOTONIC_TIMER</span><br><span>  select COMPRESS_BOOTBLOCK</span><br><span style="color: hsl(120, 100%, 40%);">+     select MISSING_BOARD_RESET</span><br><span> </span><br><span> if SOC_MEDIATEK_MT8183</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29051">change 29051</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29051"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic850f2775ada5e6e543ffb92aaa033b9209596f5 </div>
<div style="display:none"> Gerrit-Change-Number: 29051 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>