<p>Roy Mingi Park has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29007">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nocturne: Disable pull-down of GPP_E9/E10<br><br>While these pins were set to a pull-down 20KOhm, NPCX EC consumes<br>~2.1mW higher power. Becasue there was leakage current on both GPIO67<br>and GPIO70 from NPCX EC. With the external pull-up 10KOhm for<br>USB_OC0#/USB2_OC1#, this wasn't enough to prevent leakage current.<br><br>Change-Id: I685d876461c263f07ca4c8f8046635cb7087279c<br>Signed-off-by: Roy Mingi Park <roy.mingi.park@intel.com><br>---<br>M src/mainboard/google/poppy/variants/nocturne/gpio.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/29007/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/gpio.c b/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>index 8f87705..16ff982 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>@@ -229,9 +229,9 @@</span><br><span>     /* E8  : SATALED# ==> NC */</span><br><span>       PAD_CFG_NC(GPP_E8),</span><br><span>  /* E9  : USB2_OCO# ==> USB_C0_OC_ODL */</span><br><span style="color: hsl(0, 100%, 40%);">-      PAD_CFG_NF(GPP_E9, 20K_PD, DEEP, NF1),</span><br><span style="color: hsl(120, 100%, 40%);">+        PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1),</span><br><span>         /* E10 : USB2_OC1# ==> USB_C1_OC_ODL */</span><br><span style="color: hsl(0, 100%, 40%);">-      PAD_CFG_NF(GPP_E10, 20K_PD, DEEP, NF1),</span><br><span style="color: hsl(120, 100%, 40%);">+       PAD_CFG_NF(GPP_E10, NONE, DEEP, NF1),</span><br><span>        /* E11 : USB2_OC2# ==> TOUCHSCREEN_RESET_L */</span><br><span>     PAD_CFG_TERM_GPO(GPP_E11, 0, 20K_PD, DEEP),</span><br><span>  /* E12 : USB2_OC3# ==> NC */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29007">change 29007</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29007"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I685d876461c263f07ca4c8f8046635cb7087279c </div>
<div style="display:none"> Gerrit-Change-Number: 29007 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Roy Mingi Park <roy.mingi.park@intel.com> </div>