<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29006">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ec/google/chromeec: Get rid of __SMM__ guard for chromeec functions<br><br>There doesn't seem to be a reason why we would want to protect certain<br>chromeec functions with __SMM__ guard. So, this change gets rid of<br>it. If the functions remain unused, then they would be removed during<br>linking.<br><br>Change-Id: I8196406074b01fe8ea15173c55d45bb86384be1b<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/ec/google/chromeec/ec.c<br>1 file changed, 0 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/29006/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c</span><br><span>index 90fcc3d..75d9da1 100644</span><br><span>--- a/src/ec/google/chromeec/ec.c</span><br><span>+++ b/src/ec/google/chromeec/ec.c</span><br><span>@@ -636,7 +636,6 @@</span><br><span>  return 0;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#ifndef __SMM__</span><br><span> int google_chromeec_get_board_version(uint32_t *version)</span><br><span> {</span><br><span>   struct chromeec_command cmd;</span><br><span>@@ -713,8 +712,6 @@</span><br><span>   return cec_cmd.cmd_code;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#endif /* ! __SMM__ */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> #ifndef __PRE_RAM__</span><br><span> </span><br><span> int google_chromeec_i2c_xfer(uint8_t chip, uint8_t addr, int alen,</span><br><span>@@ -920,8 +917,6 @@</span><br><span>       return google_chromeec_command(&cmd);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#ifndef __SMM__</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> static int google_chromeec_hello(void)</span><br><span> {</span><br><span>     struct chromeec_command cec_cmd;</span><br><span>@@ -1106,7 +1101,6 @@</span><br><span> {</span><br><span>        return (ec_image_type == EC_IMAGE_RO);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-#endif /* ! __SMM__ */</span><br><span> </span><br><span> #endif /* ! __PRE_RAM__ */</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29006">change 29006</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29006"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8196406074b01fe8ea15173c55d45bb86384be1b </div>
<div style="display:none"> Gerrit-Change-Number: 29006 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>