<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28948">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: Fix ‘dev’ pointer NULL before being dereferenced<br><br>This patch fixes KW issue due to pointer being NULL and will be dereferenced<br><br>Change-Id: Iedb59daf5f448e31c0097873a086e4d08cd4a979<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/soc/intel/skylake/cpu.c<br>M src/soc/intel/skylake/thermal.c<br>2 files changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/28948/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c</span><br><span>index 3733fe0..2adbc26 100644</span><br><span>--- a/src/soc/intel/skylake/cpu.c</span><br><span>+++ b/src/soc/intel/skylake/cpu.c</span><br><span>@@ -290,6 +290,8 @@</span><br><span> static void configure_misc(void)</span><br><span> {</span><br><span>         struct device *dev = SA_DEV_ROOT;</span><br><span style="color: hsl(120, 100%, 40%);">+     if (!dev)</span><br><span style="color: hsl(120, 100%, 40%);">+             return;</span><br><span>      config_t *conf = dev->chip_info;</span><br><span>  msr_t msr;</span><br><span> </span><br><span>diff --git a/src/soc/intel/skylake/thermal.c b/src/soc/intel/skylake/thermal.c</span><br><span>index 01a4f26..aeeebe1 100644</span><br><span>--- a/src/soc/intel/skylake/thermal.c</span><br><span>+++ b/src/soc/intel/skylake/thermal.c</span><br><span>@@ -83,6 +83,8 @@</span><br><span> {</span><br><span>     uint16_t reg16;</span><br><span>      struct device *dev = PCH_DEV_THERMAL;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!dev)</span><br><span style="color: hsl(120, 100%, 40%);">+             return;</span><br><span>      void *thermalbar = pch_thermal_get_bar(dev);</span><br><span> </span><br><span>     /* Use default pre-ram bar */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28948">change 28948</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28948"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iedb59daf5f448e31c0097873a086e4d08cd4a979 </div>
<div style="display:none"> Gerrit-Change-Number: 28948 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>