<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28949">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/common/block/pcr: Add NULL pointer check in pcr_execute_sideband_msg()<br><br>This patch to fix KW issue due to msg, data and response pointers NULL<br>check fail.<br><br>Change-Id: I39324514079f240ba1683a04e579de85485299bf<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/soc/intel/common/block/pcr/pcr.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/28949/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/common/block/pcr/pcr.c b/src/soc/intel/common/block/pcr/pcr.c</span><br><span>index b8d798f..024059a 100644</span><br><span>--- a/src/soc/intel/common/block/pcr/pcr.c</span><br><span>+++ b/src/soc/intel/common/block/pcr/pcr.c</span><br><span>@@ -263,7 +263,10 @@</span><br><span>         uint16_t sbi_status;</span><br><span>         uint16_t sbi_rid;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   assert(msg && data && response);</span><br><span style="color: hsl(120, 100%, 40%);">+      if (!msg || !data || !response) {</span><br><span style="color: hsl(120, 100%, 40%);">+             die("Pointer msg/ data/ response checked for NULL Fail!");</span><br><span style="color: hsl(120, 100%, 40%);">+          return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span> </span><br><span>        switch (msg->opcode) {</span><br><span>            case MEM_READ:</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28949">change 28949</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28949"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I39324514079f240ba1683a04e579de85485299bf </div>
<div style="display:none"> Gerrit-Change-Number: 28949 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>