<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28947">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/cannonlake: Disable Legacy PME for Root ports<br><br>Legacy PME are enabled by default in FSP-S UPD. This patch to override<br>root port legacy pme upd policy from coreboot.<br><br>BUG=b:113083354<br>BRANCH=none<br>TEST=Able to make S3 resume using wake on wifi connect/disconnect usecase<br><br>Change-Id: I779fac711eeeed65ea379fad1cc400052d8a00eb<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/soc/intel/cannonlake/fsp_params.c<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/28947/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/cannonlake/fsp_params.c b/src/soc/intel/cannonlake/fsp_params.c</span><br><span>index cbc97b2..d5233ed 100644</span><br><span>--- a/src/soc/intel/cannonlake/fsp_params.c</span><br><span>+++ b/src/soc/intel/cannonlake/fsp_params.c</span><br><span>@@ -129,6 +129,9 @@</span><br><span>       /* S0ix */</span><br><span>   params->PchPmSlpS0Enable = config->s0ix_enable;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+     /* disable Legacy PME */</span><br><span style="color: hsl(120, 100%, 40%);">+      memset(params->PcieRpPmSci, 0, sizeof(params->PcieRpPmSci));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>         /* USB */</span><br><span>    for (i = 0; i < ARRAY_SIZE(config->usb2_ports); i++) {</span><br><span>                 params->PortUsb20Enable[i] = config->usb2_ports[i].enable;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28947">change 28947</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28947"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I779fac711eeeed65ea379fad1cc400052d8a00eb </div>
<div style="display:none"> Gerrit-Change-Number: 28947 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>