<p><a href="https://review.coreboot.org/28937">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28937/2/src/soc/intel/cannonlake/cpu.c">File src/soc/intel/cannonlake/cpu.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28937/2/src/soc/intel/cannonlake/cpu.c@187">Patch Set #2, Line 187:</a> <code style="font-family:monospace,monospace">MSR_EMULATE_PM_TMR</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is defined here soc/intel/common/block/include/intelblocks/msr.h, <br>but also we have it here : src/soc/intel/skylake/include/soc/msr.h  as "MSR_EMULATE_PM_TIMER"<br>and we cab see also "EMULATE_DELAY_VALUE" ...</p><p style="white-space: pre-wrap; word-wrap: break-word;">Maybe we can fix the name and move this msr and linked registers bit to "soc/intel/common/block/include/intelblocks/msr.h" ?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28937">change 28937</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28937"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ie069e815e6244c3f85fabf51e186311621d316fd </div>
<div style="display:none"> Gerrit-Change-Number: 28937 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Hannah Williams <hannah.williams@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-CC: Subrata Banik <subi.banik@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 05 Oct 2018 19:26:39 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>