<p>Peter Lemenkov <strong>uploaded patch set #2</strong> to this change.</p><p><a href="https://review.coreboot.org/28936">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Unify all Lenovo t520 variants<br><br>It looks that L520 is almost the same as other two T520 variants. So<br>let's remove duplicated code.<br><br>The only difference between l520 and t520/w520 which i'm not sure is<br>cmos.layout and cmos.defaults settings. Here is a diff:<br><br>============================<br>diff --git a/src/mainboard/lenovo/t520/cmos.default b/src/mainboard/lenovo/t520/cmos.default<br>index 979f132863..6e61dae340 100644<br>--- a/src/mainboard/lenovo/t520/cmos.default<br>+++ b/src/mainboard/lenovo/t520/cmos.default<br>@@ -13,4 +13,5 @@ fn_ctrl_swap=Disable<br> sticky_fn=Disable<br> trackpoint=Enable<br> backlight=Both<br>+hybrid_graphics_mode=Integrated Only<br> usb_always_on=Disable<br>diff --git a/src/mainboard/lenovo/t520/cmos.layout b/src/mainboard/lenovo/t520/cmos.layout<br>index 60292a401b..1a7943e5a4 100644<br>--- a/src/mainboard/lenovo/t520/cmos.layout<br>+++ b/src/mainboard/lenovo/t520/cmos.layout<br>@@ -68,7 +68,7 @@ entries<br> 416 1 e 1 trackpoint<br> 417 1 e 1 fn_ctrl_swap<br> 418 1 e 1 sticky_fn<br>-419 2 e 12 usb_always_on<br>+419 2 e 13 usb_always_on<br> 421 1 e 9 sata_mode<br> 422 2 e 10 backlight<br><br>@@ -77,7 +77,8 @@ entries<br><br> # coreboot config options: northbridge<br> 432 3 e 11 gfx_uma_size<br>-#435 5 r 0 unused<br>+435 2 e 12 hybrid_graphics_mode<br>+#437 3 r 0 unused<br> 440 8 h 0 volume<br><br> # SandyBridge MRC Scrambler Seed values<br>@@ -126,9 +127,12 @@ enumerations<br> 11 4 160M<br> 11 5 192M<br> 11 6 224M<br>-12 0 Disable<br>-12 1 AC and battery<br>-12 2 AC only<br>+12 0 Integrated Only<br>+12 1 Discrete Only<br>+12 2 Dual Graphics<br>+13 0 Disable<br>+13 1 AC and battery<br>+13 2 AC only<br><br> # -----------------------------------------------------------------<br> checksums<br><br>============================<br><br>The only change from L520 is the addition of a hybrid graphics field<br>(12) and change usb_always_on from this 12 to the next value, e.g. 13.<br><br>I believe this is ok, since these numbers are used by Coreboot itself so<br>any new L520 user will have the updated cmos mappings.<br><br>In the mean time I'm going to unify more Lenovo (if anyone finds it<br>interesting and valuable). Then I'll try to fix autoport utility<br>accordingly.<br><br>Change-Id: I936ec6e51dc74637439d8562070443904071708c<br>Signed-off-by: Peter Lemenkov <lemenkov@gmail.com><br>---<br>D src/mainboard/lenovo/l520/Kconfig<br>D src/mainboard/lenovo/l520/Kconfig.name<br>D src/mainboard/lenovo/l520/Makefile.inc<br>D src/mainboard/lenovo/l520/acpi/ec.asl<br>D src/mainboard/lenovo/l520/acpi/platform.asl<br>D src/mainboard/lenovo/l520/acpi/superio.asl<br>D src/mainboard/lenovo/l520/acpi_tables.c<br>D src/mainboard/lenovo/l520/cmos.default<br>D src/mainboard/lenovo/l520/cmos.layout<br>D src/mainboard/lenovo/l520/dsdt.asl<br>D src/mainboard/lenovo/l520/hda_verb.c<br>D src/mainboard/lenovo/l520/mainboard.c<br>D src/mainboard/lenovo/l520/smihandler.c<br>D src/mainboard/lenovo/l520/thermal.h<br>M src/mainboard/lenovo/t520/Kconfig<br>M src/mainboard/lenovo/t520/Kconfig.name<br>M src/mainboard/lenovo/t520/acpi/ec.asl<br>M src/mainboard/lenovo/t520/acpi/platform.asl<br>M src/mainboard/lenovo/t520/acpi/superio.asl<br>M src/mainboard/lenovo/t520/acpi_tables.c<br>M src/mainboard/lenovo/t520/dsdt.asl<br>M src/mainboard/lenovo/t520/hda_verb.c<br>M src/mainboard/lenovo/t520/mainboard.c<br>M src/mainboard/lenovo/t520/smihandler.c<br>M src/mainboard/lenovo/t520/thermal.h<br>R src/mainboard/lenovo/t520/variants/l520/board_info.txt<br>R src/mainboard/lenovo/t520/variants/l520/devicetree.cb<br>R src/mainboard/lenovo/t520/variants/l520/gpio.c<br>R src/mainboard/lenovo/t520/variants/l520/romstage.c<br>29 files changed, 151 insertions(+), 629 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/28936/2</pre><p>To view, visit <a href="https://review.coreboot.org/28936">change 28936</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28936"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>
<div style="display:none"> Gerrit-Change-Id: I936ec6e51dc74637439d8562070443904071708c </div>
<div style="display:none"> Gerrit-Change-Number: 28936 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Peter Lemenkov <lemenkov@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>