<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/28885">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Raul Rangel: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">amd/stoneyridge: Use BIOS_DEBUG to log PM1 and PMxC0 status<br><br>Use BIOS_DEBUG consistently to log PM1 and PMxC0 status registers<br>on boot. print_num_status_bits() was already using BIOS_DEBUG.<br><br>TEST=Inspect console for Grunt<br>BUG=b:110788201<br><br>Change-Id: If7da8c7c86e90a661338903ad05cc41e11f507d2<br>Signed-off-by: Edward Hill <ecgh@chromium.org><br>Reviewed-on: https://review.coreboot.org/28885<br>Reviewed-by: Raul Rangel <rrangel@chromium.org><br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>---<br>M src/soc/amd/stoneyridge/southbridge.c<br>1 file changed, 6 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c</span><br><span>index b122f83..763ddd7 100644</span><br><span>--- a/src/soc/amd/stoneyridge/southbridge.c</span><br><span>+++ b/src/soc/amd/stoneyridge/southbridge.c</span><br><span>@@ -667,7 +667,7 @@</span><br><span>        /* PMxC0 S5/Reset Status shows the source of previous reset. */</span><br><span>      uint32_t pmxc0_status = pm_read32(PM_RST_STATUS);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   static const char *const pmxc0_status_bits[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+      static const char *const pmxc0_status_bits[32] = {</span><br><span>           [0] = "ThermalTrip",</span><br><span>               [1] = "FourSecondPwrBtn",</span><br><span>          [2] = "Shutdown",</span><br><span>@@ -688,13 +688,12 @@</span><br><span>          [27] = "SyncFlood",</span><br><span>                [28] = "HangReset",</span><br><span>                [29] = "EcWatchdogRst",</span><br><span style="color: hsl(0, 100%, 40%);">-               [31] = "BIT31",</span><br><span>    };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  printk(BIOS_SPEW, "PMxC0 STATUS: 0x%x ", pmxc0_status);</span><br><span style="color: hsl(120, 100%, 40%);">+     printk(BIOS_DEBUG, "PMxC0 STATUS: 0x%x ", pmxc0_status);</span><br><span>   print_num_status_bits(ARRAY_SIZE(pmxc0_status_bits), pmxc0_status,</span><br><span>                         pmxc0_status_bits);</span><br><span style="color: hsl(0, 100%, 40%);">-       printk(BIOS_SPEW, "\n");</span><br><span style="color: hsl(120, 100%, 40%);">+    printk(BIOS_DEBUG, "\n");</span><br><span> }</span><br><span> </span><br><span> /* After console init */</span><br><span>@@ -763,7 +762,7 @@</span><br><span> </span><br><span> static uint16_t print_pm1_status(uint16_t pm1_sts)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   static const char *const pm1_sts_bits[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+   static const char *const pm1_sts_bits[16] = {</span><br><span>                [0] = "TMROF",</span><br><span>             [4] = "BMSTATUS",</span><br><span>          [5] = "GBL",</span><br><span>@@ -776,9 +775,9 @@</span><br><span>         if (!pm1_sts)</span><br><span>                return 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   printk(BIOS_SPEW, "PM1_STS: ");</span><br><span style="color: hsl(120, 100%, 40%);">+     printk(BIOS_DEBUG, "PM1_STS: ");</span><br><span>   print_num_status_bits(ARRAY_SIZE(pm1_sts_bits), pm1_sts, pm1_sts_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_SPEW, "\n");</span><br><span style="color: hsl(120, 100%, 40%);">+    printk(BIOS_DEBUG, "\n");</span><br><span> </span><br><span>      return pm1_sts;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28885">change 28885</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28885"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: If7da8c7c86e90a661338903ad05cc41e11f507d2 </div>
<div style="display:none"> Gerrit-Change-Number: 28885 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Edward Hill <ecgh@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Edward Hill <ecgh@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>