<p><a href="https://review.coreboot.org/28862">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28862/2/src/southbridge/intel/common/reset.c">File src/southbridge/intel/common/reset.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28862/2/src/southbridge/intel/common/reset.c@28">Patch Set #2, Line 28:</a> <code style="font-family:monospace,monospace">FULL_RST</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This would issue a power-cycle reset, which is usually unwanted.<br>I'm also not sure if it's valid to set it w/o SYS_RST.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also worth to mention: I've seen different patterns regarding this<br>register. Older platforms set the configuration bits (FULL_RST and <br>or SYS_RST) first and then again with RST_CPU in a second outb().<br>It's still unclear (also not documented explicitly) if this is<br>needed, but it doesn't hurt. So I'd prefer two outb() calls unless<br>_all_ affected platforms did a single call before.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28862">change 28862</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28862"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8e359b0c4d5a1060edd0940d24c2f78dfed8a590 </div>
<div style="display:none"> Gerrit-Change-Number: 28862 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Alexandru Gagniuc <alexandrux.gagniuc@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 03 Oct 2018 13:40:12 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>