<p><a href="https://review.coreboot.org/28890">View Change</a></p><p>10 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28890/2/src/soc/intel/cannonlake/include/soc/gpio_soc_defs.h">File src/soc/intel/cannonlake/include/soc/gpio_soc_defs.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28890/2/src/soc/intel/cannonlake/include/soc/gpio_soc_defs.h@592">Patch Set #2, Line 592:</a> <code style="font-family:monospace,monospace">#define GPP_I0                    189</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28890/2/src/soc/intel/cannonlake/include/soc/gpio_soc_defs.h@593">Patch Set #2, Line 593:</a> <code style="font-family:monospace,monospace">#define GPP_I1                        190</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28890/2/src/soc/intel/cannonlake/include/soc/gpio_soc_defs.h@594">Patch Set #2, Line 594:</a> <code style="font-family:monospace,monospace">#define GPP_I2                        191</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28890/2/src/soc/intel/cannonlake/include/soc/gpio_soc_defs.h@595">Patch Set #2, Line 595:</a> <code style="font-family:monospace,monospace">#define GPP_I3                        192</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28890/2/src/soc/intel/cannonlake/include/soc/gpio_soc_defs.h@596">Patch Set #2, Line 596:</a> <code style="font-family:monospace,monospace">#define GPP_I4                        193</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28890/2/src/soc/intel/cannonlake/include/soc/gpio_soc_defs.h@597">Patch Set #2, Line 597:</a> <code style="font-family:monospace,monospace">#define GPP_I5                        194</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28890/2/src/soc/intel/cannonlake/include/soc/gpio_soc_defs.h@598">Patch Set #2, Line 598:</a> <code style="font-family:monospace,monospace">#define GPP_I6                        195</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28890/2/src/soc/intel/cannonlake/include/soc/gpio_soc_defs.h@599">Patch Set #2, Line 599:</a> <code style="font-family:monospace,monospace">#define GPP_I7                        196</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28890/2/src/soc/intel/cannonlake/include/soc/gpio_soc_defs.h@600">Patch Set #2, Line 600:</a> <code style="font-family:monospace,monospace">#define GPP_I8                        197</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28890/2/src/soc/intel/cannonlake/include/soc/gpio_soc_defs.h@601">Patch Set #2, Line 601:</a> <code style="font-family:monospace,monospace">#define GPP_I9                        198</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28890">change 28890</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28890"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I496ec059de125b97c646581bbd3b8bfe6ffa641e </div>
<div style="display:none"> Gerrit-Change-Number: 28890 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 03 Oct 2018 08:59:36 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>