<p>Raul Rangel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28881">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libpayload/x86/exception.c: Remove exception_install_hook<br><br>Not used by x86 code anymore.<br><br>BUG=b:116777191<br>TEST=Validated that depthcharge can be built.<br><br>Change-Id: I25ad3903989a5433ce73d657cfdb93dd1f34f7b5<br>Signed-off-by: Raul E Rangel <rrangel@chromium.org><br>---<br>M payloads/libpayload/arch/x86/exception.c<br>1 file changed, 0 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/28881/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/payloads/libpayload/arch/x86/exception.c b/payloads/libpayload/arch/x86/exception.c</span><br><span>index 3cd95bb..1fa1304 100644</span><br><span>--- a/payloads/libpayload/arch/x86/exception.c</span><br><span>+++ b/payloads/libpayload/arch/x86/exception.c</span><br><span>@@ -37,8 +37,6 @@</span><br><span> </span><br><span> u32 exception_stack[0x400] __attribute__((aligned(8)));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static exception_hook hook;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> static interrupt_handler handlers[256];</span><br><span> </span><br><span> static const char *names[EXC_COUNT] = {</span><br><span>@@ -181,9 +179,6 @@</span><br><span>        die_if(vec >= EXC_COUNT || !names[vec], "Bad exception vector %u\n",</span><br><span>           vec);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        if (hook && hook(vec))</span><br><span style="color: hsl(0, 100%, 40%);">-          return;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>      dump_exception_state();</span><br><span>      dump_stack(exception_state->regs.esp, 512);</span><br><span>       halt();</span><br><span>@@ -195,12 +190,6 @@</span><br><span>       exception_init_asm();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void exception_install_hook(exception_hook h)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-    die_if(hook, "Implement support for a list of hooks if you need it.");</span><br><span style="color: hsl(0, 100%, 40%);">-        hook = h;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> void set_interrupt_handler(u8 vector, interrupt_handler handler)</span><br><span> {</span><br><span>  handlers[vector] = handler;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28881">change 28881</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28881"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I25ad3903989a5433ce73d657cfdb93dd1f34f7b5 </div>
<div style="display:none"> Gerrit-Change-Number: 28881 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Raul Rangel <rrangel@chromium.org> </div>