<p><a href="https://review.coreboot.org/28872">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28872/2/src/lib/edid.c">File src/lib/edid.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28872/2/src/lib/edid.c@208">Patch Set #2, Line 208:</a> <code style="font-family:monospace,monospace">      if (IS_ENABLED(CONFIG_DEFAULT_CONSOLE_LOGLEVEL_8)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Default log level isn't guaranteed to be the same as effective log level. What you want is</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> if (console_log_level(BIOS_SPEW))</pre></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28872">change 28872</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28872"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I93dcab3db958480626fea6d99ab5289ebff04e8f </div>
<div style="display:none"> Gerrit-Change-Number: 28872 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer@gmx.net> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 02 Oct 2018 22:44:07 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>