<p>Angel Pons has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28851">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/autoport: Use romstage.c instead of early_southbridge.c<br><br>Until now, autoport used to create a dummy "romstage.c", then write<br>romstage code to "early_southbridge.c". While it works, it makes more<br>sense to write to "romstage.c" instead, as virtually all mainboards do.<br><br>Change-Id: If9f9375f9a659e7e685de5f884163813261fa656<br>Signed-off-by: Angel Pons <th3fanbus@gmail.com><br>---<br>M util/autoport/bd82x6x.go<br>M util/autoport/main.go<br>2 files changed, 1 insertion(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/28851/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go</span><br><span>index 31f7ced..887a520 100644</span><br><span>--- a/util/autoport/bd82x6x.go</span><br><span>+++ b/util/autoport/bd82x6x.go</span><br><span>@@ -299,9 +299,8 @@</span><br><span>            File: "southbridge/intel/bd82x6x/acpi/pch.asl",</span><br><span>    })</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  sb := Create(ctx, "early_southbridge.c")</span><br><span style="color: hsl(120, 100%, 40%);">+    sb := Create(ctx, "romstage.c")</span><br><span>    defer sb.Close()</span><br><span style="color: hsl(0, 100%, 40%);">-        AddROMStageFile("early_southbridge.c", "")</span><br><span>       Add_gpl(sb)</span><br><span>  sb.WriteString(`#include <stdint.h></span><br><span> #include <string.h></span><br><span>diff --git a/util/autoport/main.go b/util/autoport/main.go</span><br><span>index 3071559..ed56a55 100644</span><br><span>--- a/util/autoport/main.go</span><br><span>+++ b/util/autoport/main.go</span><br><span>@@ -827,10 +827,6 @@</span><br><span>               fmt.Fprintf(bi, "FIXME: put %s\n", missing)</span><br><span>        }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   rs := Create(ctx, "romstage.c")</span><br><span style="color: hsl(0, 100%, 40%);">-       defer rs.Close()</span><br><span style="color: hsl(0, 100%, 40%);">-        rs.WriteString("/* dummy file */\n")</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>       if ROMSizeKB == 0 {</span><br><span>          KconfigBool["BOARD_ROMSIZE_KB_2048"] = true</span><br><span>                KconfigComment["BOARD_ROMSIZE_KB_2048"] = "FIXME: correct this"</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28851">change 28851</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28851"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If9f9375f9a659e7e685de5f884163813261fa656 </div>
<div style="display:none"> Gerrit-Change-Number: 28851 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> </div>